BUG: 404344
FIXED-IN: 5.57
Add action icons for collapse-all and expand-all, as requested in D18358: Add buttons to collapse and expand all elements.
ngraham | |
trickyricky26 |
VDG |
BUG: 404344
FIXED-IN: 5.57
Add action icons for collapse-all and expand-all, as requested in D18358: Add buttons to collapse and expand all elements.
24px icons not included in these previews because they're the same as the 22px icons with slightly wider margins
Automatic diff as part of commit; lint not applicable. |
Automatic diff as part of commit; unit tests not applicable. |
Could we get symlinks for these that point to window-keep-above and window-keep-below too?
Ink KWin, the keep above and keep below icons are different. These are the shade/unshade buttons.
The symlinks in the symbolic folder should end with -symbolic (e.g., expand-all-symbolic.svg)
I just noticed, there is already a go-top icon that looks just like collapse-all. That's a problem. "Collapse all" is different enough from "Go to top" that they shouldn't be the same icon.
I do think that the arrow with the bar on top is more appropriate for "Collapse all" though, so I think go-top should be changed, along with the other go-* icons. Maybe double arrows like KWin's "Keep above" button? Then we would need to decide if "Go to top" is similar enough to "Keep above" that they should be allowed to look the same.
From the VDG chat:
Any thoughts on https://phabricator.kde.org/D19575 ? Should I make them match them to the titlebar ones which I think have a shorter top line, or do some symlinking action with arrow-up-double which is similar to these as well?
They should match the current version of go-top. The problem with matching the titlebar button is that it's not perfectly aligned with the grid. The titlebar button should probably be changed.
Use these, they're more similar to the titlebar shade button, but aligned to the pixel grid better. I will change the go-* icons in another patch.
Could you align the top of the down arrow in expand-all to the pixel grid and move it down by 1px? Like so:
This makes the down arrow look sharper and improves visual alignment with collapse-all: