Add collapse/expand-all, window-shade/unshade
ClosedPublic

Authored by ndavis on Mar 6 2019, 8:54 PM.

Details

Summary

BUG: 404344

FIXED-IN: 5.57

Add action icons for collapse-all and expand-all, as requested in D18358: Add buttons to collapse and expand all elements.

Test Plan


24px icons not included in these previews because they're the same as the 22px icons with slightly wider margins

Diff Detail

Repository
R266 Breeze Icons
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
trickyricky26 created this revision.Mar 6 2019, 8:54 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 6 2019, 8:54 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
trickyricky26 requested review of this revision.Mar 6 2019, 8:54 PM
trickyricky26 edited the summary of this revision. (Show Details)Mar 6 2019, 8:58 PM
trickyricky26 edited the test plan for this revision. (Show Details)
trickyricky26 added a reviewer: VDG.
trickyricky26 edited the summary of this revision. (Show Details)Mar 6 2019, 9:00 PM
trickyricky26 edited the summary of this revision. (Show Details)Mar 6 2019, 9:13 PM
ngraham accepted this revision.Mar 6 2019, 9:23 PM
ngraham added a subscriber: ngraham.

Looks great to me!

This revision is now accepted and ready to land.Mar 6 2019, 9:23 PM

Could we get symlinks for these that point to window-keep-above and window-keep-below too?

ndavis added a subscriber: ndavis.Mar 7 2019, 8:47 PM

Could we get symlinks for these that point to window-keep-above and window-keep-below too?

Ink KWin, the keep above and keep below icons are different. These are the shade/unshade buttons.

ndavis added a comment.EditedMar 7 2019, 8:49 PM

The symlinks in the symbolic folder should end with -symbolic (e.g., expand-all-symbolic.svg)

ndavis requested changes to this revision.Mar 7 2019, 8:49 PM
This revision now requires changes to proceed.Mar 7 2019, 8:49 PM
ndavis added a comment.Mar 7 2019, 9:14 PM

I just noticed, there is already a go-top icon that looks just like collapse-all. That's a problem. "Collapse all" is different enough from "Go to top" that they shouldn't be the same icon.

I do think that the arrow with the bar on top is more appropriate for "Collapse all" though, so I think go-top should be changed, along with the other go-* icons. Maybe double arrows like KWin's "Keep above" button? Then we would need to decide if "Go to top" is similar enough to "Keep above" that they should be allowed to look the same.

From the VDG chat:

Any thoughts on https://phabricator.kde.org/D19575 ? Should I make them match them to the titlebar ones which I think have a shorter top line, or do some symlinking action with arrow-up-double which is similar to these as well?

They should match the current version of go-top. The problem with matching the titlebar button is that it's not perfectly aligned with the grid. The titlebar button should probably be changed.

  • Name -symbolic icons properly
ndavis added a comment.Mar 8 2019, 8:40 PM

Use these, they're more similar to the titlebar shade button, but aligned to the pixel grid better. I will change the go-* icons in another patch.

  • Use design by @ndavis with tighter spacing
trickyricky26 edited the test plan for this revision. (Show Details)Mar 9 2019, 4:00 PM
ndavis accepted this revision.EditedMar 9 2019, 4:48 PM

Could you align the top of the down arrow in expand-all to the pixel grid and move it down by 1px? Like so:

This makes the down arrow look sharper and improves visual alignment with collapse-all:

This revision is now accepted and ready to land.Mar 9 2019, 4:48 PM
ndavis requested changes to this revision.Mar 9 2019, 4:48 PM
This revision now requires changes to proceed.Mar 9 2019, 4:48 PM

@trickyricky26 do you mind if I commandeer this so I can get it finished today?

Sure, go ahead. I'm busy right now

ndavis commandeered this revision.Mar 12 2019, 12:00 AM
ndavis edited reviewers, added: trickyricky26; removed: ndavis.
ndavis updated this revision to Diff 53744.Mar 12 2019, 5:34 PM

Lower down arrow on expand-all

ndavis updated this revision to Diff 53746.Mar 12 2019, 5:39 PM
  • Add window-shade/unshade
ndavis retitled this revision from Add collapse-all and expand-all action icons to Add collapse/expand-all, window-shade/unshade.Mar 12 2019, 5:48 PM
ndavis edited the test plan for this revision. (Show Details)
ngraham accepted this revision.Mar 12 2019, 6:01 PM

Lovely!

This revision is now accepted and ready to land.Mar 12 2019, 6:01 PM
This revision was automatically updated to reflect the committed changes.