Add view-orientation-auto/landscape/portrait
Needs ReviewPublic

Authored by ndavis on Mar 13 2019, 7:23 PM.

Details

Reviewers
apol
Group Reviewers
VDG
Summary

Screen orientation icons for D19690

Test Plan

Diff Detail

Repository
R266 Breeze Icons
Branch
rotate (branched from master)
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10655
Build 10673: arc lint + arc unit
ndavis created this revision.Mar 13 2019, 7:23 PM
Restricted Application added a project: Frameworks. · View Herald TranscriptMar 13 2019, 7:23 PM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
ndavis requested review of this revision.Mar 13 2019, 7:23 PM
ndavis edited the test plan for this revision. (Show Details)Mar 13 2019, 7:26 PM
ndavis updated this revision to Diff 53826.EditedMar 13 2019, 7:31 PM
ndavis edited the test plan for this revision. (Show Details)

Increase spacing between outside rotation marks and screen for 32px version

ndavis edited the test plan for this revision. (Show Details)Mar 13 2019, 7:32 PM

Hmm, TBH it feels too busy for me, especially at the smaller sizes. I wonder if it might benefit from using a single circular line with an arrowhead instead, like this comically crude mockup illustrates:

Hmm, TBH it feels too busy for me, especially at the smaller sizes. I wonder if it might benefit from using a single circular line with an arrowhead instead, like this comically crude mockup illustrates:

Unfortunately, there's just not enough space for that kind of icon at 16px. The screen in the icon has to be way too small, the arrow(s) has to be small enough that it turns into noise in the off version, the arrow has to make the icon weirdly uncentered or I need to forget about respecting the margins.

ndavis added a comment.EditedMar 19 2019, 3:55 AM

@ngraham Here's something similar to what you asked for:



This is 22px. I couldn't get it to work for 16px.

ndavis edited the test plan for this revision. (Show Details)Mar 19 2019, 4:02 AM

This is what the current 32px version with arrowheads added looks like, but it can't be done like that with 16px or 22px.

This is what the current 32px version with arrowheads added looks like, but it can't be done like that with 16px or 22px.

Maybe the rectangle itself doesn't need to be so big? Or maybe it could be even bigger and have the arrows inside?

apol added a comment.Mar 19 2019, 6:18 PM

How about having 3 icons? autorotate, locked portrait and locked landscape?

This way we don't need to have a weird red strike-through.

In D19736#434616, @apol wrote:

How about having 3 icons? autorotate, locked portrait and locked landscape?

This way we don't need to have a weird red strike-through.

That's what I asked about the first time in D19690#430032 :P

Sure, I can agree to that. I think being able to force a landscape or portrait orientation without going to the system settings would be a good feature.

Maybe the rectangle itself doesn't need to be so big? Or maybe it could be even bigger and have the arrows inside?

I can make the rectangle slightly smaller. I can't make the rectangle bigger because of margins, but I might be able to fit some small arrows inside at the current size

Aleix and I talked, and yeah, your original idea was good. So here's what we need:

  • An icon for auto-rotation mode
  • An icon for "locked to portrait" mode
  • An icon for "locked to landscape" mode
ndavis updated this revision to Diff 55804.Apr 9 2019, 9:32 AM
  • Change to 3 icons
ndavis retitled this revision from Add screen-rotate-auto-on/off to Add view-orientation-auto/landscape/portrait.Apr 9 2019, 9:34 AM
ndavis edited the summary of this revision. (Show Details)
ndavis edited the test plan for this revision. (Show Details)

How about a lock icon inside the rectangles to show that they're locked to that orientation? Those vertical and horizontal lines in the current version conjure up movement in my mind, which doesn't seem appropriate.