Differential D19629

Change media-skip* and media-seek* style
ClosedPublic
Actions

Authored by ndavis on Mar 9 2019, 5:06 AM.

Details

Reviewers

rooty
ngraham

Group Reviewers

VDG

Commits

R266:581ce275edbd: Change media-skip* and media-seek* style

Summary

Make media-skip* look more like standard skip forward/back symbols

Make media-seek* more consistent with media-skip*

Test Plan

Standard media control symbols: https://en.wikipedia.org/wiki/Media_controls

Before

Breeze:

Breeze Dark:

Dragon Player:

After

Breeze:

Breeze Dark:

Dragon Player:

Diff Detail

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ndavis created this revision.Mar 9 2019, 5:06 AM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 9 2019, 5:06 AM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ndavis requested review of this revision.Mar 9 2019, 5:06 AM

Harbormaster completed remote builds in B9364: Diff 53494.Mar 9 2019, 5:06 AM

ndavis edited the test plan for this revision. (Show Details)Mar 9 2019, 5:18 AM

ndavis edited the test plan for this revision. (Show Details)Mar 9 2019, 5:21 AM

ndavis edited the test plan for this revision. (Show Details)Mar 9 2019, 5:34 AM

A quick google search (mpv, VLC, windows media player, etc.) reveals that the change you're proposing is actually more in keeping with the standard than what we've been using (Spotify/Winamp). So, +1 from me

This revision is now accepted and ready to land.Mar 9 2019, 5:44 AM

Much better.

Closed by commit R266:581ce275edbd: Change media-skip* and media-seek* style (authored by ndavis). · Explain WhyMar 9 2019, 2:16 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			icons-dark/actions/16/media-seek-backward.svg (21 lines)
M			icons-dark/actions/16/media-seek-forward.svg (21 lines)
M			icons-dark/actions/16/media-skip-backward.svg (21 lines)
M			icons-dark/actions/16/media-skip-forward.svg (21 lines)
M			icons-dark/actions/22/media-seek-backward.svg (25 lines)
M			icons-dark/actions/22/media-seek-forward.svg (25 lines)
M			icons-dark/actions/22/media-skip-backward.svg (26 lines)
M			icons-dark/actions/22/media-skip-forward.svg (26 lines)
M			icons-dark/actions/24/media-seek-backward.svg (21 lines)
M			icons-dark/actions/24/media-seek-forward.svg (21 lines)
M			icons-dark/actions/24/media-skip-backward.svg (21 lines)
M			icons-dark/actions/24/media-skip-forward.svg (21 lines)
M			icons-dark/actions/32/media-seek-backward.svg (24 lines)
M			icons-dark/actions/32/media-seek-forward.svg (24 lines)
M			icons-dark/actions/32/media-skip-backward.svg (24 lines)
M			icons-dark/actions/32/media-skip-forward.svg (24 lines)
M			icons/actions/16/media-seek-backward.svg (21 lines)
M			icons/actions/16/media-seek-forward.svg (21 lines)
M			icons/actions/16/media-skip-backward.svg (21 lines)
M			icons/actions/16/media-skip-forward.svg (21 lines)
M			icons/actions/22/media-seek-backward.svg (25 lines)
M			icons/actions/22/media-seek-forward.svg (25 lines)
M			icons/actions/22/media-skip-backward.svg (26 lines)
M			icons/actions/22/media-skip-forward.svg (26 lines)
M			icons/actions/24/media-seek-backward.svg (21 lines)
M			icons/actions/24/media-seek-forward.svg (21 lines)
M			icons/actions/24/media-skip-backward.svg (21 lines)
M			icons/actions/24/media-skip-forward.svg (21 lines)
M			icons/actions/32/media-seek-backward.svg (24 lines)
M			icons/actions/32/media-seek-forward.svg (24 lines)
M			icons/actions/32/media-skip-backward.svg (24 lines)
M			icons/actions/32/media-skip-forward.svg (24 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	53494	ae8fcdc		Mar 9 2019, 5:06 AM	★	★
Diff 2	53510	0420b28	R266:581ce275edbdc11990128d468f338de5f4fd9326	Mar 9 2019, 2:16 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
d97c65af90af	b66ca246754a	c61323263eb3	Noah Davis	Make media-seek* more consistent with media-skip*	Mar 9 2019, 4:59 AM
c61323263eb3	556ee9b3fc79	ae8fcdcd409b	Noah Davis	Make media-skip* look more like standard skip forward/back symbols	Mar 9 2019, 4:55 AM