Differential D19641

jump
ClosedPublic
Actions

Authored by ndavis on Mar 9 2019, 5:36 PM.

Details

Reviewers

ngraham

Group Reviewers

VDG

Commits

R266:612a0134603d: Improve pixel grid alignment of go-up/down/next/previous/jump

Summary

These icons had subtle alignment issues. They weren't even always visible, but it's a problem when I'm trying to use parts of these icons in other icons.

Test Plan

Before

After

Diff Detail

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ndavis created this revision.Mar 9 2019, 5:36 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 9 2019, 5:36 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ndavis requested review of this revision.Mar 9 2019, 5:36 PM

Harbormaster completed remote builds in B9389: Diff 53533.Mar 9 2019, 5:36 PM

ndavis edited the test plan for this revision. (Show Details)Mar 9 2019, 5:42 PM

ngraham accepted this revision.Mar 10 2019, 4:54 AM

This revision is now accepted and ready to land.Mar 10 2019, 4:54 AM

Rebase on master

Harbormaster completed remote builds in B9410: Diff 53558.Mar 10 2019, 6:31 AM

Closed by commit R266:612a0134603d: Improve pixel grid alignment of go-up/down/next/previous/jump (authored by ndavis). · Explain WhyMar 10 2019, 6:32 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			icons-dark/actions/16/go-down.svg (21 lines)
M			icons-dark/actions/16/go-jump.svg (21 lines)
M			icons-dark/actions/16/go-next.svg (21 lines)
M			icons-dark/actions/16/go-previous.svg (21 lines)
M			icons-dark/actions/16/go-up.svg (21 lines)
M			icons-dark/actions/22/go-up.svg (24 lines)
M			icons-dark/actions/24/go-up.svg (21 lines)
M			icons-dark/actions/32/go-down.svg (24 lines)
M			icons-dark/actions/32/go-jump.svg (23 lines)
M			icons-dark/actions/32/go-next.svg (23 lines)
M			icons-dark/actions/32/go-previous.svg (23 lines)
M			icons-dark/actions/32/go-up.svg (23 lines)
M			icons/actions/16/go-down.svg (21 lines)
M			icons/actions/16/go-jump.svg (21 lines)
M			icons/actions/16/go-next.svg (21 lines)
M			icons/actions/16/go-previous.svg (21 lines)
M			icons/actions/16/go-up.svg (21 lines)
M			icons/actions/22/go-up.svg (24 lines)
M			icons/actions/24/go-up.svg (21 lines)
M			icons/actions/32/go-down.svg (24 lines)
M			icons/actions/32/go-jump.svg (23 lines)
M			icons/actions/32/go-next.svg (23 lines)
M			icons/actions/32/go-previous.svg (23 lines)
M			icons/actions/32/go-up.svg (23 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	53533	0a36b04		Mar 9 2019, 5:36 PM	★	★
Diff 2	53558	581ce27	Rebase on master	Mar 10 2019, 6:31 AM	★	★
Diff 3	53559	5959541	R266:612a0134603d865d803ddbb6d027e49a209c9d04	Mar 10 2019, 6:31 AM	★	★