Differential D19638

top look more like media-skip*
ClosedPublic
Actions

Authored by ndavis on Mar 9 2019, 5:00 PM.

Details

Reviewers

ngraham

Group Reviewers

VDG

Commits

R266:24067c74c2d6: Make go-bottom/first/last/top look more like media-skip*

Summary

Once D19575 lands, the style of go-top will conflict with the style of collapse-all. I'm changing the style of these related go- icons to look more like standard media control symbols for skip forward/backward.

Test Plan

Before

After

Okular:

Diff Detail

Repository

R266 Breeze Icons

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

ndavis created this revision.Mar 9 2019, 5:00 PM

Restricted Application added a project: Frameworks. · View Herald TranscriptMar 9 2019, 5:00 PM

Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript

ndavis requested review of this revision.Mar 9 2019, 5:00 PM

Harbormaster completed remote builds in B9387: Diff 53530.Mar 9 2019, 5:00 PM

ndavis edited the test plan for this revision. (Show Details)Mar 9 2019, 5:04 PM

ndavis mentioned this in D19633: Improve consistency of window-* and add more.Mar 9 2019, 5:07 PM

ndavis edited the test plan for this revision. (Show Details)Mar 9 2019, 6:34 PM

I think this makes sense!

This revision is now accepted and ready to land.Mar 10 2019, 4:50 AM

Rebase on master

Harbormaster completed remote builds in B9413: Diff 53563.Mar 10 2019, 6:39 AM

Closed by commit R266:24067c74c2d6: Make go-bottom/first/last/top look more like media-skip* (authored by ndavis). · Explain WhyMar 10 2019, 6:39 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			icons-dark/actions/16/go-bottom.svg (25 lines)
M			icons-dark/actions/16/go-first.svg (25 lines)
M			icons-dark/actions/16/go-last.svg (25 lines)
M			icons-dark/actions/16/go-top.svg (25 lines)
M			icons-dark/actions/22/go-bottom.svg (25 lines)
M			icons-dark/actions/22/go-first.svg (25 lines)
M			icons-dark/actions/22/go-last.svg (25 lines)
M			icons-dark/actions/22/go-top.svg (25 lines)
M			icons-dark/actions/24/go-bottom.svg (24 lines)
M			icons-dark/actions/24/go-first.svg (24 lines)
M			icons-dark/actions/24/go-last.svg (24 lines)
M			icons-dark/actions/24/go-top.svg (24 lines)
M			icons-dark/actions/32/go-bottom.svg (26 lines)
M			icons-dark/actions/32/go-first.svg (27 lines)
M			icons-dark/actions/32/go-last.svg (27 lines)
M			icons-dark/actions/32/go-top.svg (26 lines)
M			icons/actions/16/go-bottom.svg (25 lines)
M			icons/actions/16/go-first.svg (25 lines)
M			icons/actions/16/go-last.svg (25 lines)
M			icons/actions/16/go-top.svg (25 lines)
M			icons/actions/22/go-bottom.svg (25 lines)
M			icons/actions/22/go-first.svg (25 lines)
M			icons/actions/22/go-last.svg (25 lines)
M			icons/actions/22/go-top.svg (25 lines)
M			icons/actions/24/go-bottom.svg (24 lines)
M			icons/actions/24/go-first.svg (24 lines)
M			icons/actions/24/go-last.svg (24 lines)
M			icons/actions/24/go-top.svg (24 lines)
M			icons/actions/32/go-bottom.svg (26 lines)
M			icons/actions/32/go-first.svg (27 lines)
M			icons/actions/32/go-last.svg (27 lines)
M			icons/actions/32/go-top.svg (26 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	53530	a6bef47		Mar 9 2019, 5:00 PM	★	★
Diff 2	53563	f250904	Rebase on master	Mar 10 2019, 6:39 AM	★	★
Diff 3	53564	f250904	R266:24067c74c2d65067bd2e2f59adab008abb74af2a	Mar 10 2019, 6:39 AM	★	★