ekurzinger (Erik Kurzinger)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Oct 15 2018, 5:53 PM (18 w, 2 d)
Availability
Available

Recent Activity

Yesterday

ekurzinger added a comment to D18570: EGLStream DRM Backend Initial Implementation.

Is that in the KWayland master branch? In the file I'm looking at buffer_interface.cpp:152 is in the middle of a switch statement in the constructor.

Wed, Feb 20, 11:30 PM · KWin

Tue, Feb 19

ekurzinger updated the diff for D18570: EGLStream DRM Backend Initial Implementation.

Updated diff against HEAD

Tue, Feb 19, 8:25 PM · KWin

Thu, Feb 14

ekurzinger added a comment to D18570: EGLStream DRM Backend Initial Implementation.

First off: a driver not supporting Atomic Mode Setting is nothing modern. Does Nvidia has a plan to improve in this regard?

I'm really not happy, that the DrmOutput::present is not run and we have to export these internals from DrmOutput to the EglStreamBackend, which replaces the flip with an EGL function call. Why does the Nvidia driver not integrate with the libdrm API in regards to page flipping? It should be possible to at least offer a wrapper around it or not?

Thu, Feb 14, 10:51 PM · KWin
ekurzinger updated the diff for D18570: EGLStream DRM Backend Initial Implementation.
  • Fixed style issues in drm_backend.cpp / drm_output.h
  • Switched surface -> texture map to use SurfaceInterface pointers instead of wl_resource pointers
  • Moved eglQueryWaylandBufferWL to egl_stream_backend.cpp
  • Added support for receiving stream attributes from EglStreamControllerInterface (currently unused by the driver, but good for future proofness).
Thu, Feb 14, 8:11 PM · KWin
ekurzinger updated the diff for D18824: Implement wl_eglstream_controller Server Interface.

Thanks for taking a look, Roman. I've addressed your style suggestions and added support for passing stream attributes to the compositor. I had ignored these initially since the driver doesn't actually use this (fairly new) feature of the extension right now, but it probably is best to support it for future-proofness.

Thu, Feb 14, 7:28 PM · Frameworks

Tue, Feb 12

ekurzinger added a comment to D18570: EGLStream DRM Backend Initial Implementation.

Oh yeah, I've seen similar backtraces to that as well, actually. I think it's because QT is trying to share between an OpenGL context and an OpenGLES context. I don't think it's related to the compositor, though. It also occurs on GNOME and the weston eglstream port. I'm not sure if it's a QT bug or NVIDIA driver bug but I'll look into it a bit more as well.

Tue, Feb 12, 12:40 AM · KWin

Mon, Feb 11

ekurzinger added a comment to D18570: EGLStream DRM Backend Initial Implementation.
Mon, Feb 11, 9:48 PM · KWin

Fri, Feb 8

ekurzinger updated the diff for D18570: EGLStream DRM Backend Initial Implementation.

Use a KWayland wrapper around wayland-eglstream-controller instead of binding the interface from KWin. This avoids having to link against Wayland libraries. Depends on revision https://phabricator.kde.org/D18824 implementing the required KWayland class.

Fri, Feb 8, 10:53 PM · KWin

Thu, Feb 7

ekurzinger added a dependent revision for D18376: Fix software cursors with drm backend: D18570: EGLStream DRM Backend Initial Implementation.
Thu, Feb 7, 11:32 PM · KWin
ekurzinger added dependencies for D18570: EGLStream DRM Backend Initial Implementation: D18824: Implement wl_eglstream_controller Server Interface, D18376: Fix software cursors with drm backend.
Thu, Feb 7, 11:32 PM · KWin
ekurzinger added a dependent revision for D18824: Implement wl_eglstream_controller Server Interface: D18570: EGLStream DRM Backend Initial Implementation.
Thu, Feb 7, 11:32 PM · Frameworks
ekurzinger removed a dependency for D18824: Implement wl_eglstream_controller Server Interface: D18570: EGLStream DRM Backend Initial Implementation.
Thu, Feb 7, 11:32 PM · Frameworks
ekurzinger removed a dependency for D18376: Fix software cursors with drm backend: D18570: EGLStream DRM Backend Initial Implementation.
Thu, Feb 7, 11:32 PM · KWin
ekurzinger removed dependent revisions for D18570: EGLStream DRM Backend Initial Implementation: D18376: Fix software cursors with drm backend, D18824: Implement wl_eglstream_controller Server Interface.
Thu, Feb 7, 11:32 PM · KWin
ekurzinger added dependent revisions for D18570: EGLStream DRM Backend Initial Implementation: D18824: Implement wl_eglstream_controller Server Interface, D18376: Fix software cursors with drm backend.
Thu, Feb 7, 10:31 PM · KWin
ekurzinger added a dependency for D18824: Implement wl_eglstream_controller Server Interface: D18570: EGLStream DRM Backend Initial Implementation.
Thu, Feb 7, 10:31 PM · Frameworks
ekurzinger added a dependency for D18376: Fix software cursors with drm backend: D18570: EGLStream DRM Backend Initial Implementation.
Thu, Feb 7, 10:31 PM · KWin
ekurzinger requested review of D18824: Implement wl_eglstream_controller Server Interface.
Thu, Feb 7, 7:11 PM · Frameworks

Thu, Jan 31

ekurzinger added inline comments to D18570: EGLStream DRM Backend Initial Implementation.
Thu, Jan 31, 9:06 PM · KWin
ekurzinger updated the diff for D18570: EGLStream DRM Backend Initial Implementation.

Replaced dlopen / dlsym with QLibrary::resolve to avoid having to link against dl
Fixed a few more style issues
Added KWIN_BUILD_EGL_STREAM_BACKEND CMake option to control whether the new backend is built (defaults to ON).
Changed the name of the environment variable to KWIN_DRM_USE_EGL_STREAMS (instead of EGLDEVICE) to be a bit more consistent.

Thu, Jan 31, 9:03 PM · KWin
ekurzinger added inline comments to D18570: EGLStream DRM Backend Initial Implementation.
Thu, Jan 31, 7:44 PM · KWin

Wed, Jan 30

ekurzinger updated the diff for D18376: Fix software cursors with drm backend.

Instead of emitting cursorChanged from DrmBackend, modify SceneOpenGL to connect Platform::cursorChanged as opposed to Cursor::cursorChanged to the cursor texture update function.

Wed, Jan 30, 6:36 PM · KWin
ekurzinger updated the diff for D18570: EGLStream DRM Backend Initial Implementation.
Wed, Jan 30, 6:14 PM · KWin

Tue, Jan 29

ekurzinger closed D18307: Call frameRendered for undamaged Wayland surfaces.
Tue, Jan 29, 9:42 PM · KWin
ekurzinger updated the diff for D18570: EGLStream DRM Backend Initial Implementation.

Added context to the diff and fixed style issues, (thanks the feedback)

Tue, Jan 29, 9:39 PM · KWin
ekurzinger added 1 commit(s) for D18307: Call frameRendered for undamaged Wayland surfaces: R108:f294e7a03567: Call frameRendered for undamaged Wayland surfaces.
Tue, Jan 29, 9:20 PM · KWin
ekurzinger added an edge to R108:f294e7a03567: Call frameRendered for undamaged Wayland surfaces: D18307: Call frameRendered for undamaged Wayland surfaces.
Tue, Jan 29, 9:20 PM
ekurzinger added inline comments to D18570: EGLStream DRM Backend Initial Implementation.
Tue, Jan 29, 9:14 PM · KWin
ekurzinger moved T10362: Call frameRendered for undamaged Wayland surfaces from Under Review to Done on the KWin board.
Tue, Jan 29, 8:41 PM · KWin
ekurzinger committed R108:f294e7a03567: Call frameRendered for undamaged Wayland surfaces (authored by ekurzinger).
Call frameRendered for undamaged Wayland surfaces
Tue, Jan 29, 8:40 PM
ekurzinger added a comment to D18570: EGLStream DRM Backend Initial Implementation.
In D18570#401368, @hein wrote:

If I blacklist the kscreen2 kded module, I can get the session to start (otherwise it crashes during the splash). However, all surfaces (e.g. the panel or krunner) don't react to mouse clicks and seem frozen-ish.

BTW, while playing around with this I noticed that kwin_wayland doesn't work in windowed mode on X when run on nVidia EGL, due to the driver not implementing GL_OES_EGL_image.

Tue, Jan 29, 4:32 PM · KWin

Sun, Jan 27

ekurzinger requested review of D18570: EGLStream DRM Backend Initial Implementation.
Sun, Jan 27, 9:44 PM · KWin

Tue, Jan 22

ekurzinger added a comment to D18376: Fix software cursors with drm backend.

Thanks for taking a look, David. Regarding your suggestion, do you think it would make more sense then to connect Platform::cursorChanged to the texture update function in scene_opengl.cpp instead of Cursor::cursorChanged? I'm not entirely clear on the distinction between those two signals, but the former does get emitted when the cursor changes while it seems the latter does not at the moment.

Tue, Jan 22, 9:20 PM · KWin

Jan 18 2019

ekurzinger requested review of D18376: Fix software cursors with drm backend.
Jan 18 2019, 10:48 PM · KWin

Jan 17 2019

ekurzinger added a comment to D18307: Call frameRendered for undamaged Wayland surfaces.
In D18307#394965, @zzag wrote:

@ekurzinger Do you have commit access?

Jan 17 2019, 7:15 PM · KWin
ekurzinger updated the diff for D18307: Call frameRendered for undamaged Wayland surfaces.
Jan 17 2019, 7:12 PM · KWin

Jan 16 2019

ekurzinger added a reviewer for D18307: Call frameRendered for undamaged Wayland surfaces: romangg.
Jan 16 2019, 11:21 PM · KWin
ekurzinger removed a project from T10362: Call frameRendered for undamaged Wayland surfaces: Plasma on Wayland.
Jan 16 2019, 11:20 PM · KWin
ekurzinger added a project to T10362: Call frameRendered for undamaged Wayland surfaces: Plasma on Wayland.
Jan 16 2019, 11:19 PM · KWin
ekurzinger moved T10362: Call frameRendered for undamaged Wayland surfaces from Work In Progress to Under Review on the KWin board.
Jan 16 2019, 11:19 PM · KWin
ekurzinger added a revision to T10362: Call frameRendered for undamaged Wayland surfaces: D18307: Call frameRendered for undamaged Wayland surfaces.
Jan 16 2019, 11:19 PM · KWin
ekurzinger added a task to D18307: Call frameRendered for undamaged Wayland surfaces: T10362: Call frameRendered for undamaged Wayland surfaces.
Jan 16 2019, 11:19 PM · KWin
ekurzinger requested review of D18307: Call frameRendered for undamaged Wayland surfaces.
Jan 16 2019, 11:18 PM · KWin
ekurzinger moved T10362: Call frameRendered for undamaged Wayland surfaces from Backlog to Work In Progress on the KWin board.
Jan 16 2019, 11:00 PM · KWin
ekurzinger triaged T10362: Call frameRendered for undamaged Wayland surfaces as Normal priority.
Jan 16 2019, 11:00 PM · KWin

Oct 26 2018

ekurzinger added a comment to D16430: [effects/desktopgrid] Specify screen projection matrix when drawing moving window.

Hi David, thanks for taking a look! Note that I haven't got commit access so I believe someone will need to merge on my behalf. For authorship information, my name is Erik Kurzinger and email is ekurzinger@nvidia.com.

Oct 26 2018, 1:55 AM · KWin

Oct 25 2018

ekurzinger requested review of D16430: [effects/desktopgrid] Specify screen projection matrix when drawing moving window.
Oct 25 2018, 10:06 PM · KWin

Oct 20 2018

ekurzinger added a comment to D16278: [effects/presentwindows] Avoid potential freeze during fill-gaps.
In D16278#345365, @zzag wrote:

The freeze is still intermittent, but using this method should be able to be triggered within about 10 tries without this fix.

Well, I wasted hours trying to reproduce the bug with no luck.

So did I! Good job.

Oct 20 2018, 3:12 PM · KWin
ekurzinger updated the diff for D16278: [effects/presentwindows] Avoid potential freeze during fill-gaps.
Oct 20 2018, 3:02 PM · KWin

Oct 17 2018

ekurzinger added a comment to D16278: [effects/presentwindows] Avoid potential freeze during fill-gaps.

Sure, I have a single dolphin window positioned in the top-left corner of the leftmost desktop with dimensions 750 by 500. For some reason, the tool-tip for the "Split" button seems to be the most consistent way, but maybe that's just my imagination.
I have a single 1920x1200 monitor, and 3 virtual desktops in a single row. I've attached my kwinrc file in case there's anything else relevant there. Animation speed is set to 4, and the compositor backend is set to OpenGL 3.1

Oct 17 2018, 6:08 PM · KWin
ekurzinger updated the test plan for D16278: [effects/presentwindows] Avoid potential freeze during fill-gaps.
Oct 17 2018, 5:36 PM · KWin
ekurzinger added a comment to D16278: [effects/presentwindows] Avoid potential freeze during fill-gaps.

Hi Vlad,

Oct 17 2018, 5:23 PM · KWin
ekurzinger updated the summary of D16278: [effects/presentwindows] Avoid potential freeze during fill-gaps.
Oct 17 2018, 4:30 PM · KWin
ekurzinger updated the summary of D16278: [effects/presentwindows] Avoid potential freeze during fill-gaps.
Oct 17 2018, 4:30 PM · KWin
ekurzinger requested review of D16278: [effects/presentwindows] Avoid potential freeze during fill-gaps.
Oct 17 2018, 4:29 PM · KWin