[RFC] Use mipmap filtering in window thumbnails
ClosedPublic

Authored by fredrik on Feb 2 2018, 3:36 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
VDG
Summary

Blit the contents of the window texture to a separate mipmap texture, and (re)generate the mipmaps on each damage event.

The mipmap filter is the default linear filter, which results in soft images. Using a filter with a sharpening kernel, such as a cubic or a windowed sinc filter would produce better results, but this is still an improvement over not using a mipmap filter at all.

The scaling is gamma-correct when desktop GL is used.

Note that this patch only modifies the GLX path.

BUG: 390457

Diff Detail

Repository
R242 Plasma Framework (Library)
Lint
Lint Skipped
Unit
Unit Tests Skipped
fredrik created this revision.Feb 2 2018, 3:36 PM
Restricted Application added projects: Plasma, Frameworks. · View Herald TranscriptFeb 2 2018, 3:36 PM
Restricted Application added subscribers: Frameworks, plasma-devel. · View Herald Transcript
fredrik requested review of this revision.Feb 2 2018, 3:36 PM

Before and after:

hein added a subscriber: hein.Feb 2 2018, 6:18 PM

It's definitely nicer, but could we go for the full thing and make it crisper too?

ngraham added a subscriber: ngraham.Feb 2 2018, 6:33 PM

Crisper would definitely be nicer too, but if that's too hard, this is already a big visual win even in its current state.

What's the state of this? Bug 391915 just cropped up

ngraham edited the summary of this revision. (Show Details)Mar 17 2018, 4:20 AM

What's the state of this? Bug 391915 just cropped up

There are still some issues with the cubic filter, and I've been distracted by other things lately.
I think we should consider landing the current version in the meantime, because like @ngraham said, it is a big visual win even in its current state.

It would also be nice to get some testing before the release.

Could you please rebase on current master?

fredrik updated this revision to Diff 29832.Mar 18 2018, 12:42 PM

Rebase on master.

Thanks!

I tested it with several running applications, including windows with different apect ratios and combined previews for multiple instances of the same application. Looks great in every case.

+1 from me!

davidedmundson accepted this revision.Mar 21 2018, 2:31 PM
This revision is now accepted and ready to land.Mar 21 2018, 2:31 PM

Could we land this?