+1 LGTM

Ping

• Rebase

• Rebase and adapt

• Rebased

D12165 is better

LGTM and works as expected.
To make it run I had to manually edit the Raw diff and patch.
https://phabricator.kde.org/R293:07601590347f25ec1ec805e7df16e1f2d6badc9c was pulled at around 9:30 CET, but not last night, maybe not even at Fri, Apr 13, 05:10.
Please rebase. And do you have an explanation for this delay?

Hmmpf... Overlooked D12165. Looks like it can be done.

@bruns This works, but it is just a draft. I'll optimize as soon as you confirm that this path is worth following.

Single QDebug

• Optimize failure messages

• Hopefully get the enum right this time
• Use struct for summary

• Consider tmpfs as not mounted
• Bring back major/minor print out

Arrgh these deviceIds! Just realized this:
When logged in as root on tty1

$ baloodb devices 
Listing database contents...
+ device:43 indexed-items:3658 fstype:tmpfs fsname:tmpfs mount:/run/user/0
+ device:2049 indexed-items:2 fstype:ext4 fsname:/dev/sda1 mount:/

After logging out from tty1 and re-mounting smb share:

$ baloodb devices 
Listing database contents...
+ device:43 indexed-items:3658 fstype:cifs fsname://circulans/VideoPartition mount:/media/circulans/videopart
+ device:2049 indexed-items:2 fstype:ext4 fsname:/dev/sda1 mount:/

Btw, dolphin also gets a little confused by this, showing the mounted share as unmounted in Places

• Recreate sample files and adapt tests for mp3, m4a, ogg, opus, flac recreate files with

Sample files are broken, for no obvious reason. https://build.kde.org/view/Frameworks/job/Frameworks%20kfilemetadata%20kf5-qt5%20SUSEQt5.10/lastBuild/

In D12145#245023, @alexeymin wrote:

Just curious, why is this needed? To avoid dynamic memory allocations?

• (Prematurely) rebased on origin/master From now on -DBUILD_EXPERIMENTAL=on is needed to build
• Remove unnecessary includes

• Simple plugin variable

• Apply suggested change

Dolphin also fails to build, because of D11242.
Unless someone objects, comments or formally accepts, I'll land this in 2hrs.

On second thought I think it is cleaner to do D12114 and to rename userComment from "Comment" to "Notes"

In D12028#244243, @mgallien wrote:

I need more time. I will try to look at it today. By the way, the stack concept seems very useful. Thanks

In D12029#244237, @mgallien wrote:

Sorry for the delay. Thanks

Ping

• Camelcase variable names

In D11242#244085, @rikmills wrote:

Fails to build:

https://build.kde.org/job/Applications%20baloo-widgets%20kf5-qt5%20SUSEQt5.9/35/

https://kci.pangea.pub/job/bionic_unstable_baloo-widgets/77/

• Fix typo

Maybe remove the conditional and always use the linux-way?

• Improve printList summary

• Adapt to upstream changes
• Correct enum
• Apply suggested changes

• Optimize device listing even more

In D11245#243529, @ngraham wrote:

I'd like to see the Information Panel's configuration moved into Dolphin's Configure window.

• Optimize device list creation

Thank you once more. This is complicated stuff (for me), it will take some time to sink in.