- Add DateFormat enum
- Move value formatting to widgetfactory
Details
Details
- Reviewers
bruns ngraham - Group Reviewers
Baloo Dolphin - Commits
- R824:63965a70dee8: Add choice of date formats
make test
Diff Detail
Diff Detail
- Repository
- R824 Baloo Widgets
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
Could you re-base this on current master, please?
| src/widgetfactory.cpp | ||
|---|---|---|
| 148 | No need for whitespace | |
Comment Actions
In testing this out along with the UI to enable it, I found that it only affected the date shown under "Creation Date" in my PDFs, and not the date shown under "Modified".
Comment Actions
That is a little puzzling as it works here for both dates on any file I've checked e.g. test.pdf from kfilemetadata. Could you share your pdf?
Comment Actions
Is it normal behaviour that arc diff has to be forced with --update Dxxxxx after a rebase?
Comment Actions
Only pattern I could see - the english ones are CEST, the localized ones are CET or UTC.
| src/widgetfactory.cpp | ||
|---|---|---|
| 141 | make m_dateFormat QLocale::FormatType and move the conversion to the getter/setter. | |
Comment Actions
After the last build filemetadataitemcounttest failed for no obvious reason (40 elements versus 38 expected). Also since then 'Genre' tag is showing up with an empty value for some audio sample files in Info Panel.
It would be helpful if somebody could confirm this. It might be that something is wrong upstream.
EDIT: Fixed in D12029
Comment Actions
Huh, can't reproduce my issue; everything works perfectly with this patchset. Code looks sane too.