Differential D12108

ffmpegextractor: Silence deprecation warnings
ClosedPublic
Actions

Authored by michaelh on Apr 11 2018, 11:51 AM.

Details

Reviewers
mgallien
Group Reviewers
Baloo
Frameworks
Commits
R286:037208a787e0: ffmpegextractor: Silence deprecation warnings
Test Plan

make

Diff Detail

Repository
R286 KFileMetaData
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
michaelh created this revision.Apr 11 2018, 11:51 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 11 2018, 11:51 AM
michaelh requested review of this revision.Apr 11 2018, 11:51 AM
bruns added a subscriber: bruns.Apr 12 2018, 6:33 PM
mgallien accepted this revision.Apr 18 2018, 8:20 PM
mgallien added a subscriber: mgallien.

Thanks.

I did try to fix it some months ago but did not finished however I noticed that there is no automatic tests for it. Do you have time to work on some ?

This revision is now accepted and ready to land.Apr 18 2018, 8:20 PM
michaelh added a comment.Apr 19 2018, 11:37 AM
In D12108#249246, @mgallien wrote:

Thanks.

I did try to fix it some months ago but did not finished however I noticed that there is no automatic tests for it. Do you have time to work on some ?

It's already on my list, but with low priority.

michaelh updated this revision to Diff 32552.Apr 19 2018, 11:38 AM
michaelh edited the test plan for this revision. (Show Details)

-Rebase

Closed by commit R286:037208a787e0: ffmpegextractor: Silence deprecation warnings (authored by michaelh). · Explain WhyApr 19 2018, 11:39 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathPackages
Msrc/extractors/ffmpegextractor.cpp (2 lines)

Diff 32553

View Options

src/extractors/ffmpegextractor.cpp

Loading...