Too bad ffmpegthumbs is for videos only.
- Queries
- All Stories
- Search
- Advanced Search
Advanced Search
Apr 19 2018
-2
https://cgit.kde.org/ffmpegthumbs.git/ should be useable, not sure though.
In D12156#249971, @astippich wrote:In D12156#249951, @michaelh wrote:It's for elisa I guess, could you please elaborate how POPM/RATING is going to be used and why xattr are not applicable?
It will be used as a fallback when there is no xattr rating set or available (e.g. on Windows) so that users who have rated their music with other players can still see their previous ratings.
It will also useful for managing ratings on other platforms when writing support is added.
- Indent
It's for elisa I guess, could you please elaborate how POPM/RATING is going to be used and why xattr are not applicable?
I'm sorry for making so much noise with all those stupid mistakes. It's probably best for me to let this rest for a few days, relax a little and gain some distance.
- That was no typo
- Correct typo
- Revert most previous changes
- Use isMounted() and isObscured()
- Remove documents recursively
- Rebase
- Apply some suggested changes
-Rebase
In D12108#249246, @mgallien wrote:Thanks.
I did try to fix it some months ago but did not finished however I noticed that there is no automatic tests for it. Do you have time to work on some ?
- Bump minimum required version of baloo-widgets
Apr 17 2018
- Filter by device id
I went I little overboard with remove_if and had to repair.
Device filtering is also broken see inline comment.
- Apply suggested changes
- Repair cleaning
- Comment some decisions
Apr 16 2018
- Apply suggested change
- Use remove_if
- Apply suggested changes
In D11245#246952, @elvisangelaccio wrote:This patch should have bumped the minimum required version of baloo-widgets.
- Include omissions
- Const!
- Rebase
- Wrap transaction operations
- Remove unrelated whitespace change
Apr 15 2018
If this is correct, I can extend.
In D12135#246895, @bcooksley wrote:If there are multiple reviewers then approval of all reviewers is required which is why your approval was also needed
In D12135#246831, @bcooksley wrote:The original author/submitter of a diff for review isn't able to approve their own review, which is why Stefan wasn't permitted to approve this diff.
- Rebase on D12044
- Rebase
Corrupt the database
As described in BUG: 392877?
Create cross extractor test
In D11882#245719, @bruns wrote:Maybe we can add a trivial dummy extractor which is used in unittests, but not anywhere else. It could e.g. return the current date, compilation timestamp (i.e. DATE), and the KF version.
Of course, but what's the logic here? Does it have to be accepted by a member of Baloo other than you? If I had known ....
In D12192#246449, @bruns wrote:Can you add a little bit more info to the commit message, e.g. an example how the output looks before and after?
In D11820#246525, @astippich wrote:Sorry for the late answer. Isn't this already handled in widgetfactory.cpp toString function (line 87)? During my testing with multiple values I've never had issues with baloo-widgets, only with baloo itself.
Have you tried autotests/samplefiles/multi/*.* of D12197? For me baloo-widgets mostly displays only one author or keyword. Also...
In D10694#246466, @bruns wrote:A QMap can store multiple values for one key, and a client reading the Map can use QMap::values() to get a list of all matching properties. If a client naively uses value() instead, it just gets the first value for the key, but so be it.
Due to a bug in calligra test.odt file is broken. see D11971.
- Improve access filtering
Apr 14 2018
- Ignore tmpfs devices
In D12206#246284, @ngraham wrote:In D12206#246282, @michaelh wrote:"Open with VLC" is of course nonsense.
Huh? Not sure I understand.
The default app for folders is dolphin. So the entry above "Open with..." should be dropped.
In D12206#246284, @ngraham wrote:In D12206#246282, @michaelh wrote:I find "Open with..." for folders useful.
What apps do you typically open folders in? What's the use case?
- Watching Image galleries
- Watching video series
- Filelight/KDirstat
- KdeSvn
I find "Open with..." for folders useful. "Open with VLC" is of course nonsense.
Superseded by D12197
Remove tests from epubextractortest use multivaluetest instead
Make it depend on D12197
@bruns: autotests/unit/engine/queryparsertest.cpp and autotests/unit/engine/termgeneratortest.cpp are encoded with iso-8859-15. Maybe you're able to convert them to utf-8. Even with a lot of help I couldn't.
Please give it a try, because it's better to extend the existing test files. But currently they do not accept chinese characters.
- Adapt to upstream changes
- Adapt to upstream changes