sanitizer: Move implementation into Baloo namespace
ClosedPublic
Actions

Authored by michaelh on Mar 16 2018, 4:45 PM.

Details

Reviewers

Group Reviewers

Baloo
Frameworks

Maniphest Tasks

T8250: Sanitize the database

Commits

R293:5e471c3d39b3: sanitizer: Move implementation into Baloo namespace

Summary

By doing this DatabaseSanitizer::getDocuments() can be removed from the public API and also q-pointer is no longer necessary

Diff Detail

Repository

R293 Baloo

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

michaelh created this revision.Mar 16 2018, 4:45 PM

Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptMar 16 2018, 4:45 PM

michaelh requested review of this revision.Mar 16 2018, 4:45 PM

Only looked at the diff, but nothing suspicious seen. If it builds and works, should be fine :)

Perhaps mention in the commit message also that this moving into the namespace allows to remove DatabaseSanitizer::getDocuments() from the public API, so it gets more clear why this change was done and why there are also those changes in the patch. The reader of this commit in 2 years might be abit thankful :)

This revision is now accepted and ready to land.Mar 16 2018, 6:32 PM

michaelh edited the summary of this revision. (Show Details)Mar 16 2018, 6:40 PM

michaelh edited the summary of this revision. (Show Details)

Closed by commit R293:5e471c3d39b3: sanitizer: Move implementation into Baloo namespace (authored by michaelh). · Explain WhyMar 16 2018, 6:43 PM

This revision was automatically updated to reflect the committed changes.

michaelh added a task: T8250: Sanitize the database.Apr 12 2018, 9:09 PM