Differential D12093

filemetadatadatedisplaytest: Build and pass with < Qt5.10
ClosedPublic
Actions

Authored by michaelh on Apr 10 2018, 4:54 PM.

Details

Reviewers

ngraham
bruns

Group Reviewers

Baloo
Dolphin

Commits

R824:ec515bad24f6: filemetadatadatedisplaytest: Build and pass with < Qt5.10

Summary

QFile::setFileTime was introduced in Qt5.10

Fixes build failures in CI of D11242

Test Plan

#if QT_VERSION < QT_VERSION_CHECK(5, 99, 0)
make && make test

#if QT_VERSION < QT_VERSION_CHECK(5, 10, 0)
make && make test

Diff Detail

Repository

R824 Baloo Widgets

Lint

Automatic diff as part of commit; lint not applicable.

Unit

Automatic diff as part of commit; unit tests not applicable.

michaelh created this revision.Apr 10 2018, 4:54 PM

Restricted Application added a project: Baloo. · View Herald TranscriptApr 10 2018, 4:54 PM

michaelh requested review of this revision.Apr 10 2018, 4:54 PM

ngraham added inline comments.Apr 10 2018, 4:55 PM

autotests/filemetadatadatedisplaytest.cpp
36	20?

Maybe remove the conditional and always use the linux-way?

Fix typo

michaelh marked an inline comment as done.Apr 10 2018, 4:58 PM

michaelh mentioned this in D11242: Add choice of date formats.Apr 11 2018, 7:32 AM

michaelh edited the summary of this revision. (Show Details)Apr 11 2018, 7:48 AM

Camelcase variable names

+1, but someone else must approve.

Seems ok for me too.

Dolphin also fails to build, because of D11242.
Unless someone objects, comments or formally accepts, I'll land this in 2hrs.

This revision was not accepted when it landed; it landed in state Needs Review.Apr 11 2018, 7:11 PM

Closed by commit R824:ec515bad24f6: filemetadatadatedisplaytest: Build and pass with < Qt5.10 (authored by michaelh). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

			Path	Packages
M			autotests/filemetadatadatedisplaytest.h (11 lines)
M			autotests/filemetadatadatedisplaytest.cpp (49 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	31827	63965a7		Apr 10 2018, 4:49 PM	★	★
Diff 2	31828	63965a7	- Fix typo	Apr 10 2018, 4:57 PM	★	★
Diff 3	31864	63965a7	- Camelcase variable names	Apr 11 2018, 10:37 AM	★	★
Diff 4	31916	63965a7	R824:ec515bad24f66e0232056f91bf156dd2d5041288	Apr 11 2018, 7:14 PM	★	★

Commit	Tree	Parents	Author	Summary	Date
741df0e560d9	e25be39d73bf	23e6dbd13fcf	Michael Heidelbach	Camelcase variable names	Apr 11 2018, 10:40 AM
23e6dbd13fcf	0d0501b5bb83	4a12ccde1c1d	Michael Heidelbach	Fix typo	Apr 10 2018, 4:59 PM
4a12ccde1c1d	f6b75f175f88	63965a70dee8	Michael Heidelbach	filemetadatadatedisplaytest: Build and pass with < Qt5.10	Apr 10 2018, 4:51 PM

filemetadatadatedisplaytest: Build and pass with < Qt5.10ClosedPublicActions

Details

Diff Detail

Revision ContentsChangeset List

Diff 31916

autotests/filemetadatadatedisplaytest.h

autotests/filemetadatadatedisplaytest.cpp

filemetadatadatedisplaytest: Build and pass with < Qt5.10
ClosedPublic
Actions

Revision Contents
Changeset List