Details
- Reviewers
elvisangelaccio michaelh - Group Reviewers
Baloo Frameworks
Diff Detail
- Repository
- R824 Baloo Widgets
- Branch
- testexe (branched from master)
- Lint
No Linters Available - Unit
No Unit Test Coverage
autotests/filemetadatawidgettest.cpp | ||
---|---|---|
60 | Should probably use QDir::listSeparator() instead of this #ifdef logic |
autotests/filemetadatawidgettest.cpp | ||
---|---|---|
60 | Great! Thanks. |
Code looks fine, but I did not test if it actually works. ;)
autotests/filemetadatawidgettest.cpp | ||
---|---|---|
58 | Missing space after comma? |
It's a little hard to see the effect of this, because the installed extractor and the freshly built have to differ somehow. D11913 brought the necessity for this into the light.
Maybe we can add a trivial dummy extractor which is used in unittests, but not anywhere else. It could e.g. return the current date, compilation timestamp (i.e. DATE), and the KF version.
I'm not sure if this wouldn't be too error prone. Every change in baloo_filemetadata_temp_extractor has to be accompanied by a respective change in the dummy.
Someone new to the code and not as skilled as you are might overlook that.
Also that wouldn't help much as in src/indexeddataretriever.cpp:
IndexedDataRetriever::start() const QString exe = QStandardPaths::findExecutable(QLatin1String("baloo_filemetadata_temp_extractor"));