Property::Description did not make it into KF5, Property::Comment is used instead .
This patch revives 'Description' for the DublinCore metadata as it is more specific and avoids confusion.
Changes the property for xml, epub, odf and office documents
Details
Details
- Reviewers
bruns - Group Reviewers
Baloo Frameworks - Commits
- R286:103f86746b8a: Revive 'Description' property for DublinCore metadata
make test
Diff Detail
Diff Detail
- Repository
- R286 KFileMetaData
- Lint
Automatic diff as part of commit; lint not applicable. - Unit
Automatic diff as part of commit; unit tests not applicable.
Comment Actions
@michaelh - are you still working on this?
I think using Property::Description for dc::description and the like is very sensible, so I would welcome if you pushed this forward.
Regarding the submission scheme, can you split this up into two distinct reviews, the first one adding autotests, covering the status quo as is, and the second one doing the transition from Propery::Comment to Property::Description
| autotests/office2007extractortest.cpp | ||
|---|---|---|
| 52 | Strictly speaking, this should be part of another commit. | |
| autotests/office2007extractortest.cpp | ||
|---|---|---|
| 52 | Just to let you know, I'm currently having issues creating a new test file. Saving with LibreOffice to .docx causes an incorrect mime type of the file, which is also reflected in this diff (see below). This seems to be a bug in LibreOffice. Looks like I have to use MS Word here. | |
Comment Actions
I've reverted the test data for docx format for now, since there are apparently more issues. Funnily, LibreOffice and MS Word label the description property with "Comment".