Since R824:caf155114b3b users can check/uncheck userComments in InfoPanel's config dialog.
Because of the same label this obscures the setting for comments stored in the file.
Details
Details
Diff Detail
Diff Detail
- Repository
- R824 Baloo Widgets
- Branch
- userComment (branched from Applications/18.04)
- Lint
No Linters Available - Unit
No Unit Test Coverage
| src/filemetadataprovider.cpp | ||
|---|---|---|
| 397 | The label name is not good. Maybe a native speaker can come up with something better. | |
| src/filemetadataprovider.cpp | ||
|---|---|---|
| 397 | Annotation, Note | |
| src/filemetadataprovider.cpp | ||
|---|---|---|
| 397 | Another idea: Keep the userComment as "Comment" and use "Description" for comment | |
| src/filemetadataprovider.cpp | ||
|---|---|---|
| 397 | Note that this is a string change and will need approval from the i18n team before landing on 18.04 | |
Comment Actions
Does this change the string that's displayed in the UI? If so, maybe just "Comments" or "Notes"
Comment Actions
It does. Currently it is:
| UI | internal name |
| Comment | userComment |
| Comment | comment |
We should not use a plural here, because because both are single-value properties. And there is some singular/plural confusion already present with e.g. Artist, Language an so on. see D10803.
Additional note:
For ODF, MSOffice docs and ebooks kfilemetadata translates the dc:description field to Property::Comment.
Comment Actions
so comment is an extracted property, and userComment is the thing that you can set in Dolphin?
Comment Actions
OK, I like your last idea, Michael. I'd be okay with this:
It does. Currently it is:
| UI | internal name |
| Comment | userComment |
| Description | comment |
As long as that doesn't conflict with a potential real "description" tag, of course.
Comment Actions
So for dc:description "Description" is obviously a good fit, and we are just tunneling it through a badly name Property. Which other file/metadata tags fill in this property?
Comment Actions
On second thought I think it is cleaner to do D12114 and to rename userComment from "Comment" to "Notes"
Comment Actions
If the current use of Property::Comment for dc::description is changed to Property::Description (see D12114), there no longer is a name clash with Comment
I have checked for other users of user.xdg.comment, apparently only KDE supports it.
I have checked DublinCore, there is (currently) no clash with a hypothetical "dc:note" or "dc:comment" property.
My vote is on doing D12114 and using Property::Comment resp. "Comment" (UI) for xdg.user.comment.