Differential D12165

Use QStorageInfo instead of a homegrown implementation
ClosedPublic
Actions

Authored by bruns on Apr 13 2018, 3:10 AM.

Details

Reviewers
michaelh
Group Reviewers
Baloo
Maniphest Tasks
T8250: Sanitize the database
Commits
R293:0491ba6e8e96: Use QStorageInfo instead of a homegrown implementation
Summary

The homegrown implementation only supports Linux

Test Plan

make
baloodb devices
baloodb list

Diff Detail

Repository
R293 Baloo
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
bruns created this revision.Apr 13 2018, 3:10 AM
Restricted Application added projects: Frameworks, Baloo. · View Herald TranscriptApr 13 2018, 3:10 AM
Restricted Application added a subscriber: Frameworks. · View Herald Transcript
bruns requested review of this revision.Apr 13 2018, 3:10 AM
bruns added a comment.Apr 13 2018, 3:13 AM

Should probably land before D11745

michaelh added a comment.Apr 13 2018, 8:38 AM
$ arc patch D12165
 INFO  Base commit is not in local repository; trying to fetch.
Created and checked out branch arcpatch-D12165.
Created and checked out branch arcpatch-D11285. <====== ???
Prüfe Patch src/engine/transaction.h ...
...
 Cherry Pick Failed!
 Exception 
Command failed with error #1!
COMMAND
git cherry-pick 'arcpatch-D11285'<====== ???
michaelh added a comment.Apr 13 2018, 9:21 AM

LGTM and works as expected.
To make it run I had to manually edit the Raw diff and patch.
https://phabricator.kde.org/R293:07601590347f25ec1ec805e7df16e1f2d6badc9c was pulled at around 9:30 CET, but not last night, maybe not even at Fri, Apr 13, 05:10.
Please rebase. And do you have an explanation for this delay?

michaelh accepted this revision.Apr 13 2018, 8:51 PM
This revision is now accepted and ready to land.Apr 13 2018, 8:51 PM
Closed by commit R293:0491ba6e8e96: Use QStorageInfo instead of a homegrown implementation (authored by bruns). · Explain WhyApr 13 2018, 11:17 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 32087

View Options

src/engine/experimental/databasesanitizer.cpp

Loading...
View Options

src/engine/fsutils.h

Loading...
View Options

src/engine/fsutils.cpp

Loading...