Actually remove the conditional since 5.16 depends on KF 5.58

Use non-deprecated variable

Use non-deprecated variable

Can you push this to 19.04 please? So we don't have to carry a patch for 4 months.

This fixes build with -DQCA_INSTALL_IN_QT_PREFIX=ON

In D20239#443172, @apol wrote:

We will also somehow have to notify distros that kwin needs to be recompiled when they switch Qt versions there. @jriddell maybe it can be part of the release notes somehow?

Apparently tooltips need a fix too https://bbs.archlinux.org/viewtopic.php?pid=1837417#p1837417

There's D19698 already

This is making Plasma crash, see https://bugs.kde.org/show_bug.cgi?id=405351

Pushed

The last 18.12 release tarballs are done already, so unless you think this is worth a respin there's no point to merge it. (cc @cfeck )

In D19549#425406, @sirgienko wrote:

A question, @arojas, how you found this problem, on build step? I have read 1.1 release news, but as I see, julia team hasen't mention, that C-API for exception changed.

Fix exception display

You also need to change '-Xclang -add-plugin -Xclang clang-lazy' to '-Xclang -add-plugin -Xclang clazy' for the plugin to actually be used.

Only master ot 4.10 too?

@asturmlechner can you post that in a new review request? I'll abandon this one.

In D16406#349046, @aacid wrote:

When you say "But this one needs to be fixed in the 3.1 branch too" you mean D16406 (i.e. this very same patch) or the compilation error because of the overrides?

Indeed git master doesn't build with 0.55:

Invert conditional

I don't mind either way. In the future this could be changed to VERSION_GREATER_EQUAL when this can depend on cmake 3.7

Check for poppler version at cmake time

Already fixed another way

Use DOC_INSTALL_DIR