This change has broken builds on Windows
https://binary-factory.kde.org/job/Craft_Build_Cache_windows-msvc2017_64-cl-debug/lastFailedBuild/console

Can we revert this please, especially with regards to the install_pdb macro?

I do not know if the pdb change is correct. It was smashed into a seemingly unrelated change for ossl library imports, the commit message explains neither the intent nor purpose of any of the changes in QcaMacro and @vonreth hasn't really commented on any of the discussion surrounding the regressions caused by that originally faulty commit. So I genuinely do not feel comfortable doing anything on this file.

The build you posted seems more hung up on a cmake regression (I am guessing) since it raises errors where it should raise deprecation warnings as per https://cmake.org/cmake/help/v3.12/policy/CMP0026.html and I do see the build passing on cmake 3.13.4. That said if someone can check that explicitly setting cmake_policy(SET CMP0026 OLD) fixes it I think that'd be a reasonable way to fix it without risking regressions in lieu of verification that the pdb change is in fact sound.

I'll ask Hannah to take a look. Given the PDB code is Windows only and the code prior to this change works on Windows fine, I suspect that change is very much needed to make Windows work properly.

@vonreth can you confirm?

I can't remember all details of why I touched the pdb code, but it was broken and obviously hard to read.
So instead of investigating how to make it work I replaced it with a modern solution.

I'm not following phabricator that active because in recent times people add me as a build bot instead of booting Windows.