Differential D21246

Search also legacy location for knsrc files
AbandonedPublic
Actions

Authored by arojas on May 16 2019, 8:49 PM.

Details

Reviewers
leinir
apol
Summary

Discover 5.16 beta only searches for knrsc files in the new /usr/share/knsrcfiles location, but most applications still install them to the legacy /etc/xdg location, so search there too.

Test Plan

All categories are displayed instead of only a few of them

Diff Detail

Repository
R134 Discover Software Store
Lint
Lint Skipped
Unit
Unit Tests Skipped
arojas created this revision.May 16 2019, 8:49 PM
Restricted Application added a project: Plasma. · View Herald TranscriptMay 16 2019, 8:49 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
arojas requested review of this revision.May 16 2019, 8:49 PM
arojas updated this revision to Diff 58177.May 16 2019, 9:03 PM

Actually remove the conditional since 5.16 depends on KF 5.58

arojas abandoned this revision.May 17 2019, 6:33 AM

OK I see in https://phabricator.kde.org/D19340 this is intentional

leinir added a comment.May 17 2019, 7:00 AM
In D21246#466158, @arojas wrote:

OK I see in https://phabricator.kde.org/D19340 this is intentional

Yes, i'm afraid it's one of those unfortunate side effects of having to fix a pretty hefty sort of bug which caused a fair few people a lot of anguish. Well spotted otherwise, and it would certainly seem to be a good time to (now Frameworks has had a release with the code) get this updated in the various applications which use KNS. We'd need to do this either by using the new install location from KNewStuffCore's cmake module, or by hand picking that install location manually (if, for some reason, there is a desire in the application to not depend on such a new Frameworks release, which i guess i can understand in some cases).

Revision Contents
Changeset List

Diff 58177

View Options

libdiscover/backends/KNSBackend/KNSBackend.cpp

Loading...