Fix displaying covers from cover.jpg files
ClosedPublic

Authored by arojas on Sat, Feb 9, 8:29 PM.

Details

Summary

Currently, images from cover.jpg files in the currently playing file are unconditionally overwritten with embedded covers, so cover images are never displayed for files that don't have embedded cover info.

Test Plan

Played some files without embedded covers, the cover image from cover.jpg is correctly displayed

Diff Detail

Repository
R344 Juk
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas requested review of this revision.Sat, Feb 9, 8:29 PM
arojas created this revision.
mpyne accepted this revision.Mon, Feb 18, 5:22 PM

This is good to commit. Note that JuK's repository is in testing for a trial KDE is running of GitLab, so you'll need to commit to the JuK repository at https://invent.kde.org/kde/juk

You can also enter other pull requests or issues for JuK there while we demo GitLab's features.

This revision is now accepted and ready to land.Mon, Feb 18, 5:22 PM
This revision was automatically updated to reflect the committed changes.