Differential D16081

Fix build with gpsd 3.18
ClosedPublic
Actions

Authored by arojas on Oct 9 2018, 4:26 PM.

Details

Reviewers
davidedmundson
Group Reviewers
Plasma
Commits
R120:81a0fe6db9ac: Fix build with gpsd 3.18
Summary

The signature of gps_read has changed in 3.18 to add an optional buffer parameter.
Passing NULL, 0 should keep the previous behavior, see https://git.savannah.gnu.org/cgit/gpsd.git/commit?id=6bba8b329fc7687b15863d30471d5af402467802

Test Plan

Builds with gpsd 3.17 and 3.18. Can't test if it works since I don't have a gps device.

Diff Detail

Repository
R120 Plasma Workspace
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Oct 9 2018, 4:26 PM
Restricted Application added a project: Plasma. · View Herald TranscriptOct 9 2018, 4:26 PM
Restricted Application added a subscriber: plasma-devel. · View Herald Transcript
arojas requested review of this revision.Oct 9 2018, 4:26 PM
davidedmundson accepted this revision.Oct 15 2018, 3:06 PM
This revision is now accepted and ready to land.Oct 15 2018, 3:06 PM
Closed by commit R120:81a0fe6db9ac: Fix build with gpsd 3.18 (authored by arojas). · Explain WhyOct 15 2018, 6:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 43676

View Options

dataengines/geolocation/location_gps.cpp

Loading...