Differential D15852

Fix doc dir in launcher script
AbandonedPublic
Actions

Authored by arojas on Sep 30 2018, 9:40 AM.

Details

Reviewers
smartins
jriddell
Summary

The doc install dir was changed to share/doc/clazy in a1b1d54e27eb4c592a2eff4767058da108ea16f0, but the launcher script was not updated so it still points to the old location

Test Plan

'clazy --list' works instead of throwing errors

Diff Detail

Repository
R74 Clazy
Lint
Lint Skipped
Unit
Unit Tests Skipped
arojas requested review of this revision.Sep 30 2018, 9:40 AM
arojas created this revision.
pino added a subscriber: pino.Sep 30 2018, 9:55 AM
pino added inline comments.
clazy.cmake
5

IMHO it'd better to use the DOC_INSTALL_DIR variable set in CMakeLists.txt, although it means that that variable needs to be moved before the configure_file that creates this clazy script

arojas updated this revision to Diff 42590.Sep 30 2018, 10:08 AM

Use DOC_INSTALL_DIR

arojas marked an inline comment as done.Sep 30 2018, 10:09 AM
arojas abandoned this revision.Sep 30 2018, 1:10 PM

Already fixed another way

pino added a comment.Sep 30 2018, 1:16 PM

I see 3a731ebfdcacd23c68d716a657bb6e9a806b7532, although IMHO this change is still an improvement. What about rebasing it over the 1.4 branch?

Revision Contents
Changeset List

PathPackages
MCMakeLists.txt (3 lines)
Mclazy.cmake (5 lines)

Diff 42590

View Options

CMakeLists.txt

Loading...
View Options

clazy.cmake

Loading...