Make QML compilation optional
ClosedPublic

Authored by arojas on Apr 27 2019, 9:53 AM.

Details

Summary

Precompiling QML code makes ktouch hard-depend on the Qt version it is compiled with, forcing it to be rebuilt with every new Qt version. This creates an additional burden for packagers in exchange for a negligible performance gain the first time the application is run (for every subsequent run the QML code is already compiled in the cache anyway)

Test Plan

Built with and old Qt version and -DCOMPILE_QML=OFF, it runs fine with current Qt.

Diff Detail

Repository
R336 KTouch
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
arojas created this revision.Apr 27 2019, 9:53 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptApr 27 2019, 9:53 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
arojas requested review of this revision.Apr 27 2019, 9:53 AM
gottfried accepted this revision.Apr 28 2019, 3:34 PM

Works as advertised.

This revision is now accepted and ready to land.Apr 28 2019, 3:34 PM
This revision was automatically updated to reflect the committed changes.