Now that 18.08 is released, it's finally time for the code review part of your patch. As mentioned before, I don't have any hardware to test this. Mouse-based usage still seems to be fine, with one exception though (see below).
Aug 27 2018
Aug 25 2018
Hi everyone. Sorry to say, but in light of recent events I lost all motivation to further contribute to Plasma. As for the Gwenview integration, Huon told me he's not very likely to contribute code anymore either. Not sure what this all means, but good luck anyway.
At the risk of being redundant myself, are we scrapping CTRL + T or keeping it?
I'd say the existing shortcut in the code is enough for now, with the long-term goal of adding a Configure Shortcuts dialog to Spectacle, where users could change and add shortcuts as they like.
I'll update this submission - or create a new one, whichever is preferred.
It's probably best to create a new revision and abandon this one, because the topic changed quite a bit (sorry again).
Sorry to say, but in light of recent events I lost all motivation to further contribute to Plasma. Someone else should take over.
Sorry to say, but in light of recent events elsewhere I lost all motivation to further contribute to Plasma (this has nothing to do with you or your patch). Please find another reviewer.
Aug 24 2018
Yup. Even for the most extreme situations a user can reach via resizing, Gwenview should behave nicely. As such eliding is more elegant than simply cutting off the label…
Should we get rid of mStatus and just use stackedWidget->currentWidget()?
Something like this: P254 (diff against this patch).
Abandoning after reassessing priorities.
talk to him in private about that and make suggestions on how to improve. I'm sure Nate wouldn't just ignore that.
Aug 23 2018
I had this same problem recently - land a commit from a different user but the authorsihp was changed. I reverted the commit. :(
@ngraham I have suggested this multiple times in response to similar apologies of yours before, and here I'm only doing it again because I still care at least a little bit and I still hope there will a chance for change: Please let go of your assumptions regarding hidden agendas or how often, where and why I comment on your work. Nobody is here to specifically pick on you, I'm sorry that you still seem to get that impression.
Oh well, the joys of diverging branches. Only the "close" vs "cancel" button types were accounted for, but not the (now) differing button boxes themselves. Patch in D15014. Glad you checked again!
Aug 22 2018
What about the lock ratio by holding Ctrl / ⇧? That's why I did not change the cursor in the handle areas. Ctrl+click over a handle does not zoom but resize with locked ratio.
Aug 21 2018
I think this diff was branched before your invalid-rect and double-click-accept patches. After rebase and adding checks in mouseDoubleClickEvent these issues should be gone.
I was not able to reproduce showing a wrong ratio in the checkbox, but CropRatioIndex=39816368 in gwenviewrc is certainly not correct ;)
@safaalfulaij Thanks for the links, those are quite interesting. So there are actually two different use cases for spinboxes:
- Changing a value only a couple of ticks (e.g. the number of copies when printing), where you need precise control and therefore are likely to click.
- Changing a value over a wider range (e.g. a width or height of an image), where scrolling is faster and does not need be precise. Those spinboxes are probably found in large professional apps with dense interfaces and less space for individual +/- buttons.
I'm pretty sure no one uses these buttons if they have an actual mouse, but just the wheel.
Aug 20 2018
Keyboard handling solved as requested and tests are running again, so now I can get back to what I was actually working on ;)
On my system an additional test appstreamtest is automatically created (no Gwenview source file). Isn't this created for you (because your log says Start 1: imagescalertest)?
Hi, thanks for your patch. Sorry for not noticing it earlier, we don't get a notification if you don't set Gwenview as either the reviewer or project tag.
@ngraham Could you comment on why (on your personal machine) you went for increasing the font size instead of changing the DPI value? (If this is a UI issue, telemetry might give skewed results, BTW.)
- Fix crash
- Use int
Btw. Backspace still goes to the previous image. But not sure if we should change this too. It's not used otherwise and could be assigned to any other action by the user.
Aug 19 2018
I tried your test plan, which works as advertised. Code LGTM too. Let's get rid of kdelibs4support…
Setting the message label to QSizePolicy::Fixed prevents from shrinking but it still adjusts to the current width hint.
Another idea I had (more suited for master, though): In addition to Enter and double-clicking I could also make Space accept a tool. Instead of doing nothing this could be handy for two-handed use (left hand on the keyboard, right hand on the mouse). Thoughts?
Aug 18 2018
(Please ignore the previous attempt ;)
Sorry for the wait, but I did not get to the focus/hover issue yet (and thus did not start with the actual review).
Ah, right. So doing the right thing here actually uncovers hidden problems elsewhere. Since you already solved them in
D14485, I'll depend on your Diff here.
The Advanced settings bar is really wide. Should we try to split this into two lines if there is not enough space, e.g. with a floating layout?
Wow, you fixed it already! This also solves the problem of not being able to make the window smaller after disabling Advanced settings again.
Aug 17 2018
Aug 16 2018
Disable shadow for marker tool
Sounds simple once you know the trick, but to get there was a bit long-winded…