Differential D14921

Fix compilation error when removing file in test
AbandonedPublic
Actions

Authored by luc4 on Aug 18 2018, 5:38 PM.

Details

Reviewers
None
Group Reviewers
Gwenview
Summary

When calling QDir::remove the compiler cannot create a QString from a char literal. Using a string literal allows automatic conversion.

Diff Detail

Repository
R260 Gwenview
Lint
Lint Skipped
Unit
Unit Tests Skipped
luc4 requested review of this revision.Aug 18 2018, 5:38 PM
luc4 created this revision.
rkflx added a reviewer: Gwenview.Aug 20 2018, 4:37 PM
rkflx added a subscriber: rkflx.

Hi, thanks for your patch. Sorry for not noticing it earlier, we don't get a notification if you don't set Gwenview as either the reviewer or project tag.

As for the compilation issue, we discussed it in 73e0b8219c2c and it was fixed with 05a28a1838db. This means you can safely "abandon" your Diff with the Add Action button below.

Since you were working on Gwenview, let us know if you have any questions or need ideas for what to work on. There are still plenty of bugs left ;)

ngraham added subscribers: bcooksley, ngraham.Aug 20 2018, 4:55 PM
In D14921#312102, @rkflx wrote:

Hi, thanks for your patch. Sorry for not noticing it earlier, we don't get a notification if you don't set Gwenview as either the reviewer or project tag.

Sounds like we need a Herald rule to automatically add a revelant mailing list or Phab group if no reviewers are specified. @bcooksley can probably take care of this.

bcooksley added a comment.Aug 20 2018, 5:44 PM

I've now done this with H54.

Restricted Application added a project: Gwenview. · View Herald TranscriptAug 20 2018, 5:44 PM
ngraham added a comment.Aug 20 2018, 6:18 PM

Thanks for the quick work!

luc4 abandoned this revision.Aug 20 2018, 9:04 PM

Revision Contents
Changeset List

PathPackages
Mtests/auto/contextmanagertest.cpp (4 lines)

Diff 39976

View Options

tests/auto/contextmanagertest.cpp

Loading...