In T7022#110786, @rkflx wrote:

In D7714#146347, aacid wrote:

i'm not sure i totally agree with all your points there either.

I'm putting work for this on hold (maybe I'll resume later, maybe not), as a different patch for Okular is committed now (with the review not accepted yet, different wording, grammar mistake) and it seems very unlikely any further improvements will ever be accepted in Okular (after recent experiences with some of my other patches).

Which patches?

Albert doesn't tell us what he still disagrees with and why, which makes it very hard to find something everybody can live with. If that changes, I'll reconsider, but just committing without agreement is not my style of working.

What? I commited exactly what you wanted and you say "Albert disagree"?

In D7714#146596, aacid wrote:

I'm going to commit this since it seems Henrik has a plan for the bigger thing.

I expected support, but all I get is ridiculing.

Just for the record: it wasn't me who suggested to do all of this work, I merely hinted at just copying what Dolphin already has.

Well, you have my support, i exactly commited the code because you had opened this task for "further work", i don't see how you can suggest that i am ridiculing you.

In T7022#110866, @rkflx wrote:

Thanks, I'm grateful for any support. Nevertheless, let's compare where suggestion and commit differ:

Message: "You are about to close a window with <n> tabs. Are you sure you want to continue?"

i18n("You have about to close %1 tabs. Are you sure you want to continue?", m_tabs.count())

Ah yes, i made a typo, thanks for noticing.

Checkbox: "Warn me when I attempt to close a window with multiple tabs"

i18n("Warn me when I attempt to close multiple tabs")

Buttons: "Close Window" and "Cancel"

KGuiItem(i18n("Close Tabs")

That's not "exactly" the same like you try to picture it (I acknowledge it's better than the original patch from reviewboard). I justified my suggestion above, you did not reply to that but just committed something different anyway.

Ah sorry, yes, not exactly like you suggested, exactly like the usability expert suggested. He said "Let's use the same than Firefox, they've researched that enough so no need to research more than them" (paraphrasing) so i went with what Firefox uses.

I'm willing to find a good solution via discussion (maybe it turns out "Close Tabs" is better, but there were no arguments in favour so far),

Close Tabs is simply much better because the question is about tabs. If we were to change the question about window, then yes the button should change to window.

not by forcing my opinion on people via commits. That's where I feel getting ridiculed and lose motivation. Putting something on Phabricator means working with your reviewers, not sneaking in changes behind their back.

You don't understand, you opened a task named "improve confirmation dialog" so that was clear you accepted there would be a confirmation dialog to improve, so i commited my non perfect confirmation dialog so it can be improved.

---

I'll leave this alone from my side for the next 1 – 2 weeks. In the meantime (this applies to everyone reading this), feel free to

• get someone else to comment on "Close Tabs" vs. "Close Window" (preferably addressing my reasoning from above)
• decide on implementation (1) or (2)

Not sure what you mean by (1) or (2), do you mean tabs vs window?

• state whether the offer to help adding a custom "Do not ask again" message in KMessageBox itself still stands

This needs thinkign as to what new API is needed since once you add API to KMessageBox it'll have to stay "forever", so one better gets it right :)

• clarify whether Okular is willing to accept further changes beyond what is already committed,

You're more than welcome to work on any improvements you may find necessary.

in case those are required to make Dolphin and Konsole happy (i.e. is Okular willing to compromise for the sake of unification within KDE)

There's no really a need for unification in applications developed inside the KDE project, it may happen that different use cases actually need different wordings.

was clear you accepted

For the future: Just ask "I <made a change> for <some reason>. Could you mark this Diff as accepted, we could improve it later.". I'd gladly do that as that'd be clear communication as well as documented in Phab.

Nevertheless, you said "Sorry" and I'm fine now.

Not sure what you mean by (1) or (2)

See above for the two options in the section titled "Decide on implementation". Might also depend on timing. Could you tell me where I can look to find out which KF5 version KDE Apps 17.12 can depend on? Whatever the release schedule says?

This needs thinkign as to what new API is needed since once you add API to KMessageBox it'll have to stay "forever", so one better gets it right :)

I'll glady tap into your experience here, that's why I asked. No need to rush…

You're more than welcome to work on any improvements you may find necessary.

I'll quote you on that :)

"Close Tabs" vs. "Close Window"

In Firefox, you always have at least one tab, but in Okular you can have an empty shell with no tab and no document. That's where there is a difference between "Close all tabs" and "Close all tabs as well as the window". I'm not sure colomar had that in mind yet and as you say, not all apps are equal. Firefox also uses the dialog for "Close other tabs" and a completely different dialog for the "Quit" menu entry, so blindly following that 100% might not be the best idea.

Currently it's very confusing for the user in Okular: You choose "Quit" from the menu, the button asks "Close Tabs", what you actually see is "Tabs and only one Window get closed". Don't you think that should be unified? "Close Window" in the menu, in the dialog description, on the button and as the final action would be an ideal solution here, as it works even for the one-tab case. (Also note how Konsole is already using "Close Window" in the menu and on the button, probably for that exact reason.)

It would be nice if you could at least try to consider the possibility of implementing it like this. I'm willing to handle all additional work this entails, all I ask you is to give the idea a fair chance instead of dismissing it within seconds. Please take your time and maybe also let others comment (as I said, I'll have to leave this alone for a while anyway).

It needs patience, but I believe we'll get there.

Could you tell me where I can look to find out which KF5 version KDE Apps 17.12 can depend on? Whatever the release schedule says?

Whatever one they want that was released before the dependency freeze.

Currently it's very confusing for the user in Okular: You choose "Quit" from the menu, the button asks "Close Tabs"

Exactly the same as in firefox. If they have decided hundred millions of users are ok with that wording, i'm ok with that wording too.

Exactly the same as in firefox.

Except that's not what's happening "exactly" in Firefox, as I said above already. Try Ctrl+Q or File → Quit. It will not display the dialog in question (it will quit without confirmation and you get the offer to restore the session on the next start). If you set browser.showQuitWarning = true, this is shown:

Do you notice how the menu action corresponds directly to the wording of the button, like I'm proposing?

I'm not suggesting we implement two different dialogs or a session-saving function (even if wanted by millions of Firefox users). If we simply used "Close Window" in menu and button, it would be consistent everywhere. Do you see any actual problem we create by using "Close Window"? I don't, I see a problem we solve, namely the inconsistency.

Let's use common sense, not the number of users (otherwise we would follow Chrome and have no confirmation dialog at all).

In T7022#111114, @rkflx wrote:

Exactly the same as in firefox.

Except that's not what's happening "exactly" in Firefox, as I said above already. Try Ctrl+Q or File → Quit. It will not display the dialog in question (it will quit without confirmation and you get the offer to restore the session on the next start).

Very confusing, i did not expect Firefox to behave differently when choosing File->Quit than when doing Alt+F4 or pressing the window [x]

Do you plan on continuing work on this @rkflx? KDE Apps seem to often miss a strict policy on unified design in small details. So a push for a same looking "Do you want to close all tabs" dialogs everywhere would be a welcomed start to change that.

How I would like to see the dialog pattern:

• Window title: "Confirm Close — <app name>" — no change
• Icon: warning — It is a warning. Albert's checkbox text in the first Okular version and yours one even say it's one.
• Message: "You are about to close <n> tabs. Are you sure you want to continue?" — The warning is about the tabs, not the window. That the user wants the window to be closed is known from his manual interaction, that led to the showing of this warning.
• Checkbox: "Warn me when I attempt to close multiple tabs at once" (should be aligned horizontally below text like in Firefox) — Same reasoning as above. Also there might be situations where multiple tabs are closed without closing the window. It is very likely that in this situation we want to show the same warning.
• Buttons: "Close tabs" and "Cancel" — Same reasoning as above. And yes the button to only close the current tab has to go away.

For implementation go with (1). Avoid a Frameworks change! But there is also the KMessageBox::messageBox method. Could this be used? How is this different from the two you proposed?