Fix Enter key not working for new Close button in Red Eye Reduce tool

Authored by rkflx on Aug 23 2018, 6:11 AM.



When df8cb1abf5ba was merged from stable to master, duplicating the
QDialogButtonBox in the Reduce Red Eye toolbar as done in
0c678376131d was not taken into account, so pressing Enter when
the Close button had focus for the initial helpDialogButtonBox
had no effect anymore.

This can be fixed by always operating on the buttons that are visible.

Test Plan

Open the Reduce Red Eye tool and press Enter on the
Close, Reduce Red Eye and Cancel buttons as well as when
none of those buttons is focused.

Diff Detail

R260 Gwenview
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.
rkflx created this revision.Aug 23 2018, 6:11 AM
Restricted Application added a project: Gwenview. · View Herald TranscriptAug 23 2018, 6:11 AM
rkflx requested review of this revision.Aug 23 2018, 6:11 AM
muhlenpfordt accepted this revision.Aug 23 2018, 8:38 AM

Close button is fixed. Looks good.

Should we get rid of mStatus and just use stackedWidget->currentWidget()?
Something like this: P254 (diff against this patch).

This revision is now accepted and ready to land.Aug 23 2018, 8:38 AM
This revision was automatically updated to reflect the committed changes.