Restore settings label and prevent warning when Baloo is unavailable
ClosedPublic

Authored by rkflx on Aug 21 2018, 7:13 PM.

Details

Summary

As discussed in D14814, 6674c9c387d0 removed the Show tooltips
checkbox in Dolphin's preferences when Baloo is unavailabe at compile
time and thus the tooltip would not be functional. The Miscellaneous
label in front of the checkbox was also removed, even though it relates
to all options in that group.

In addition, after 6674c9c387d0 running Dolphin without Baloo support
would print

QWidget::insertAction: Attempt to insert null action

on startup.

Both issues can be fixed with more #ifdefs.

Test Plan

After building with -DCMAKE_DISABLE_FIND_PACKAGE_KF5Baloo=ON, the
Show tooltips checkbox is removed, the Miscellaneous label
is still there, and there is no warning printed.

Diff Detail

Repository
R318 Dolphin
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
rkflx created this revision.Aug 21 2018, 7:13 PM
Restricted Application added a project: Dolphin. · View Herald TranscriptAug 21 2018, 7:13 PM
Restricted Application added a subscriber: kfm-devel. · View Herald Transcript
rkflx requested review of this revision.Aug 21 2018, 7:13 PM
elvisangelaccio accepted this revision.Aug 21 2018, 9:47 PM

Ops. Thanks for the fix!

This revision is now accepted and ready to land.Aug 21 2018, 9:47 PM
This revision was automatically updated to reflect the committed changes.