Improve messange : ENOSPC for inotify_add_watch only when inotify_add_watch was reached

In D25117#565877, @dfaure wrote:

Nice, I didn't realize the slave had 5 seconds to cleanup after being killed, I thought it died immediately
(genericsig_handler in slavebase.cpp).

I didn't realize there was a timeout somewhere.

Hmm, the Windows code is probably a no-op then, there's no signal handler there to call setKillFlags(), so no opportunity to cleanup before dying.
Some research indicates that we'd have to use SetConsoleCtrlHandler on Windows for similar behaviour.
https://stackoverflow.com/questions/2007516/is-there-a-posix-sigterm-alternative-on-windows-a-gentle-kill-for-console-ap
https://danielkaes.wordpress.com/2009/06/04/how-to-catch-kill-events-with-python/

I did not realize that.

Please run arc amend to fix the typo in the commit message before landing.

Did you push it ? Because I Haven't yet.

In T11535#209208, @dfaure wrote:

I'll attend remotely, via IRC/matrix/chat_of_the_day.

In D25398#565210, @ngraham wrote:

Agreed. Works for me and looks safe, but maybe let's do master only for safety.

Can you file a bug upstream on the odd behavior in AccountsService?

In D25432#565595, @trufanov wrote:

Hmm, I've just git grep the repo and found another place that is most probably affected by the same problem in FTP slave;
https://github.com/KDE/kio/blob/d03551cd0367ac7760224c56bda943c937ba5dac/src/ioslaves/ftp/ftp.cpp#L320

Could you check out if it's a QVariant with QByteArray type and fix it on your own?

Also now I think the code would be more self-descriptionly if I would use QByteArray() instead of QString() as a default value for mapConfig().value() in my fix.
So if the second place is a bug and you think the same about default values feel free to improve my commit in HTTP with your fix too.

GLRenderTarget::virtualScreenScale() is currently only set to screen->scale during the paint method.

In D25435#565600, @ngraham wrote:

Ah, I see why: because the bug report is about remote:/, not network:/. I guess network needs this patch too, but it's not fully complete unless remote:/` gets the same fix.

Rebase on master

Keep FileCopyJob::doKill

Rename variable to proper name

In D25435#565544, @broulik wrote:

I think this needs a add_definitions(-DTRANSLATION_DOMAIN and Messages.sh file?

Clean

fix

Add translation and Messages.sh to network:/

Update commit message

ping @ngraham anything to add ?

Formatting

Thank you for digging it !

In D25010#565421, @dfaure wrote:

Hmm, I meant Name is always useful when *listing*. But when *stating*, we don't always need to get the name back. The NoDetails comment is about a stat that really can just succeed/fail.

I added

enum StatDetail {
    /// No field returned, useful to check if a file exists
    NoDetails = 0x0,

Funny thing is that statx includes always the name, down to syscall we can save at most STATX_SIZE , STATX_TYPE fields in NoDetails case.
I updated kdiroperator.cpp to use it line 748 since it only checks if a file exists.
This code path is not run for local files anyway.

Add NoDetails to StatDetail, add StatJob::setDetails\(KIO::StatDetail detail\), small comment update

In D25427#565342, @davidre wrote:

This approach will probably fail when the geometry stretches across multiple outputs with different scales.

Move shortcut to Back action instead of cdUp

In D25402#565326, @ngraham wrote:

Generally this key is used for "Back," not "Up." If we do this, it will be inconsistent with Dolphin. Maybe we should just match Dolphin's behavior.

Typos, rephrase a comment, move FileProtocol::getStatDetails to file.cpp, add a TODO for in file_win.cpp

In D25398#564887, @ngraham wrote:

In D25398#564843, @meven wrote:

I had a look at the others :

• https://bugs.kde.org/show_bug.cgi?id=392943
• https://bugs.kde.org/show_bug.cgi?id=389878
• https://bugs.kde.org/show_bug.cgi?id=393702

Something I noticed when having an avatar and setting any other parameter.
Apparently AccountService removes the icon as it considered it transient cache data :
https://github.com/magcius/accountsservice/blob/eb166ec7592704a897594f7ca4c47b70d871a85c/src/daemon.c#L1105

So it's an upstream issue? Is that really where upstream AccountsService lives? Some random guy's GitHub?

This was a clone of an old version.

In D25398#564706, @ngraham wrote:

Nice. Does this fix any of these?

• https://bugs.kde.org/show_bug.cgi?id=384894

This diff fix this one

Code style

In D25398#564639, @apol wrote:

The commit message looks wrong, maybe you meant PolicyKit? PackageKit should be irrelevant.

In D25328#563637, @cullmann wrote:

Hmm, the use case is that it re-highlights if you set an invalid definition?

Improve reliability

Fix

Display leftovers warnings if any

I have an idea to perhaps replace the recursiveDirectorySizeLimit : using a timeout
That is, for instance, give 10ms per subdirectory 100 ms for the whole directory, to retrieve the directory size, if timeout is reached return the not-complete results : it will adapt to the IO system load and to drive speed.
This timeout might be configurable.

Was introduced in https://phabricator.kde.org/D19926 but the feature changed quite a lot in the meantime.

In D25328#563406, @dhaumann wrote:

Can't you call rehighlight() yourself after calling setDefinition()?

Btw, tanks for looking into this!

In D25335#563263, @ngraham wrote:

This is a feature I've wanted for ages, so I'm very excited to see a patch that implements it!

In terms of the UI, this shouldn't only be for Details view; it's possible to view sizes in icon view too, by adding the size metadata item below the filename.

In D25323#562908, @kossebau wrote:

Thanks for looking at the issue. No time to look closer the next days, but curious about this partial change (which has been discussed before and discarded):
changing QColor ( 245, 245, 245 ); // light-grey background to highlightingTheme.editorColor(KSyntaxHighlighting::Theme::EditorColorRole::BackgroundColor) implies, one cannot use KSyntaxHighlighting to render text highlighted e.g. for a print-out on a paper (or only for a PDF). Compare e.g. the example https://phabricator.kde.org/source/syntax-highlighting/browse/master/examples/codepdfprinter/.

I have opened https://phabricator.kde.org/D25323 to fix the missing highlighting in kio-extras.

I believe the issue currently is that for text files or files without associated definition we end up with an invalid definition that prevents SyntaxHighlighter::setDefinition to call rehighlight().
QTextDocument uses then whatever it get from the theme I guess.
Kate has an explicit special case in KateHighlighting::KateHighlighting to insert a default Format.

In D22801#561989, @rjvbb wrote:

Are you not seeing these for instance when browsing an MSWin share in Dolphin (with the same or newer versions of kio-extras, Samba and MSWin)?ç

friendly ping

Anyone to review this ? 30 lines change + test

Seems sane to me and nice since it removes some code.

The issue could be as well located in previewjob.cpp.
Could you debug why KMountPoint::List::findByPath is called with an empty string or non-existing file.
We might want to prevent this to happen instead.

This is a nice patch with just a few rough edges to polish.
I encourage @msciubidlo to have a look again.

ping @rjvbb
Do you want someone else to commit this patch or do you want to do it yourself https://community.kde.org/Infrastructure/Phabricator ?