trufanov (Alexander Trufanov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 8 2017, 4:36 PM (178 w, 4 d)
Availability
Available

Recent Activity

Jun 25 2020

trufanov closed D29865: Balance Stats saving timers.

Merge request sent: https://invent.kde.org/network/ktorrent/-/merge_requests/3

Jun 25 2020, 12:31 PM
trufanov closed D29852: Possible bug in MultiFileCache.

Could you please clarify a process? Shall I pass the review on phabricator then create a pull request on Invent? Or just create a Pull Request on Invent?

Jun 25 2020, 11:13 AM
trufanov closed D29859: Improve Key operations performance.

Commited: https://invent.kde.org/network/libktorrent/-/commit/7dab629a2f79ecea4bee734e87b3ac747eedc3e5

Jun 25 2020, 11:10 AM
trufanov closed D29860: Improve BitSet operations performance.

Commited with https://invent.kde.org/network/libktorrent/-/commit/f12628ccfc153129548185c92fd7b02574b38e44

Jun 25 2020, 11:09 AM
trufanov closed D29864: Allow balancing of Stats saving timers.

Hmm... I forget to fix indentation.
It's quite annoying that KTorrent and Libktorrent projects both have different styles of indentation: tabs and spaces.

Jun 25 2020, 11:08 AM
trufanov closed D29854: Allow creation of torrent files with 16 Mb piece size.

Pushed to master:
https://invent.kde.org/network/ktorrent/-/commit/d4ec62aeb4a941a18322856a2e6d8ca73846306b

Jun 25 2020, 10:50 AM

Jun 24 2020

trufanov requested review of D29865: Balance Stats saving timers.
Jun 24 2020, 2:19 PM
trufanov requested review of D29864: Allow balancing of Stats saving timers.
Jun 24 2020, 2:16 PM

Jun 20 2020

trufanov requested review of D29860: Improve BitSet operations performance.
Jun 20 2020, 12:38 PM
trufanov requested review of D29859: Improve Key operations performance.
Jun 20 2020, 11:19 AM

Jun 16 2020

trufanov requested review of D29854: Allow creation of torrent files with 16 Mb piece size.
Jun 16 2020, 12:15 PM

Jun 14 2020

trufanov requested review of D29852: Possible bug in MultiFileCache.
Jun 14 2020, 12:53 PM

Jun 3 2020

trufanov committed R472:a7afe9f1e9a9: DHT: Reply a non 20-bytes long tokens (authored by trufanov).
DHT: Reply a non 20-bytes long tokens
Jun 3 2020, 1:36 PM
trufanov closed D29842: DHT: Reply a non 20-bytes long tokens .
Jun 3 2020, 1:36 PM
trufanov requested review of D29842: DHT: Reply a non 20-bytes long tokens .
Jun 3 2020, 8:34 AM

May 16 2020

trufanov added a comment to D29801: Add single page PDF support.

I've asked Bart Clephas to forward his PR in SkanLite's github project to the phabricator, so added myself as secondary reviewer to follow it.
But Kåre Särs is a decision maker here.

May 16 2020, 7:39 PM
trufanov edited reviewers for D29801: Add single page PDF support, added: sars, trufanov; removed: VDG.
May 16 2020, 7:34 PM

Dec 5 2019

trufanov committed R473:8e0145d6eced: Don't display standard groups in Open torrent dialog (authored by trufanov).
Don't display standard groups in Open torrent dialog
Dec 5 2019, 11:13 AM
trufanov closed D25718: Don't display standard groups in Open torrent dialog .
Dec 5 2019, 11:13 AM

Dec 3 2019

trufanov requested review of D25718: Don't display standard groups in Open torrent dialog .
Dec 3 2019, 5:53 PM

Dec 2 2019

trufanov resigned from D25680: Fixes crash, when removing last torrent.BUG: 388803.

Once I faced with this bug on Kubuntu 19.10 but couldn't reproduce. And I still can't reproduce it. Anyway change looks fine for me. Let's rely on stikonas opinion

Dec 2 2019, 5:25 PM

Nov 25 2019

trufanov accepted D25314: Port KTorrent to QWebEngine.
Nov 25 2019, 10:25 AM

Nov 21 2019

trufanov committed R473:fa18fc6a15a3: Context menu for trackers list (authored by trufanov).
Context menu for trackers list
Nov 21 2019, 11:27 PM
trufanov closed D25453: Context menu for trackers list.
Nov 21 2019, 11:27 PM
trufanov requested review of D25453: Context menu for trackers list.
Nov 21 2019, 11:03 PM
trufanov added a comment to D9645: Bug fix 369542.

Is this still actual or should be closed as completed?

Nov 21 2019, 6:10 PM · KDE Applications
trufanov added a comment to D21145: Make KTorrent work with current GeoIP files.

any news on this?

Nov 21 2019, 2:50 PM
trufanov accepted D25438: Ftp ioslave: Fix ProxyUrls parameter passing.
Nov 21 2019, 2:38 PM · Frameworks
trufanov added a comment to D25432: Fix HTTP proxy settings.

Hmm, I've just git grep the repo and found another place that is most probably affected by the same problem in FTP slave;
https://github.com/KDE/kio/blob/d03551cd0367ac7760224c56bda943c937ba5dac/src/ioslaves/ftp/ftp.cpp#L320

Nov 21 2019, 1:39 PM · Frameworks
trufanov committed R241:c0ae03d14b0e: Fix HTTP proxy settings (authored by trufanov).
Fix HTTP proxy settings
Nov 21 2019, 11:39 AM
trufanov closed D25432: Fix HTTP proxy settings.
Nov 21 2019, 11:39 AM · Frameworks

Nov 20 2019

trufanov requested review of D25432: Fix HTTP proxy settings.
Nov 20 2019, 10:41 PM · Frameworks

Nov 15 2019

trufanov committed R472:f8358c81d1b2: Fix KIO errors text formatting (authored by trufanov).
Fix KIO errors text formatting
Nov 15 2019, 3:31 PM
trufanov closed D25329: Fix KIO errors text formatting.
Nov 15 2019, 3:31 PM
trufanov requested review of D25329: Fix KIO errors text formatting.
Nov 15 2019, 3:12 PM

Nov 12 2019

trufanov committed R473:899b5253b162: Highlight seeding torrents in case of any problems with trackers (authored by trufanov).
Highlight seeding torrents in case of any problems with trackers
Nov 12 2019, 9:17 AM
trufanov closed D25137: Highlight seeding torrents in case of any problems with trackers.
Nov 12 2019, 9:17 AM
trufanov committed R472:abed98811d0e: Report TrackersList statuses statistics for torrent highlighting (authored by trufanov).
Report TrackersList statuses statistics for torrent highlighting
Nov 12 2019, 9:09 AM
trufanov closed D25136: Report TrackersList statuses statistics for torrent highlighting.
Nov 12 2019, 9:09 AM

Nov 10 2019

trufanov committed R472:a1f537838eb0: Display HTTP error code instead of "Invalid data from tracker" (authored by trufanov).
Display HTTP error code instead of "Invalid data from tracker"
Nov 10 2019, 4:19 PM
trufanov closed D25235: Display HTTP error codes instead of "Invalid data from tracker" in tracker status.
Nov 10 2019, 4:19 PM
trufanov requested review of D25235: Display HTTP error codes instead of "Invalid data from tracker" in tracker status.
Nov 10 2019, 3:45 PM

Nov 4 2019

trufanov requested review of D25137: Highlight seeding torrents in case of any problems with trackers.
Nov 4 2019, 3:25 AM
trufanov requested review of D25136: Report TrackersList statuses statistics for torrent highlighting.
Nov 4 2019, 3:15 AM

Nov 3 2019

trufanov committed R473:4347981f3c2d: Bugfix crash on port change (authored by trufanov).
Bugfix crash on port change
Nov 3 2019, 11:12 AM
trufanov closed D13045: Bugfix crash on port change.

I thought this review should be autoclosed but it seems i misspelled something in commit's description.
Anyway, the changes are pushed: https://github.com/KDE/ktorrent/commit/4347981f3c2d1f1aa71c338d54807e627dea3950

Nov 3 2019, 9:51 AM

Nov 2 2019

trufanov added a comment to D13045: Bugfix crash on port change.

I've just tried this with version 5.1.2. The app has crashed. So problem is still exists. Perhaps would be better to apply this patch?

Nov 2 2019, 11:18 PM

Jun 1 2019

trufanov added a comment to D21145: Make KTorrent work with current GeoIP files.
Jun 1 2019, 3:53 PM

May 9 2019

trufanov added a comment to D20696: Add DHT bootstrapping from well-known nodes.

If I commit this myself, I need your mail address for git commit --author. Is it the same as in reviewboard (I can't see the one from Phabricator)?

May 9 2019, 11:58 AM

Apr 20 2019

trufanov accepted D20696: Add DHT bootstrapping from well-known nodes.
Apr 20 2019, 12:36 PM

Feb 28 2019

trufanov updated the diff for D18001: Display resulting image while scanning in a tab of libksane's KSaneWidget.

I've checked that diff works after recent updates to the codebase and replaced QTabWidget with QTabBar.
Now ready for review whenever you have a free time for this.

Feb 28 2019, 6:31 PM
trufanov updated the diff for D18002: Add "Display resulting image while scanning" option.

I've changed setting's text to "Display resulting image while scanning"

Feb 28 2019, 6:29 PM

Feb 25 2019

trufanov committed R483:20e8f9403712: Postpone device settings change if scanning is in progress (authored by trufanov).
Postpone device settings change if scanning is in progress
Feb 25 2019, 8:40 PM
trufanov closed D18966: Postpone device settings change if scanning is in progress.
Feb 25 2019, 8:40 PM
trufanov committed R382:863d4e997dd9: Don't apply options change if scanning is in progress (authored by trufanov).
Don't apply options change if scanning is in progress
Feb 25 2019, 8:36 PM
trufanov closed D17510: Postponed settings change if scanning is in progress.
Feb 25 2019, 8:36 PM

Feb 22 2019

trufanov updated the diff for D18966: Postpone device settings change if scanning is in progress.

Now without QScopedPointer

Feb 22 2019, 11:39 PM

Feb 18 2019

trufanov added a comment to D18966: Postpone device settings change if scanning is in progress.

Kåre, could you comment my reply?: https://phabricator.kde.org/D18966#411134

Feb 18 2019, 10:04 PM

Feb 12 2019

trufanov added inline comments to D18966: Postpone device settings change if scanning is in progress.
Feb 12 2019, 9:14 PM
trufanov requested review of D18966: Postpone device settings change if scanning is in progress.
Feb 12 2019, 5:49 PM
trufanov updated the diff for D17510: Postponed settings change if scanning is in progress.

oops, made a copy-paste mistake. Updated again

Feb 12 2019, 2:22 PM
trufanov updated the diff for D17510: Postponed settings change if scanning is in progress.

updated

Feb 12 2019, 2:19 PM

Feb 11 2019

trufanov updated the diff for D17510: Postponed settings change if scanning is in progress.

Ok, in this case this we need to patch 2 projects and this review will contain only a minimal changes.

Feb 11 2019, 10:19 PM
trufanov committed R483:f1e5c7e1a0c4: Saving image is moved to thread + auto creating missing output folders (authored by trufanov).
Saving image is moved to thread + auto creating missing output folders
Feb 11 2019, 7:37 PM
trufanov closed D17955: Skanlite may create missing output directories automtically (with user's permission).
Feb 11 2019, 7:37 PM
trufanov closed D18446: Add static version of toQImageSilent().
Feb 11 2019, 7:24 PM
trufanov committed R382:130c4503068e: Static version of toQImageSilent() (authored by trufanov).
Static version of toQImageSilent()
Feb 11 2019, 7:24 PM
trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

Ok, now with renamed var.

Feb 11 2019, 1:29 PM
trufanov updated the diff for D18446: Add static version of toQImageSilent().

I've just realized that I forgot to add implementation of a new static func for TWAIN libksane version (ktwain_widget.cpp) AGAIN.
TWAIN ver is build for Windows only and mostly consists of stubs. Last time I forget about it it caused a lib compilation failure during CI autotests and I was traced by admin to fix this.
Luckily the patch wasn't commited yet.

Feb 11 2019, 1:19 PM
trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

updated

Feb 11 2019, 3:17 AM

Feb 9 2019

trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

Now with saveQImage() splitted into saveQImage() and save16BitPng().
And more correct processing of 16bit m_img saving if it's non empty and was already converted inside Skanlite::imageReady bcs of showB4Save->isChecked()

Feb 9 2019, 4:41 PM
trufanov added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

Sorry, I missed your reply and realized that only now.
I've already forget the code and probably bcs of that didn't get your comment.

Feb 9 2019, 4:35 PM

Jan 29 2019

trufanov added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

Ping!

Jan 29 2019, 8:25 AM

Jan 22 2019

trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

One more update, all notes should be addressed in this except for passing fileUrl

Jan 22 2019, 9:53 AM
trufanov added inline comments to D17955: Skanlite may create missing output directories automtically (with user's permission).
Jan 22 2019, 9:47 AM
trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

Update to a QThread-based approach of image saving. Now it uses static KSaneWidget::toQImageSilent(). Thus this requires https://phabricator.kde.org/D18446 to be applied.
As it's static it can't emit signals and thus KSaneImageSaver is now getting pointer to KSaneWidget to emit it's signal in case of problems.
Also KSaneImageSaver is now a member of Skanlite class and it's lambda is replaced with new Skanlite's slot.

Jan 22 2019, 5:57 AM
trufanov requested review of D18446: Add static version of toQImageSilent().
Jan 22 2019, 5:46 AM
trufanov added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).
In D17955#393880, @sars wrote:
Jan 22 2019, 5:41 AM

Jan 15 2019

trufanov added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

@sars could you take a look on thread based version (latest diff)?

Jan 15 2019, 7:46 AM

Jan 11 2019

trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

How about this async approach? I'm still testing. So far it's ok.

Jan 11 2019, 11:03 AM

Jan 8 2019

trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

replaced path() with toLocalFIle()

Jan 8 2019, 3:54 PM
trufanov added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).
In D17955#388887, @sars wrote:

But this all is to just re-paint one time before we freeze for the time it takes to save of the file? Would it be better in the long run to think about moving the saving to a thread?

Jan 8 2019, 3:13 PM

Jan 7 2019

trufanov added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

It seems there are 2 kind of widgets in KSaneWidget that don't repaint if you call KSaneWidget::repaint()
One is QGraphicsView-derived KSaneViewer, bcs it needs viewport()->repaint() instead.
Another are two QScrollAreas in 2 tabs for basic and other options. They need widget()->repaint() instead.

Jan 7 2019, 4:53 PM
trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

replace qApp->processEvents() with

Jan 7 2019, 1:27 PM
trufanov added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).
In D17955#387893, @sars wrote:

Besides the processEvents() I'm OK with this! :)

Jan 7 2019, 1:11 PM

Jan 6 2019

trufanov updated the diff for D18001: Display resulting image while scanning in a tab of libksane's KSaneWidget.

Typos are fixed. Thanks!

Jan 6 2019, 4:29 PM
trufanov requested review of D18002: Add "Display resulting image while scanning" option.
Jan 6 2019, 12:18 AM

Jan 5 2019

trufanov requested review of D18001: Display resulting image while scanning in a tab of libksane's KSaneWidget.
Jan 5 2019, 11:56 PM

Jan 4 2019

trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

How about that:
Ok for QDir(), but still for local files only
As for SaveLocation - let's just pop up m_saveLocation dialog till user enter a valid directory that we can create.

Jan 4 2019, 5:36 PM
trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

Display dirUrl.path() instead of dir in message as dir will have "file://" schema. It just looks better without it

Jan 4 2019, 12:13 AM
trufanov requested review of D17955: Skanlite may create missing output directories automtically (with user's permission).
Jan 4 2019, 12:10 AM

Dec 11 2018

trufanov requested review of D17510: Postponed settings change if scanning is in progress.
Dec 11 2018, 6:22 PM

Dec 8 2018

trufanov added a comment to D17186: Fix Windows CI build issues caused by startPreviewScan slot.

Done, let me know if CI fails again.

Dec 8 2018, 2:14 AM
trufanov committed R382:1ac580bc6f78: Fix Windows CI build issues caused by startPreviewScan slot (authored by trufanov).
Fix Windows CI build issues caused by startPreviewScan slot
Dec 8 2018, 2:14 AM
trufanov closed D17186: Fix Windows CI build issues caused by startPreviewScan slot.
Dec 8 2018, 2:14 AM

Dec 2 2018

trufanov added a comment to D17186: Fix Windows CI build issues caused by startPreviewScan slot.

Hi, Kåre
I won't be able to test this. It's hard to setup build chain in virtual machine and it depends on some other kf5 libs.
How about just commiting it? As Win compilation is already broken it won't make worse

Dec 2 2018, 8:45 PM

Nov 27 2018

trufanov updated the summary of D17186: Fix Windows CI build issues caused by startPreviewScan slot.
Nov 27 2018, 2:21 PM
trufanov requested review of D17186: Fix Windows CI build issues caused by startPreviewScan slot.
Nov 27 2018, 2:18 PM

Nov 11 2018

trufanov committed R483:d4483c1bc95c: D-Bus global hotkey for scanner preview (authored by trufanov).
D-Bus global hotkey for scanner preview
Nov 11 2018, 4:46 PM
trufanov closed D16813: D-Bus global hotkey for scanner preview.
Nov 11 2018, 4:46 PM