- User Since
- Mar 8 2017, 4:36 PM (178 w, 4 d)
Jun 25 2020
Merge request sent: https://invent.kde.org/network/ktorrent/-/merge_requests/3
Could you please clarify a process? Shall I pass the review on phabricator then create a pull request on Invent? Or just create a Pull Request on Invent?
Hmm... I forget to fix indentation.
It's quite annoying that KTorrent and Libktorrent projects both have different styles of indentation: tabs and spaces.
Jun 24 2020
Jun 20 2020
Jun 16 2020
Jun 14 2020
Jun 3 2020
May 16 2020
I've asked Bart Clephas to forward his PR in SkanLite's github project to the phabricator, so added myself as secondary reviewer to follow it.
But Kåre Särs is a decision maker here.
Dec 5 2019
Dec 3 2019
Dec 2 2019
Once I faced with this bug on Kubuntu 19.10 but couldn't reproduce. And I still can't reproduce it. Anyway change looks fine for me. Let's rely on stikonas opinion
Nov 25 2019
Nov 21 2019
Is this still actual or should be closed as completed?
any news on this?
Hmm, I've just git grep the repo and found another place that is most probably affected by the same problem in FTP slave;
Nov 20 2019
Nov 15 2019
Nov 12 2019
Nov 10 2019
Nov 4 2019
Nov 3 2019
I thought this review should be autoclosed but it seems i misspelled something in commit's description.
Anyway, the changes are pushed: https://github.com/KDE/ktorrent/commit/4347981f3c2d1f1aa71c338d54807e627dea3950
Nov 2 2019
I've just tried this with version 5.1.2. The app has crashed. So problem is still exists. Perhaps would be better to apply this patch?
Jun 1 2019
May 9 2019
Apr 20 2019
Feb 28 2019
I've checked that diff works after recent updates to the codebase and replaced QTabWidget with QTabBar.
Now ready for review whenever you have a free time for this.
I've changed setting's text to "Display resulting image while scanning"
Feb 25 2019
Feb 22 2019
Now without QScopedPointer
Feb 18 2019
Kåre, could you comment my reply?: https://phabricator.kde.org/D18966#411134
Feb 12 2019
oops, made a copy-paste mistake. Updated again
Feb 11 2019
Ok, in this case this we need to patch 2 projects and this review will contain only a minimal changes.
Ok, now with renamed var.
I've just realized that I forgot to add implementation of a new static func for TWAIN libksane version (ktwain_widget.cpp) AGAIN.
TWAIN ver is build for Windows only and mostly consists of stubs. Last time I forget about it it caused a lib compilation failure during CI autotests and I was traced by admin to fix this.
Luckily the patch wasn't commited yet.
Feb 9 2019
Now with saveQImage() splitted into saveQImage() and save16BitPng().
And more correct processing of 16bit m_img saving if it's non empty and was already converted inside Skanlite::imageReady bcs of showB4Save->isChecked()
Sorry, I missed your reply and realized that only now.
I've already forget the code and probably bcs of that didn't get your comment.
Jan 29 2019
Jan 22 2019
One more update, all notes should be addressed in this except for passing fileUrl
Update to a QThread-based approach of image saving. Now it uses static KSaneWidget::toQImageSilent(). Thus this requires https://phabricator.kde.org/D18446 to be applied.
As it's static it can't emit signals and thus KSaneImageSaver is now getting pointer to KSaneWidget to emit it's signal in case of problems.
Also KSaneImageSaver is now a member of Skanlite class and it's lambda is replaced with new Skanlite's slot.
Jan 15 2019
@sars could you take a look on thread based version (latest diff)?
Jan 11 2019
How about this async approach? I'm still testing. So far it's ok.
Jan 8 2019
replaced path() with toLocalFIle()
Jan 7 2019
It seems there are 2 kind of widgets in KSaneWidget that don't repaint if you call KSaneWidget::repaint()
One is QGraphicsView-derived KSaneViewer, bcs it needs viewport()->repaint() instead.
Another are two QScrollAreas in 2 tabs for basic and other options. They need widget()->repaint() instead.
replace qApp->processEvents() with
Jan 6 2019
Typos are fixed. Thanks!
Jan 5 2019
Jan 4 2019
How about that:
Ok for QDir(), but still for local files only
As for SaveLocation - let's just pop up m_saveLocation dialog till user enter a valid directory that we can create.
Display dirUrl.path() instead of dir in message as dir will have "file://" schema. It just looks better without it
Dec 11 2018
Dec 8 2018
Done, let me know if CI fails again.
Dec 2 2018
I won't be able to test this. It's hard to setup build chain in virtual machine and it depends on some other kf5 libs.
How about just commiting it? As Win compilation is already broken it won't make worse