trufanov (Alexander Trufanov)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Mar 8 2017, 4:36 PM (101 w, 4 d)
Availability
Available

Recent Activity

Tue, Feb 12

trufanov added inline comments to D18966: Postpone device settings change if scanning is in progress.
Tue, Feb 12, 9:14 PM
trufanov requested review of D18966: Postpone device settings change if scanning is in progress.
Tue, Feb 12, 5:49 PM
trufanov updated the diff for D17510: Postponed settings change if scanning is in progress.

oops, made a copy-paste mistake. Updated again

Tue, Feb 12, 2:22 PM
trufanov updated the diff for D17510: Postponed settings change if scanning is in progress.

updated

Tue, Feb 12, 2:19 PM

Mon, Feb 11

trufanov updated the diff for D17510: Postponed settings change if scanning is in progress.

Ok, in this case this we need to patch 2 projects and this review will contain only a minimal changes.

Mon, Feb 11, 10:19 PM
trufanov committed R483:f1e5c7e1a0c4: Saving image is moved to thread + auto creating missing output folders (authored by trufanov).
Saving image is moved to thread + auto creating missing output folders
Mon, Feb 11, 7:37 PM
trufanov closed D17955: Skanlite may create missing output directories automtically (with user's permission).
Mon, Feb 11, 7:37 PM
trufanov closed D18446: Add static version of toQImageSilent().
Mon, Feb 11, 7:24 PM
trufanov committed R382:130c4503068e: Static version of toQImageSilent() (authored by trufanov).
Static version of toQImageSilent()
Mon, Feb 11, 7:24 PM
trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

Ok, now with renamed var.

Mon, Feb 11, 1:29 PM
trufanov updated the diff for D18446: Add static version of toQImageSilent().

I've just realized that I forgot to add implementation of a new static func for TWAIN libksane version (ktwain_widget.cpp) AGAIN.
TWAIN ver is build for Windows only and mostly consists of stubs. Last time I forget about it it caused a lib compilation failure during CI autotests and I was traced by admin to fix this.
Luckily the patch wasn't commited yet.

Mon, Feb 11, 1:19 PM
trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

updated

Mon, Feb 11, 3:17 AM

Sat, Feb 9

trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

Now with saveQImage() splitted into saveQImage() and save16BitPng().
And more correct processing of 16bit m_img saving if it's non empty and was already converted inside Skanlite::imageReady bcs of showB4Save->isChecked()

Sat, Feb 9, 4:41 PM
trufanov added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

Sorry, I missed your reply and realized that only now.
I've already forget the code and probably bcs of that didn't get your comment.

Sat, Feb 9, 4:35 PM

Tue, Jan 29

trufanov added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

Ping!

Tue, Jan 29, 8:25 AM

Tue, Jan 22

trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

One more update, all notes should be addressed in this except for passing fileUrl

Tue, Jan 22, 9:53 AM
trufanov added inline comments to D17955: Skanlite may create missing output directories automtically (with user's permission).
Tue, Jan 22, 9:47 AM
trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

Update to a QThread-based approach of image saving. Now it uses static KSaneWidget::toQImageSilent(). Thus this requires https://phabricator.kde.org/D18446 to be applied.
As it's static it can't emit signals and thus KSaneImageSaver is now getting pointer to KSaneWidget to emit it's signal in case of problems.
Also KSaneImageSaver is now a member of Skanlite class and it's lambda is replaced with new Skanlite's slot.

Tue, Jan 22, 5:57 AM
trufanov requested review of D18446: Add static version of toQImageSilent().
Tue, Jan 22, 5:46 AM
trufanov added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).
In D17955#393880, @sars wrote:
Tue, Jan 22, 5:41 AM

Jan 15 2019

trufanov added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

@sars could you take a look on thread based version (latest diff)?

Jan 15 2019, 7:46 AM

Jan 11 2019

trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

How about this async approach? I'm still testing. So far it's ok.

Jan 11 2019, 11:03 AM

Jan 8 2019

trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

replaced path() with toLocalFIle()

Jan 8 2019, 3:54 PM
trufanov added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).
In D17955#388887, @sars wrote:

But this all is to just re-paint one time before we freeze for the time it takes to save of the file? Would it be better in the long run to think about moving the saving to a thread?

Jan 8 2019, 3:13 PM

Jan 7 2019

trufanov added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).

It seems there are 2 kind of widgets in KSaneWidget that don't repaint if you call KSaneWidget::repaint()
One is QGraphicsView-derived KSaneViewer, bcs it needs viewport()->repaint() instead.
Another are two QScrollAreas in 2 tabs for basic and other options. They need widget()->repaint() instead.

Jan 7 2019, 4:53 PM
trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

replace qApp->processEvents() with

Jan 7 2019, 1:27 PM
trufanov added a comment to D17955: Skanlite may create missing output directories automtically (with user's permission).
In D17955#387893, @sars wrote:

Besides the processEvents() I'm OK with this! :)

Jan 7 2019, 1:11 PM

Jan 6 2019

trufanov updated the diff for D18001: Display last scanned image in tab of libksane's KSaneWidget.

Typos are fixed. Thanks!

Jan 6 2019, 4:29 PM
trufanov requested review of D18002: Add "Display last image in separate tab" option.
Jan 6 2019, 12:18 AM

Jan 5 2019

trufanov requested review of D18001: Display last scanned image in tab of libksane's KSaneWidget.
Jan 5 2019, 11:56 PM

Jan 4 2019

trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

How about that:
Ok for QDir(), but still for local files only
As for SaveLocation - let's just pop up m_saveLocation dialog till user enter a valid directory that we can create.

Jan 4 2019, 5:36 PM
trufanov updated the diff for D17955: Skanlite may create missing output directories automtically (with user's permission).

Display dirUrl.path() instead of dir in message as dir will have "file://" schema. It just looks better without it

Jan 4 2019, 12:13 AM
trufanov requested review of D17955: Skanlite may create missing output directories automtically (with user's permission).
Jan 4 2019, 12:10 AM

Dec 11 2018

trufanov requested review of D17510: Postponed settings change if scanning is in progress.
Dec 11 2018, 6:22 PM

Dec 8 2018

trufanov added a comment to D17186: Fix Windows CI build issues caused by startPreviewScan slot.

Done, let me know if CI fails again.

Dec 8 2018, 2:14 AM
trufanov committed R382:1ac580bc6f78: Fix Windows CI build issues caused by startPreviewScan slot (authored by trufanov).
Fix Windows CI build issues caused by startPreviewScan slot
Dec 8 2018, 2:14 AM
trufanov closed D17186: Fix Windows CI build issues caused by startPreviewScan slot.
Dec 8 2018, 2:14 AM

Dec 2 2018

trufanov added a comment to D17186: Fix Windows CI build issues caused by startPreviewScan slot.

Hi, Kåre
I won't be able to test this. It's hard to setup build chain in virtual machine and it depends on some other kf5 libs.
How about just commiting it? As Win compilation is already broken it won't make worse

Dec 2 2018, 8:45 PM

Nov 27 2018

trufanov updated the summary of D17186: Fix Windows CI build issues caused by startPreviewScan slot.
Nov 27 2018, 2:21 PM
trufanov requested review of D17186: Fix Windows CI build issues caused by startPreviewScan slot.
Nov 27 2018, 2:18 PM

Nov 11 2018

trufanov committed R483:d4483c1bc95c: D-Bus global hotkey for scanner preview (authored by trufanov).
D-Bus global hotkey for scanner preview
Nov 11 2018, 4:46 PM
trufanov closed D16813: D-Bus global hotkey for scanner preview.
Nov 11 2018, 4:46 PM
trufanov committed R382:5d956f9a0788: Export startPreviewScan slot (authored by trufanov).
Export startPreviewScan slot
Nov 11 2018, 4:40 PM
trufanov closed D16795: Export preview slot.
Nov 11 2018, 4:40 PM

Nov 10 2018

trufanov requested review of D16813: D-Bus global hotkey for scanner preview.
Nov 10 2018, 10:26 PM

Nov 9 2018

trufanov requested review of D16795: Export preview slot.
Nov 9 2018, 11:34 PM

May 22 2018

trufanov requested review of D13045: Bugfix crash on port change.
May 22 2018, 5:23 PM

Mar 20 2018

trufanov added a comment to D11070: An alternative to the web interface.

One problem I could not crack is that adding a mangnet link does not work as
expected. The code that adds magnet links is the same as the callback from
the code that adds magnet links from the callback menus, but when my plugin
tries to add a magnet link, they just appear in the "Magnet Downloads" panel
and they there with zero peers. I have no idea why.

Mar 20 2018, 5:40 PM

Mar 8 2018

trufanov added a comment to D11070: An alternative to the web interface.

I doubt I could be useful as a reviewer here bcs of lack of web/JS knowledge. Just wan't to say that in my opinion security evaluation should be prioritised. For a last few months I saw at least two news about hacker attacks on linux-based torrents via their web interfaces.

Mar 8 2018, 4:02 PM

Nov 14 2017

trufanov committed R223:4b2ba6a7af25: Try to display a malformed image if feasible (authored by trufanov).
Try to display a malformed image if feasible
Nov 14 2017, 11:42 AM
trufanov closed D8415: Soften correctness of image file open check.
Nov 14 2017, 11:42 AM · Okular
trufanov updated the diff for D8415: Soften correctness of image file open check.

Wording of a warning message is changed.
With dot at sentence end.
A screenshot of warning appearance is attached{F5491726}

Nov 14 2017, 11:21 AM · Okular

Nov 13 2017

trufanov added a comment to D8415: Soften correctness of image file open check.

@ngraham Feel free to do it yourself.

Nov 13 2017, 10:50 PM · Okular
trufanov added a comment to D8415: Soften correctness of image file open check.

Ok, I've added a warning for this. Please check wording - english isn't my native language. Feel free to change it.
Attached are screenshots of Okular showing current warning for eng and rus locales.

Nov 13 2017, 8:40 AM · Okular
trufanov updated the diff for D8415: Soften correctness of image file open check.

warning message was added

Nov 13 2017, 8:33 AM · Okular

Oct 30 2017

trufanov added a comment to D8415: Soften correctness of image file open check.
In D8415#162014, @aacid wrote:
In D8415#159049, @aacid wrote:

Please consider fixing this in Qt before asking us to create a workaround.

I'm fine with workarounded gwenview as well as working GIMP and ImageMagick.

Is this your way of saying "i'm not interested in pursuing a fix in Qt"?

Oct 30 2017, 9:44 PM · Okular

Oct 27 2017

trufanov added a comment to D8415: Soften correctness of image file open check.
In D8415#159049, @aacid wrote:

Please consider fixing this in Qt before asking us to create a workaround.

Oct 27 2017, 1:29 PM · Okular

Oct 26 2017

trufanov committed R473:a8e5a1d272f5: Fix IPFilter plugin (authored by trufanov).
Fix IPFilter plugin
Oct 26 2017, 12:40 PM
trufanov committed R473:ff87f41c2655: Bump Version (authored by trufanov).
Bump Version
Oct 26 2017, 12:37 PM

Oct 23 2017

trufanov added a comment to D8415: Soften correctness of image file open check.
In D8415#158804, @aacid wrote:

Wouldn't it make more sense to fix this in QImageReader and not in every user of QImageReader ?

Oct 23 2017, 12:50 PM · Okular
trufanov added a comment to D8415: Soften correctness of image file open check.

Ok, I've edited summary. Didn't know that KDE Bugs could be referred in a such way in phabricator summary instead of commit message.
Also I heard I can add
Differential Revision: https://phabricator.kde.org/D8415
in commit message to automatically close phabricator review. Is it so?

Oct 23 2017, 12:18 PM · Okular
trufanov updated the summary of D8415: Soften correctness of image file open check.
Oct 23 2017, 11:50 AM · Okular

Oct 22 2017

trufanov created D8415: Soften correctness of image file open check.
Oct 22 2017, 9:48 AM · Okular

Oct 5 2017

trufanov committed R473:62a160b49381: Fix toolbar button text hiding opt (authored by trufanov).
Fix toolbar button text hiding opt
Oct 5 2017, 1:31 PM

Jun 5 2017

trufanov committed R473:ae81bbff5537: Fix TabbarWidget buttons brokennes (authored by trufanov).
Fix TabbarWidget buttons brokennes
Jun 5 2017, 8:09 PM

May 18 2017

trufanov committed R483:dae356c9606e: Fix hotkeys in skanlite.khotkeys sample (authored by trufanov).
Fix hotkeys in skanlite.khotkeys sample
May 18 2017, 8:23 AM

Apr 12 2017

trufanov committed R473:4907278a9352: Safe filepath processing at new torrent content selection (authored by trufanov).
Safe filepath processing at new torrent content selection
Apr 12 2017, 12:35 PM

Apr 11 2017

trufanov committed R473:acc03acf1a1b: revive search plugin (authored by trufanov).
revive search plugin
Apr 11 2017, 2:24 PM
trufanov committed R473:5818cfd20009: fix crash on app exit (authored by trufanov).
fix crash on app exit
Apr 11 2017, 1:20 PM

Apr 8 2017

trufanov committed R473:f93c2f36ef85: fix i18n for IPFilter plugin settings (authored by trufanov).
fix i18n for IPFilter plugin settings
Apr 8 2017, 12:56 PM

Apr 5 2017

trufanov committed R472:4b729af356c3: fix DHT::addDHTNode() (authored by trufanov).
fix DHT::addDHTNode()
Apr 5 2017, 3:05 AM
trufanov committed R473:47769c560f6a: Fix script manager context menu (authored by trufanov).
Fix script manager context menu
Apr 5 2017, 1:21 AM
trufanov committed R472:4049602f8db9: fix HTTP Proxy usage (authored by trufanov).
fix HTTP Proxy usage
Apr 5 2017, 1:09 AM

Mar 21 2017

trufanov committed R241:67337efacaa8: Merge branch 'master' of git://anongit.kde.org/kio (authored by trufanov).
Merge branch 'master' of git://anongit.kde.org/kio
Mar 21 2017, 1:58 PM
trufanov committed R241:c3fd249e5783: keep query encoding when HTTP Proxy is used (authored by trufanov).
keep query encoding when HTTP Proxy is used
Mar 21 2017, 1:58 PM

Mar 17 2017

trufanov committed R483:3084bd66ead5: DBus signal - imageSaved (authored by trufanov).
DBus signal - imageSaved
Mar 17 2017, 12:37 PM

Mar 16 2017

trufanov committed R382:5be9788099de: force preview update after clear selection is pressed REVIEW:130017 (authored by trufanov).
force preview update after clear selection is pressed REVIEW:130017
Mar 16 2017, 5:14 PM

Mar 14 2017

trufanov committed R483:65e6d4069274: allow index to start from 0 (authored by trufanov).
allow index to start from 0
Mar 14 2017, 1:43 PM

Mar 12 2017

trufanov committed R483:9106f555439d: D-Bus support (authored by trufanov).
D-Bus support
Mar 12 2017, 12:26 PM

Mar 9 2017

trufanov committed R483:e9eaf4c80ef0: Bugfix: wrong folder selection dialog behavior (authored by trufanov).
Bugfix: wrong folder selection dialog behavior
Mar 9 2017, 3:04 PM