Move createUDSEntry from file.cpp to file_unix.cpp
ClosedPublic

Authored by meven on Nov 14 2019, 10:15 AM.

Details

Summary

This was a unix only function in the shared file protocol cpp
This has not been used at all in file_win.cpp for a while

Diff Detail

Repository
R241 KIO
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
meven created this revision.Nov 14 2019, 10:15 AM
Restricted Application added a project: Frameworks. · View Herald TranscriptNov 14 2019, 10:15 AM
Restricted Application added a subscriber: kde-frameworks-devel. · View Herald Transcript
meven requested review of this revision.Nov 14 2019, 10:15 AM
dfaure accepted this revision.Feb 2 2020, 10:32 AM

Well spotted.

Sorry for the delay in my review.

This revision is now accepted and ready to land.Feb 2 2020, 10:32 AM
meven added a comment.Feb 2 2020, 6:21 PM

I have currently a couple of patches touching the same lines, so I will postpone this land after to save me some rebasing time.

meven updated this revision to Diff 78141.Sat, Mar 21, 9:15 AM

Rebase on master

dfaure accepted this revision.Sat, Mar 21, 11:33 AM
dfaure added inline comments.
src/ioslaves/file/file_unix.cpp
147

static

164

static

248

static

meven updated this revision to Diff 78159.Sat, Mar 21, 12:38 PM
meven marked 3 inline comments as done.

Add 3 missing static

dfaure accepted this revision.Sat, Mar 21, 12:43 PM
This revision was automatically updated to reflect the committed changes.

Fails to build here

file_unix.cpp:384:9: error: ‘appendACLAtoms’ was not declared in this scope

I'll investigate. You might want to install the necessary libs for the ACL code to be enabled on your system.