okay. Landing it. \o/

ship it.
Snore toast will already get installed but the notifications will be missing.

We still haven't landed KNotifications patch, so I'm waiting on that, since this patch uses SnoreToast call.
We could land it anyway, and instructions related to SnoreToast will just start working after landing the KNotifications patch(es)

I'm not familiar with arcanist, so I'll just add some extra info in a message.

Has this been landed yet? Is there any reason to keep it open?

removed executable key since it's deprecated ✂

Let's discuss at the sprint?
Have you considered what it would look like using libssl.so directly?

• Rebase

Ping?

Can we possibly implement Kirigami interfaces for some of the things in plasma-integration?

removed context-based shortcut handing

SnoreToast supports absolute path now!

the new diff has correct shortcut installations and removals upon un-installation. be sure to update craft by

craft craft

before testing :)

we don't provide an option for custome uninstall icons and using the app icon would be confusing.

The only thing I immediately see as a problem is the uninstaller doesn't have the proper branding (generic icons), and it didn't uninstall the desktop shortcut

Appears to be fixed by commit 9447d7e5def9f3a2d2bcaab10e7b646faaf041a3

Rebase

Final piece is https://invent.kde.org/kde/kdeconnect-kde/merge_requests/48

What we'd need to figure out is how we best expose this in the UI

So for android work, is it , Send the file to Desktop from Android -> File Recieved -> Open Immediately ?

This was already implemented in https://invent.kde.org/kde/kdeconnect-kde/commit/c6719315dadbe299e7bd63b33173e613b9f02fe3

LGTM

Ok, great:) I'll wait then and make changes if necessary..

Your problem description is a bit inaccurate. The problem is not a local IP, it's that you don't serve the covers over https. I have a similar problem myself: Spotify is shipping album art over http.

I don't really have this problem anyways, but isn't the better solution to have the serving instance of KDE Connect do the art downloading and transfer the file as normal? I think the only external input to the android app should be from the remote paired device. This also ensures the Android app (or whichever client) has it's address isolated from any outside source.

Fixed by D18212

I'd like to check on this.

It would be good to commit the above changes back to Kaidan when we have it working nicely, since the message composition box originally came from them.

The current behaviour is anything but a "major security flaw". I consider a security issue 'major' when it allows remote code execution without needing other security issues.

I'm working for a native Windows notification APIs in this project.

This approach has a problem: Beginning with Android 8.1 we need the ACCESS_COARSE_LOCATION permission to access the Wifi SSID. It's a bit weird to ask the user for that for this feature

Fixup and rebase

Hi @lueck. No, I do not have commit access. To be honest, I am not even sure if this change should be made on the trunc branch or the stable branch.

Thanks for the patch.
Do you have commit access?

It works for me. Finally I am able to use my university's 2FA without actually touching my phone! :D

• Rebase on master
• Specify tooltip timeout
  • The documentation says -1 is the default, but apparently that wasn't working. With -1 expicitally specified, the no devices warning tooltip does not time out

In D17790#433960, @apol wrote:

Is openssl interface documented as stable somehow? or could it break anytime?