Open on remote device Android->Desktop and Desktop->Desktop
Closed, ResolvedPublic

Description

The share plugin allows sending a file to Android and open it immediately. The same would be uselful Android->Desktop or Desktop->Desktop

Desktop-side this can be achieved with QDesktopServices::openUrl()
To implement one needs to:
In the Share plugin when receiving a file check if the network packet has "open" set to true
After the file is transferred if open is true call QDesktopServices::openUrl() with the file URL

You can trigger the file opening from another desktop device using "kdeconnect-handler --open file:///home/foo/file.txt"

For this it is useful to connect the desktop to itself via the loopback link provider. You can enable it by running "cmake -DLOOPBACK_ENABLED ." in the build directory and running make again.

xyphan added a subscriber: xyphan.Mar 5 2019, 12:25 PM
apol added a subscriber: apol.Mar 5 2019, 1:28 PM

How is that different to just clicking the notification?

Also we can call QDesktopServices::openUrl() from the plugin, which should do the same as xdg-open.

So for android work, is it , Send the file to Desktop from Android -> File Recieved -> Open Immediately ?

It seems to me Work = Send files option(in Android) + open immediately (On desktop)

If so could I work on Android part ?

What we'd need to figure out is how we best expose this in the UI

piyushp moved this task from App/Plasma Mobile to Junior Jobs on the KDE Connect board.
nicolasfella updated the task description. (Show Details)Dec 19 2019, 4:34 PM
nicolasfella renamed this task from Open on remote device Android->Desktop to Open on remote device Android->Desktop and Desktop->Desktop.
nicolasfella updated the task description. (Show Details)
msethi added a subscriber: msethi.Jan 17 2020, 4:18 PM

hey aniketkumar could I work with you on this task if you need an extra pair of hands

hey msethi, if you wanna work with me on this task, you are welcome, here is my email : anikketkumar786@gmail.com

In the UI do we need to provide an option to enable or disable the immediate opening of received file?

The way it currently works is that the sender determines whether the file is opened

This comment was removed by aniketkumar.

Hey, I have completed the patch for desktop c++ repository, Now I'm working on the android part. So can I submit my c++ patch before implementing the android part?

This comment was removed by aniketkumar.

Hi, I have finished adding this feature in android app as well. This is the UI I have created which opens up after tapping on "Send files" action in mainActivity. This seems pretty nice to me, have a look at it, Should I open the merge request, or it needs any improvement?

aniketkumar added a comment.EditedFeb 15 2020, 9:19 PM

Hi , I have Submitted the merge request on gitlab's kdeconnect-android repository and desktop repository. I have tested the feature on both devices and it's working Great! Kindly have a look at it and suggest me if it's okay or not.

KDEConnect-android patch

KDEConnect-kde patch

apol added a comment.Feb 16 2020, 12:54 AM

This feels very intrusive. What's the point of doing that? isn't it easier to just press an "open" action on a file received notification?

aniketkumar added a comment.EditedFeb 16 2020, 4:45 AM

KDEConnect is all about making users life easier. Well in some cases for eg. I wanna send a presentation file from my phone to desktop, and for some reason i just don't wanna reach out to my desktop and click on open notification manually to start the slideshow, in such scenario I can use this feature from a distance and then immediately would be able to use presenter pulgin to move the slides. Similar case with video files and so on.
There is similar feature from desktop->android, so why not android->desktop and desktop->desktop.

Moreover this feature comes with no overhead or UI complications, it's very simple to use, so i might feel it would be great to have this feature.

aniketkumar added a comment.EditedFeb 21 2020, 11:19 AM

waiting for the android patch to get reviewed, so I can finish it as soon as possible and thanks for the help.
KDEConnect-android patch

cubix closed this task as Resolved.Sep 13 2020, 6:06 AM