eduisters (Erik Duisters)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Thursday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2018, 12:41 PM (8 w, 6 d)
Availability
Available

Recent Activity

Sun, Dec 9

eduisters committed R225:15ff0fca2b56: Make DeviceFragments listview use full screen width so the over scroll… (authored by eduisters).
Make DeviceFragments listview use full screen width so the over scroll…
Sun, Dec 9, 5:55 PM
eduisters closed D17456: Make DeviceFragments listview use full screen width so the over scroll indicator looks better.
Sun, Dec 9, 5:55 PM · KDE Connect
eduisters closed D17452: Fix some lint warnings.
Sun, Dec 9, 5:53 PM · KDE Connect
eduisters committed R225:87ec4f2078e6: Fix some lint warnings (authored by eduisters).
Fix some lint warnings
Sun, Dec 9, 5:53 PM
eduisters committed R225:2402b116089b: Incorporate more Material Design components (authored by eduisters).
Incorporate more Material Design components
Sun, Dec 9, 5:51 PM
eduisters closed D17451: Incorporate more Material Design components.
Sun, Dec 9, 5:51 PM · KDE Connect
eduisters committed R225:53422e090019: Use android:theme instead of app:theme because it is deprecated (authored by eduisters).
Use android:theme instead of app:theme because it is deprecated
Sun, Dec 9, 5:40 PM
eduisters closed D17434: Use android:theme instead of app:theme because it is deprecated.
Sun, Dec 9, 5:40 PM · KDE Connect
eduisters updated the summary of D17456: Make DeviceFragments listview use full screen width so the over scroll indicator looks better.
Sun, Dec 9, 5:23 PM · KDE Connect
eduisters requested review of D17456: Make DeviceFragments listview use full screen width so the over scroll indicator looks better.
Sun, Dec 9, 5:20 PM · KDE Connect
eduisters added a reviewer for D17452: Fix some lint warnings: KDE Connect.
Sun, Dec 9, 11:38 AM · KDE Connect
eduisters requested review of D17452: Fix some lint warnings.
Sun, Dec 9, 11:37 AM · KDE Connect
eduisters requested review of D17451: Incorporate more Material Design components.
Sun, Dec 9, 11:34 AM · KDE Connect

Sat, Dec 8

eduisters requested review of D17434: Use android:theme instead of app:theme because it is deprecated.
Sat, Dec 8, 5:02 PM · KDE Connect
eduisters committed R225:d4d4849f158a: Closing a SSLSockets input or output stream does not close the socket (https… (authored by eduisters).
Closing a SSLSockets input or output stream does not close the socket (https…
Sat, Dec 8, 1:28 PM
eduisters closed D17320: Closing a SSLSockets input or output stream does not close the socket (https://issuetracker.google.com/issues/37018094).
Sat, Dec 8, 1:28 PM · KDE Connect
eduisters updated the diff for D17320: Closing a SSLSockets input or output stream does not close the socket (https://issuetracker.google.com/issues/37018094).
  • Rebased onto master
Sat, Dec 8, 1:27 PM · KDE Connect
eduisters closed D17409: Do not create a new content fragment on orientation change.
Sat, Dec 8, 1:14 PM · KDE Connect
eduisters committed R225:3a189d1af4d0: Do not create a new content fragment on orientation change (authored by eduisters).
Do not create a new content fragment on orientation change
Sat, Dec 8, 1:14 PM
eduisters committed R225:9f498f81277d: Use butterknife for view binding (authored by eduisters).
Use butterknife for view binding
Sat, Dec 8, 1:13 PM
eduisters closed D17411: Use butterknife for view binding.
Sat, Dec 8, 1:13 PM · KDE Connect

Fri, Dec 7

eduisters added inline comments to D17411: Use butterknife for view binding.
Fri, Dec 7, 7:53 PM · KDE Connect
eduisters closed D17400: Make toast work from a background thread.
Fri, Dec 7, 6:22 PM · KDE Connect
eduisters committed R225:087b7ce875ae: Make toast work from a background thread (authored by eduisters).
Make toast work from a background thread
Fri, Dec 7, 6:22 PM
eduisters requested review of D17411: Use butterknife for view binding.
Fri, Dec 7, 6:05 PM · KDE Connect
eduisters requested review of D17409: Do not create a new content fragment on orientation change.
Fri, Dec 7, 5:22 PM · KDE Connect
eduisters updated the summary of D17400: Make toast work from a background thread.
Fri, Dec 7, 11:07 AM · KDE Connect
eduisters retitled D17400: Make toast work from a background thread from Make toast work from a background threat to Make toast work from a background thread.
Fri, Dec 7, 11:07 AM · KDE Connect
eduisters requested review of D17400: Make toast work from a background thread.
Fri, Dec 7, 11:00 AM · KDE Connect

Thu, Dec 6

eduisters committed R225:96a1edfb764d: Fix lint warning: Avoid non-default constructors in fragments (authored by eduisters).
Fix lint warning: Avoid non-default constructors in fragments
Thu, Dec 6, 7:29 PM
eduisters closed D17390: Fix lint warning: Avoid non-default constructors in fragments.
Thu, Dec 6, 7:29 PM · KDE Connect
eduisters updated the diff for D17390: Fix lint warning: Avoid non-default constructors in fragments.

Rebased onto master

Thu, Dec 6, 7:28 PM · KDE Connect
eduisters committed R225:6e8d9e8419dd: Remove not used constructor (authored by eduisters).
Remove not used constructor
Thu, Dec 6, 6:39 PM
eduisters closed D17389: Remove not used constructor.
Thu, Dec 6, 6:39 PM · KDE Connect
eduisters committed R225:27f8c57c50e3: Do not send null NetworkPackets (authored by eduisters).
Do not send null NetworkPackets
Thu, Dec 6, 6:38 PM
eduisters closed D17384: Do not send null NetworkPackets.
Thu, Dec 6, 6:38 PM · KDE Connect
eduisters added a dependency for D17390: Fix lint warning: Avoid non-default constructors in fragments: D17389: Remove not used constructor.
Thu, Dec 6, 6:29 PM · KDE Connect
eduisters added a dependent revision for D17389: Remove not used constructor: D17390: Fix lint warning: Avoid non-default constructors in fragments.
Thu, Dec 6, 6:29 PM · KDE Connect
eduisters requested review of D17390: Fix lint warning: Avoid non-default constructors in fragments.
Thu, Dec 6, 6:28 PM · KDE Connect
eduisters requested review of D17389: Remove not used constructor.
Thu, Dec 6, 5:44 PM · KDE Connect
eduisters updated the diff for D17384: Do not send null NetworkPackets.
  • Use np
Thu, Dec 6, 3:56 PM · KDE Connect
eduisters requested review of D17384: Do not send null NetworkPackets.
Thu, Dec 6, 3:45 PM · KDE Connect

Mon, Dec 3

eduisters updated the diff for D17320: Closing a SSLSockets input or output stream does not close the socket (https://issuetracker.google.com/issues/37018094).
  • Encapsulate mPayload, mPayloadSocket and mPayloadSize in a NetworkPacket.Payload object for easier handling
Mon, Dec 3, 7:21 PM · KDE Connect

Sun, Dec 2

eduisters committed R225:04e605bcf90f: Handle receiving an empty file (authored by eduisters).
Handle receiving an empty file
Sun, Dec 2, 6:36 PM
eduisters closed D17235: Handle receiving an empty file.
Sun, Dec 2, 6:36 PM · KDE Connect
eduisters updated the diff for D17235: Handle receiving an empty file.
  • Removed log statement
Sun, Dec 2, 6:34 PM · KDE Connect
eduisters requested review of D17320: Closing a SSLSockets input or output stream does not close the socket (https://issuetracker.google.com/issues/37018094).
Sun, Dec 2, 6:30 PM · KDE Connect

Fri, Nov 30

eduisters requested review of D17235: Handle receiving an empty file.
Fri, Nov 30, 5:06 PM · KDE Connect
eduisters planned changes to D17235: Handle receiving an empty file.

Forgot to remove a string

Fri, Nov 30, 5:03 PM · KDE Connect
eduisters updated the diff for D17235: Handle receiving an empty file.
  • Rebased onto masters
  • add assert back
Fri, Nov 30, 5:02 PM · KDE Connect
eduisters committed R225:6fb6ea7e2bcb: Clear currentShareInfo when transfer is complete (authored by eduisters).
Clear currentShareInfo when transfer is complete
Fri, Nov 30, 4:54 PM
eduisters closed D17259: Clear currentShareInfo when transfer is complete.
Fri, Nov 30, 4:54 PM · KDE Connect
eduisters updated the diff for D17259: Clear currentShareInfo when transfer is complete.
  • Always clear currentShareInfo in FinishReceivingRunnable
Fri, Nov 30, 3:30 PM · KDE Connect
eduisters planned changes to D17259: Clear currentShareInfo when transfer is complete.

Needs to be done in onError as well

Fri, Nov 30, 3:06 PM · KDE Connect
eduisters requested review of D17259: Clear currentShareInfo when transfer is complete.
Fri, Nov 30, 2:53 PM · KDE Connect
eduisters planned changes to D16491: Allow shares to be canceled.

This needs a bit of work because of all the changes to master

Fri, Nov 30, 1:49 PM · KDE Connect
eduisters committed R225:4dd651b386ea: Align NetworkPacket.hasPayload with desktop (authored by eduisters).
Align NetworkPacket.hasPayload with desktop
Fri, Nov 30, 7:41 AM
eduisters closed D17236: Align NetworkPacket.hasPayload with desktop.
Fri, Nov 30, 7:41 AM · KDE Connect
eduisters updated the diff for D17236: Align NetworkPacket.hasPayload with desktop.

Rebased onto master

Fri, Nov 30, 7:39 AM · KDE Connect
eduisters committed R225:9b426fe4a53d: Receive multiple files using 1 notification (authored by eduisters).
Receive multiple files using 1 notification
Fri, Nov 30, 7:36 AM
eduisters closed D17157: Receive multiple files using 1 notification.
Fri, Nov 30, 7:36 AM · KDE Connect
eduisters updated the diff for D17157: Receive multiple files using 1 notification.
  • Rebased onto master
Fri, Nov 30, 7:34 AM · KDE Connect
eduisters committed R224:b6c15289f511: Combine multiple upload jobs into a single KCompositeJob so only 1 notification… (authored by eduisters).
Combine multiple upload jobs into a single KCompositeJob so only 1 notification…
Fri, Nov 30, 7:27 AM
eduisters closed D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.
Fri, Nov 30, 7:27 AM · KDE Connect
eduisters updated the diff for D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.
  • Rebased onto master
Fri, Nov 30, 7:25 AM · KDE Connect

Thu, Nov 29

eduisters added a comment to D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.

The only thing, but seems hard to fix is: when there is a transfer in progress and I add another file, the job is updated to say "sending N+1 files", but on Android it still says "receiving N files".

Thu, Nov 29, 8:59 PM · KDE Connect
eduisters planned changes to D17235: Handle receiving an empty file.

Waiting for D17236 so requested change by albertvaka can be implemented

Thu, Nov 29, 4:43 PM · KDE Connect
eduisters requested review of D17236: Align NetworkPacket.hasPayload with desktop.
Thu, Nov 29, 3:39 PM · KDE Connect
eduisters requested review of D17235: Handle receiving an empty file.
Thu, Nov 29, 1:42 PM · KDE Connect

Wed, Nov 28

eduisters claimed T8289: Share whole folder.
Wed, Nov 28, 7:02 PM · Junior Jobs, KDE Connect
eduisters updated the diff for D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.
  • Requested changes by apol
Wed, Nov 28, 6:56 PM · KDE Connect
eduisters added inline comments to D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.
Wed, Nov 28, 6:46 PM · KDE Connect
eduisters committed R224:538872ddc888: Handle receiving empty file from Android (authored by eduisters).
Handle receiving empty file from Android
Wed, Nov 28, 2:50 PM
eduisters closed D17175: Handle receiving empty file from Android.
Wed, Nov 28, 2:50 PM · KDE Connect
eduisters closed D17176: Allow sharing of empty files.
Wed, Nov 28, 2:49 PM · KDE Connect
eduisters committed R225:5d50358f3f37: Allow sharing of empty files (authored by eduisters).
Allow sharing of empty files
Wed, Nov 28, 2:49 PM

Tue, Nov 27

eduisters updated the diff for D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.
  • Rebased onto master
Tue, Nov 27, 10:22 AM · KDE Connect

Mon, Nov 26

eduisters added a comment to D17176: Allow sharing of empty files.

If you want I could make it work in a backwards compatible way (reverse connection)

Mon, Nov 26, 7:42 PM · KDE Connect
eduisters updated the summary of D17157: Receive multiple files using 1 notification.
Mon, Nov 26, 6:00 PM · KDE Connect
eduisters committed R224:2c9fde483ad1: Show progress when sending a file from desktop (authored by eduisters).
Show progress when sending a file from desktop
Mon, Nov 26, 5:33 PM
eduisters closed D16279: Show progress when sending a file from desktop.
Mon, Nov 26, 5:33 PM · KDE Connect
eduisters requested review of D17176: Allow sharing of empty files.
Mon, Nov 26, 5:10 PM · KDE Connect
eduisters updated the test plan for D17175: Handle receiving empty file from Android.
Mon, Nov 26, 5:08 PM · KDE Connect
eduisters requested review of D17175: Handle receiving empty file from Android.
Mon, Nov 26, 5:06 PM · KDE Connect

Sun, Nov 25

eduisters requested review of D17157: Receive multiple files using 1 notification.
Sun, Nov 25, 4:49 PM · KDE Connect
eduisters updated the diff for D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.
  • Fixed a typo
Sun, Nov 25, 4:46 PM · KDE Connect

Sat, Nov 24

eduisters planned changes to D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.

Something weird is going on when sending files over a super fast connection. While remote is still receiving a file this side already starts sending the next file when its finished transmitting the previous one.

Sat, Nov 24, 7:24 PM · KDE Connect

Wed, Nov 21

eduisters added a comment to D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.

BUG: 390876

Wed, Nov 21, 7:43 PM · KDE Connect
eduisters updated the diff for D16279: Show progress when sending a file from desktop.
  • Only show progress when transferring files with size >= 0
Wed, Nov 21, 6:59 PM · KDE Connect
eduisters requested review of D17081: Combine multiple upload jobs into a single KCompositeJob so only 1 notification will be shown.
Wed, Nov 21, 6:52 PM · KDE Connect
eduisters planned changes to D16279: Show progress when sending a file from desktop.

Progress only needs to be shown when uploading a file

Wed, Nov 21, 4:03 PM · KDE Connect

Tue, Nov 20

eduisters committed R225:96b0a9ea9b08: A SO_TIMEOUT of 1 second often leads to the socket timing out when transferring… (authored by eduisters).
A SO_TIMEOUT of 1 second often leads to the socket timing out when transferring…
Tue, Nov 20, 12:51 PM
eduisters closed D16758: A SO_TIMEOUT of 1 second often leads to the socket timing out when transferring large files..
Tue, Nov 20, 12:51 PM · KDE Connect
eduisters claimed T8373: [Junior Job] Use composite job for multiple file transfers.
Tue, Nov 20, 9:16 AM · Junior Jobs, KDE Connect
eduisters claimed T8293: Improve file sharing.
Tue, Nov 20, 9:16 AM · Junior Jobs, KDE Connect
eduisters added a member for KDE Connect: eduisters.
Tue, Nov 20, 9:15 AM
eduisters added a comment to T8289: Share whole folder.

@abhate , are you still working on this task? If not I would like to take it because I am working on something similar

Tue, Nov 20, 9:12 AM · Junior Jobs, KDE Connect

Mon, Nov 19

eduisters committed R224:fb0990743a85: QTcpServer already has a list of pending connections and emits newConnection… (authored by eduisters).
QTcpServer already has a list of pending connections and emits newConnection…
Mon, Nov 19, 1:15 PM
eduisters closed D17009: QTcpServer already has a list of pending connections and emits newConnection after calling incomingConnection.
Mon, Nov 19, 1:15 PM · KDE Connect
eduisters requested review of D17009: QTcpServer already has a list of pending connections and emits newConnection after calling incomingConnection.
Mon, Nov 19, 11:13 AM · KDE Connect