eduisters (Erik Duisters)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Wednesday

  • Clear sailing ahead.

User Details

User Since
Oct 10 2018, 12:41 PM (32 w, 4 d)
Availability
Available

Recent Activity

Fri, May 3

eduisters updated the task description for T8293: Improve file sharing.
Fri, May 3, 4:32 PM · Junior Jobs, KDE Connect
eduisters updated the task description for T8293: Improve file sharing.
Fri, May 3, 4:30 PM · Junior Jobs, KDE Connect
eduisters closed T5384: Fix the SFTP plugin on some phones (use Android Storage Access Framework?) as Resolved.

Fixed by D18212

Fri, May 3, 4:27 PM · KDE Connect
eduisters committed R224:6fb67d026194: Delete partially downloaded file when transfer is canceled locally (authored by eduisters).
Delete partially downloaded file when transfer is canceled locally
Fri, May 3, 4:00 PM

Wed, May 1

eduisters committed R225:c7a4f76f2bf5: If Android creates a different filename than requested delete the newly created… (authored by eduisters).
If Android creates a different filename than requested delete the newly created…
Wed, May 1, 11:17 AM

Tue, Apr 30

eduisters committed R225:b9a0f310c7c6: Do not strip leading '/' from parentSuffix for non root files when determining… (authored by eduisters).
Do not strip leading '/' from parentSuffix for non root files when determining…
Tue, Apr 30, 5:08 AM

Sat, Apr 27

eduisters committed R225:d1c0a9763d58: Remove unnecessary logging (authored by eduisters).
Remove unnecessary logging
Sat, Apr 27, 5:37 PM

Apr 7 2019

eduisters committed R225:a3fb423dd315: Upload files using a CompositeUploadFileJob making the upload cancelable (authored by eduisters).
Upload files using a CompositeUploadFileJob making the upload cancelable
Apr 7 2019, 5:54 PM

Mar 23 2019

eduisters committed R225:a1467675808e: Properly handle non-root tree-uri's (authored by eduisters).
Properly handle non-root tree-uri's
Mar 23 2019, 7:50 PM

Mar 8 2019

eduisters committed R225:f2e505b8af2e: Allow shares from desktop to be canceled (authored by eduisters).
Allow shares from desktop to be canceled
Mar 8 2019, 6:08 PM
eduisters closed D16491: Allow shares from desktop to be canceled.
Mar 8 2019, 6:08 PM · KDE Connect
eduisters committed R225:a6fdddf84379: Use Storage Access Framework on SDK >= 21 (Lollipop and above) (authored by eduisters).
Use Storage Access Framework on SDK >= 21 (Lollipop and above)
Mar 8 2019, 2:02 PM
eduisters closed D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).
Mar 8 2019, 2:02 PM · KDE Connect
eduisters added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Can you try if the EditText is now not editable anymore on you OnePlus 6?

Mar 8 2019, 12:51 PM · KDE Connect
eduisters updated the diff for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).
  • Use same default preference value for "add camera shortcuts" preference as defined in xml
  • Attempt to make EditText not editable on OnePlus 6
Mar 8 2019, 12:45 PM · KDE Connect
eduisters added inline comments to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).
Mar 8 2019, 9:27 AM · KDE Connect

Mar 7 2019

eduisters added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

This has been stuck for super long, I'm really sorry... testing now.

I don't get any relevant place to pick from as a "storage location" on OnePlus 6 (only "Downloads"):

Why?

Also, really minor but I think the first field shouldn't be editable:

Mar 7 2019, 7:07 PM · KDE Connect

Mar 4 2019

eduisters committed R225:085fb1025b9b: Capture PairingHandlerCallback and call its pairingDone method instead of… (authored by eduisters).
Capture PairingHandlerCallback and call its pairingDone method instead of…
Mar 4 2019, 6:25 PM
eduisters committed R225:bc2836f45f77: Also verify that Device.PairingCallback.unpaired() is called (authored by eduisters).
Also verify that Device.PairingCallback.unpaired() is called
Mar 4 2019, 6:23 PM
eduisters committed R225:b135ffa92a66: Also verify that Device.PairingCallback.pairingSuccessful() is called (authored by eduisters).
Also verify that Device.PairingCallback.pairingSuccessful() is called
Mar 4 2019, 6:21 PM

Mar 3 2019

eduisters committed R225:9d5a6fa0fd2e: Fixed NPE when contentIntent is triggered (authored by eduisters).
Fixed NPE when contentIntent is triggered
Mar 3 2019, 2:52 PM
eduisters committed R225:024a084b9a67: Add DeviceType test (authored by eduisters).
Add DeviceType test
Mar 3 2019, 1:10 PM

Mar 2 2019

eduisters committed R225:ff51544e467f: Clean up formatting (authored by eduisters).
Clean up formatting
Mar 2 2019, 4:32 PM

Mar 1 2019

eduisters committed R225:7afbbb452baf: Removed vectorDrawables.useSupportLibrary = true (authored by eduisters).
Removed vectorDrawables.useSupportLibrary = true
Mar 1 2019, 10:52 AM

Feb 21 2019

eduisters added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Cool! I like the warning popup!

Does the system automatically configure the device 'root' now? I can't tell if that was there by default or if it was just left over from when I had this before...

Feb 21 2019, 7:32 AM · KDE Connect

Feb 20 2019

eduisters added a comment to D16491: Allow shares from desktop to be canceled.

ping -c2 -s3G

Feb 20 2019, 8:40 PM · KDE Connect
eduisters added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Kling klokje klingelingeling

Feb 20 2019, 8:39 PM · KDE Connect

Feb 2 2019

eduisters committed R225:56f129ddf454: Use an AlertDialogFragment instead of a AlertDialog for Plugin.getErrorDialog() (authored by eduisters).
Use an AlertDialogFragment instead of a AlertDialog for Plugin.getErrorDialog()
Feb 2 2019, 11:49 PM
eduisters committed R225:d364401ea939: Use DialogFragment instead of an AlertDialog for runtime permissions (authored by eduisters).
Use DialogFragment instead of an AlertDialog for runtime permissions
Feb 2 2019, 11:38 AM
eduisters committed R225:fc119515323e: Fix keyboard input on Pie (Android 9/API 28) BUG: 401726 (authored by eduisters).
Fix keyboard input on Pie (Android 9/API 28) BUG: 401726
Feb 2 2019, 11:38 AM
eduisters committed R225:f4c80dd839c0: Use an EditTextPreference for changing the device name instead of an AlertDialog (authored by eduisters).
Use an EditTextPreference for changing the device name instead of an AlertDialog
Feb 2 2019, 11:38 AM
eduisters committed R225:da9b4ea19eeb: Do not query for contacts when there are no contacts (authored by eduisters).
Do not query for contacts when there are no contacts
Feb 2 2019, 11:38 AM
eduisters committed R225:874e100e9135: Add packet type "kdeconnect.share.request.update" to allow android to update… (authored by eduisters).
Add packet type "kdeconnect.share.request.update" to allow android to update…
Feb 2 2019, 11:38 AM
eduisters committed R225:6864cec3fad5: Merge branch 'improve_multi_file_sharing' of invent.kde.org… (authored by eduisters).
Merge branch 'improve_multi_file_sharing' of invent.kde.org…
Feb 2 2019, 11:38 AM
eduisters committed R225:e098ebdaf458: Add packet type "kdeconnect.share.request.update" to allow android to update… (authored by eduisters).
Add packet type "kdeconnect.share.request.update" to allow android to update…
Feb 2 2019, 11:38 AM

Jan 31 2019

eduisters committed R224:805795af073f: Do not send an update packet until we have actually begun processing sub-jobs (authored by eduisters).
Do not send an update packet until we have actually begun processing sub-jobs
Jan 31 2019, 12:31 AM
eduisters committed R224:975dd6e907d9: Rebased onto master (authored by eduisters).
Rebased onto master
Jan 31 2019, 12:31 AM
eduisters committed R224:a9958eca74a6: Add packet type "kdeconnect.share.request.update" to allow android to update… (authored by eduisters).
Add packet type "kdeconnect.share.request.update" to allow android to update…
Jan 31 2019, 12:31 AM
eduisters committed R224:d1734286ad1a: Merge branch 'improve_multi_file_sharing' of invent.kde.org… (authored by eduisters).
Merge branch 'improve_multi_file_sharing' of invent.kde.org…
Jan 31 2019, 12:31 AM
eduisters committed R224:87e241d2c127: Add packet type "kdeconnect.share.request.update" to allow android to update… (authored by eduisters).
Add packet type "kdeconnect.share.request.update" to allow android to update…
Jan 31 2019, 12:31 AM
eduisters committed R224:0f2a60065a12: Add packet type "kdeconnect.share.request.update" to allow android to update… (authored by eduisters).
Add packet type "kdeconnect.share.request.update" to allow android to update…
Jan 31 2019, 12:31 AM

Jan 27 2019

eduisters updated the diff for D16491: Allow shares from desktop to be canceled.
  • Removed debug logging
  • Intercept Device.SendPacketStatusCallback callbacks to prevent "Failed to send file to" notification from being shown when cancelling locally
  • Remove cancel Action when done
  • Rebased onto master
  • Rebased onto master
  • Delete ReceiveFileRunnable.java erroneously brought back by rebase
  • Rebased onto simplify_receiving_files
  • Removed debug log statement
  • Rebased onto master
  • Rebased onto master
Jan 27 2019, 3:22 PM · KDE Connect

Jan 24 2019

eduisters committed R224:273c9bb6e403: Handle errorMessage in kdeconnect.sftp packet (authored by eduisters).
Handle errorMessage in kdeconnect.sftp packet
Jan 24 2019, 5:41 PM

Jan 22 2019

eduisters updated the diff for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).
  • Properly handle the situation where no storage locations have been configured
  • Handle preference changes
  • Allow deleting of the last storage location
  • Always create the right FileSystemView depending on Build.VERSION
  • Remove erroneous leftover from re-fractoring SftpSettingsActivity into SftpSettingsFragment
  • Commented out entries needed to debug org.apache.sshd
  • Remove unused variables
  • Remove optional WRITE_EXTERNAL_STORAGE permission because it is always granted on Build.VERSION < KITKAT
  • Remove required WRITE_EXTERNAL_STORAGE permission because it is always granted on Build.VERSION < 23 at installation time and we now use SaF starting Build.VERSION >= 21
  • Remove unneeded PreferenceFragmentCompat.OnPreferenceStartScreenCallback
  • Show plugin as failed on KitKat and older devices when no sdcard is detected
Jan 22 2019, 3:54 PM · KDE Connect

Jan 21 2019

eduisters committed R225:4c6b74a2eb11: Simplify receiving multiple files using only 1 notification (authored by eduisters).
Simplify receiving multiple files using only 1 notification
Jan 21 2019, 5:52 PM
eduisters closed D17627: Simplify receiving multiple files using only 1 notification.
Jan 21 2019, 5:52 PM · KDE Connect

Jan 19 2019

eduisters added a comment to D17627: Simplify receiving multiple files using only 1 notification.

ping -s 1 -c 1 -q

Jan 19 2019, 12:29 PM · KDE Connect

Jan 17 2019

eduisters committed R225:8e93e3253fbb: Use androidx version of AlertDialog (authored by eduisters).
Use androidx version of AlertDialog
Jan 17 2019, 4:21 PM
eduisters closed D18298: Use androidx version of AlertDialog.
Jan 17 2019, 4:21 PM · KDE Connect

Jan 16 2019

eduisters planned changes to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

I'll implement Alberts 1st idea because the second is just not fool-proof and will only allow read-only access to the sdcard.
As soon as we can handle disabled plugins properly I think it's better to disable the plugin until storage locations have been configured

Jan 16 2019, 3:41 PM · KDE Connect
eduisters added a reviewer for D18298: Use androidx version of AlertDialog: KDE Connect.
Jan 16 2019, 3:16 PM · KDE Connect
eduisters requested review of D18298: Use androidx version of AlertDialog.
Jan 16 2019, 3:11 PM · KDE Connect
eduisters committed R224:4834b6353778: Just set UDSEntry::UDS_NAME to the actual directory name instead of the… (authored by eduisters).
Just set UDSEntry::UDS_NAME to the actual directory name instead of the…
Jan 16 2019, 1:56 PM
eduisters closed D18223: Just set UDSEntry::UDS_NAME to the actual directory name instead of the hardcoded string "folder" and don't set UDSEntry::UDS_DISPLAY_NAME at all.
Jan 16 2019, 1:56 PM · KDE Connect
eduisters committed R225:8466a6f85337: Update for Android Studio 3.3 (authored by eduisters).
Update for Android Studio 3.3
Jan 16 2019, 1:52 PM
eduisters closed D18264: Update for Android Studio 3.3.
Jan 16 2019, 1:52 PM · KDE Connect

Jan 15 2019

eduisters added a reviewer for D18264: Update for Android Studio 3.3: KDE Connect.
Jan 15 2019, 7:49 PM · KDE Connect
eduisters removed a reviewer for D18181: Allow disabling persistent notification in Android 8.0 and up: eduisters.

+1 Look good to me

Jan 15 2019, 2:51 PM · KDE Connect
eduisters resigned from D18181: Allow disabling persistent notification in Android 8.0 and up.
Jan 15 2019, 2:37 PM · KDE Connect
eduisters requested review of D18264: Update for Android Studio 3.3.
Jan 15 2019, 2:16 PM · KDE Connect

Jan 13 2019

eduisters added a comment to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

The downside of this patch is it changes the default: I was very confused that I couldn't immediately see my USB drive and internal storage from Dolphin. Our per-plugin settings are very non-obvious :/. Is it possible to either display a dummy "you need to configure settings" file, or to show everything by default (as things currently are) and leave the settings so advanced users can hide filesystems if they like?

Jan 13 2019, 4:36 PM · KDE Connect
eduisters claimed T5384: Fix the SFTP plugin on some phones (use Android Storage Access Framework?).

Should be fixed by D18212

Jan 13 2019, 4:15 PM · KDE Connect
eduisters placed T8289: Share whole folder up for grabs.

Releasing this task for now

Jan 13 2019, 4:10 PM · Junior Jobs, KDE Connect
eduisters updated the test plan for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).
Jan 13 2019, 2:52 PM · KDE Connect
eduisters updated the test plan for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).
Jan 13 2019, 2:52 PM · KDE Connect
eduisters updated the diff for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).
  • Properly handle the situation where no storage locations have been configured
  • Handle preference changes
  • Allow deleting of the last storage location
  • Always create the right FileSystemView depending on Build.VERSION
  • Remove erroneous leftover from re-fractoring SftpSettingsActivity into SftpSettingsFragment
  • Commented out entries needed to debug org.apache.sshd
  • Remove unused variables
  • Remove optional WRITE_EXTERNAL_STORAGE permission because it is always granted on Build.VERSION < KITKAT
  • Remove required WRITE_EXTERNAL_STORAGE permission because it is always granted on Build.VERSION < 23 at installation time and we now use SaF starting Build.VERSION >= 21
  • Remove unneeded PreferenceFragmentCompat.OnPreferenceStartScreenCallback
Jan 13 2019, 2:27 PM · KDE Connect
eduisters requested review of D18223: Just set UDSEntry::UDS_NAME to the actual directory name instead of the hardcoded string "folder" and don't set UDSEntry::UDS_DISPLAY_NAME at all.
Jan 13 2019, 1:53 PM · KDE Connect
eduisters abandoned D18211: Android now exports a virtual root containing only the configured storage display names as root entries.

Commit message and title are completely wrong for this patch, starting over

Jan 13 2019, 1:48 PM · KDE Connect
eduisters planned changes to D18211: Android now exports a virtual root containing only the configured storage display names as root entries.

Fixing a bug

Jan 13 2019, 9:14 AM · KDE Connect

Jan 12 2019

eduisters planned changes to D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).

Forgot to remove some WIP stuff

Jan 12 2019, 10:37 PM · KDE Connect
eduisters added a reviewer for D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above): KDE Connect.
Jan 12 2019, 6:45 PM · KDE Connect
eduisters added a reviewer for D18211: Android now exports a virtual root containing only the configured storage display names as root entries: KDE Connect.
Jan 12 2019, 6:39 PM · KDE Connect
eduisters requested review of D18212: Use Storage Access Framework on SDK >= 21 (Lollipop and above).
Jan 12 2019, 6:32 PM · KDE Connect
eduisters requested review of D18211: Android now exports a virtual root containing only the configured storage display names as root entries.
Jan 12 2019, 6:29 PM · KDE Connect
eduisters requested changes to D18181: Allow disabling persistent notification in Android 8.0 and up.

I think changing the title to "Persistent Notification" and summary to "Click to enable/disable in Notification settings" would be better for Oreo and newer

Jan 12 2019, 11:40 AM · KDE Connect

Jan 11 2019

eduisters requested changes to D18181: Allow disabling persistent notification in Android 8.0 and up.

The "Show persistent notifications" switch should represent reality. If it's on the notification should be displayed and if it's off the notification should not be visible.

Jan 11 2019, 1:07 PM · KDE Connect

Jan 8 2019

eduisters committed R225:72026d94bf59: Switch to MaterialComponents theme (authored by eduisters).
Switch to MaterialComponents theme
Jan 8 2019, 9:08 AM
eduisters closed D18039: Switch to MaterialComponents theme.
Jan 8 2019, 9:08 AM · KDE Connect

Jan 7 2019

eduisters added inline comments to D17627: Simplify receiving multiple files using only 1 notification.
Jan 7 2019, 2:54 PM · KDE Connect
eduisters added a reviewer for D18039: Switch to MaterialComponents theme: KDE Connect.
Jan 7 2019, 2:29 PM · KDE Connect
eduisters requested review of D18039: Switch to MaterialComponents theme.
Jan 7 2019, 2:21 PM · KDE Connect

Jan 6 2019

eduisters planned changes to D16491: Allow shares from desktop to be canceled.

Needs rebasing after D17627 lands

Jan 6 2019, 1:08 PM · KDE Connect
eduisters updated the diff for D17627: Simplify receiving multiple files using only 1 notification.
  • Rebased onto master
Jan 6 2019, 1:07 PM · KDE Connect
eduisters committed R225:417333897422: Make tapping on a pair notification work again (authored by eduisters).
Make tapping on a pair notification work again
Jan 6 2019, 12:11 PM
eduisters closed D17886: Make tapping on a pair notification work again.
Jan 6 2019, 12:11 PM · KDE Connect
eduisters committed R225:ebdc040ce594: Use ButterKnife for view binding (authored by eduisters).
Use ButterKnife for view binding
Jan 6 2019, 11:46 AM
eduisters closed D17878: Use ButterKnife for view binding.
Jan 6 2019, 11:46 AM · KDE Connect
eduisters committed R225:abba7f11328f: Do not continue displaying the previous track's album art image when the new… (authored by eduisters).
Do not continue displaying the previous track's album art image when the new…
Jan 6 2019, 11:45 AM
eduisters closed D17875: Do not continue displaying the previous track's album art image when the new track's albumArtUrl is empty.
Jan 6 2019, 11:45 AM · KDE Connect
eduisters committed R224:9f5cdf1a2177: Do not close m_socket in socketError() (authored by eduisters).
Do not close m_socket in socketError()
Jan 6 2019, 11:43 AM
eduisters closed D17628: Do not close m_socket in socketError().
Jan 6 2019, 11:43 AM · KDE Connect
eduisters removed a dependency for D17628: Do not close m_socket in socketError(): D16491: Allow shares from desktop to be canceled.
Jan 6 2019, 11:39 AM · KDE Connect
eduisters removed a dependent revision for D16491: Allow shares from desktop to be canceled: D17628: Do not close m_socket in socketError().
Jan 6 2019, 11:39 AM · KDE Connect
eduisters committed R225:9fb780f9197c: Migrate from PreferenceActivity to PreferenceFragment because it has been… (authored by eduisters).
Migrate from PreferenceActivity to PreferenceFragment because it has been…
Jan 6 2019, 11:37 AM
eduisters closed D17859: Migrate from PreferenceActivity to PreferenceFragment because it has been deprecated since Android 3.0 API11.
Jan 6 2019, 11:37 AM · KDE Connect

Jan 5 2019

eduisters added inline comments to D17859: Migrate from PreferenceActivity to PreferenceFragment because it has been deprecated since Android 3.0 API11.
Jan 5 2019, 7:13 PM · KDE Connect
eduisters added a comment to D17976: Fix file opening.

+1. (Weird though that DocumentFile.getType() returns something different than what it was created with)

Jan 5 2019, 6:47 AM · KDE Connect

Jan 2 2019

eduisters updated the diff for D17859: Migrate from PreferenceActivity to PreferenceFragment because it has been deprecated since Android 3.0 API11.
  • Improved state saving
Jan 2 2019, 10:52 AM · KDE Connect

Jan 1 2019

eduisters updated the diff for D17859: Migrate from PreferenceActivity to PreferenceFragment because it has been deprecated since Android 3.0 API11.
  • Fix NPE
Jan 1 2019, 5:30 PM · KDE Connect

Dec 31 2018

eduisters updated the diff for D17886: Make tapping on a pair notification work again.
  • Fixed NPE on orientation change
Dec 31 2018, 3:07 PM · KDE Connect