T8539 - Create a new flow to manage trusted networks
Needs ReviewPublic

Authored by nicolasfella on Jun 13 2018, 6:09 AM.

Details

Summary

I have created a new activity that allows you to trust all networks or add networks one by one to a list when you are connected to that network

Test Plan

Test Cases:

  1. By default everything should works like it works before, If you uncheck the "Allow all" option in trusted network menu and there isn't any ssid in the trusted

network list the app doesn't send the first udp package and log "Current WiFi isn't a Trusted Network"

  1. With the "Allow all" uncheck, use "Add: YOUR_SSID_NAME" button to add your current ssid to the trusted networks list, once you added, go back and the app should

works as always

1 -> https://youtu.be/ZpCEFTstbJI

2 -> https://youtu.be/cVB1LXlFVyk

Diff Detail

Repository
R225 KDE Connect - Android application
Branch
fixup
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 10021
Build 10039: arc lint + arc unit
jdvr created this revision.Jun 13 2018, 6:09 AM
Restricted Application added a project: KDE Connect. · View Herald TranscriptJun 13 2018, 6:09 AM
Restricted Application added a subscriber: kdeconnect. · View Herald Transcript
jdvr requested review of this revision.Jun 13 2018, 6:09 AM
apol added a subscriber: apol.Jul 26 2018, 5:37 PM

Showing screenshots of what you did would help to review the patch.

jdvr updated this revision to Diff 38557.Jul 27 2018, 7:18 AM
  • merge master
  • avoid process the received package when network is not trusted
jdvr edited the test plan for this revision. (Show Details)Jul 27 2018, 7:30 AM
jdvr edited the test plan for this revision. (Show Details)Jul 27 2018, 7:35 AM

Sorry for keeping you waiting so long.

There are a lot of changes here that shouldn't be here. Please re-upload only your changes.

It's working good, just a few cosmetic suggestions

res/values/strings.xml
324

networks

325

Remove the :

nicolasfella requested changes to this revision.Sep 16 2018, 8:50 PM
This revision now requires changes to proceed.Sep 16 2018, 8:50 PM
jdvr updated this revision to Diff 41919.Sep 18 2018, 9:19 PM
  • improve some text
jdvr updated this revision to Diff 41920.Sep 18 2018, 9:32 PM

Updating D13505: T8539 - Create a new flow to manage trusted networks

Now that we have a settings screen, this would fit there really well there.

I see the patch got messed up, though, can you rebase it and submit it again @jdvr?

jdvr added a comment.Dec 8 2018, 8:05 PM

Now that we have a settings screen, this would fit there really well there.

I see the patch got messed up, though, can you rebase it and submit it again @jdvr?

Sure, I'll try to do it next week.

Fixup and rebase

This approach has a problem: Beginning with Android 8.1 we need the ACCESS_COARSE_LOCATION permission to access the Wifi SSID. It's a bit weird to ask the user for that for this feature

nicolasfella commandeered this revision.Mar 23 2019, 5:57 PM
nicolasfella edited reviewers, added: jdvr; removed: nicolasfella.

@jdvr Are you still interested in working on this? We would need some flow to request the permission on newer Android versions. With the runtime permissions, it seems like it would make the most sense to ask for this as soon as the user brings up the settings panel for configuring trusted networks.