Hi, I'm new and I want to work on this.

Since, I'm new, can you help me out on how to go about this issue. It would be of immense help if you can mentor me a bit.

Does the deleting here refer to deleting for everyone or just deleting from the phone?

In T10650#239878, @cubix wrote:

Since, I'm new, can you help me out on how to go about this issue. It would be of immense help if you can mentor me a bit.

sure!

In T10650#239889, @cubix wrote:

Does the deleting here refer to deleting for everyone or just deleting from the phone?

Deleting from the phone as well as from the SMS App's cache on the desktop.

In T10650#239900, @aniketkumar wrote:

In T10650#239889, @cubix wrote:

Does the deleting here refer to deleting for everyone or just deleting from the phone?

Deleting from the phone as well as from the SMS App's cache on the desktop.

Specifically, the bug is that if you delete a message from the phone, it is *not* deleted from the desktop's cache, and then the desktop behaves strangely. I suspect this is because Android re-uses the IDs of the deleted messages.

In T10650#239878, @cubix wrote:

Since, I'm new, can you help me out on how to go about this issue. It would be of immense help if you can mentor me a bit.

You're welcome to ask anybody for help (I recommend you join us on Telegram), but I'll leave you in Aniket's capable hands for now. He probably knows the SMS stuff better than I do at this point anyway :)

My quick suggestion would be to study how we watch for *new* messages in the Android app, because I believe there is a similar way to watch for deleted messages.

Okay I will look into that. How do I find it in the codebase? I will also join on telegram shortly.

Also is this an issue of the desktop app or the android kde connect app?

In T10650#239972, @cubix wrote:

Also is this an issue of the desktop app or the android kde connect app?

Both the C++ and the Android implementations would need to have code added to handle deleted messages

In T10650#239971, @cubix wrote:

Okay I will look into that. How do I find it in the codebase? I will also join on telegram shortly.

You will want to start by looking at the SMS plugin both on the C++ side and the Android side. The "onPacketReceived" and "onCreate" methods in both are probably the most interesting places to start tracking through how the plugins work

Ok, I will go through that. Also on another note, I am bit confused about dbus and how/what its being used for. Can you give me some pointers?

I have set up the desktop source for kde connect. Can you tell me how to set up the android one? Can I do it in my phone or should i do it in an emulator.

In T10650#239975, @cubix wrote:

I have set up the desktop source for kde connect. Can you tell me how to set up the android one? Can I do it in my phone or should i do it in an emulator.

You can do it both ways! Setting up an emulator will require doing lots of configurations on your machine whereas running in android will be easier to setup. If you want to setup emulator for KDE Connect follow the guide given at this link KDEConnect Android Emulator

I went throught the smsplugin in the c++ and the java side.

private class MessageContentObserver extends ContentObserver {

        /**
         * Create a ContentObserver to watch the Messages database. onChange is called for
         * every subscribed change
         *
         * @param handler Handler object used to make the callback
         */
        MessageContentObserver(Handler handler) {
            super(handler);
        }

        /**
         * The onChange method is called whenever the subscribed-to database changes
         *
         * In this case, this onChange expects to be called whenever *anything* in the Messages
         * database changes and simply reports those updated messages to anyone who might be listening
         */
        @Override
        public void onChange(boolean selfChange) {
            // If the KDE Connect is set as default Sms app
            // prevent from reading the latest message in the database before the sentReceivers mark it as sent
            if (Utils.isDefaultSmsApp(context)) {
                return;
            }

            sendLatestMessage();
        }

    }

This is the code on the java side which sends the newest message. Should we create a change in this method so that it takes into consideration changes when messages are deleted as well? @aniketkumar

Can someone help me out on this?

With the help of this observer class, you have to figure out a way to get the threadID and uid of the deleted message and then just send this information to the desktop SMS App where the SMS App will look into its cache for the deleted message and will remove it from there and after that just update the UI of the SMS App.

Okay. Does Android apis have this kind of functionality? Like some function in android.telephony.smsmanager?

In T10650#240156, @cubix wrote:

Okay. Does Android apis have this kind of functionality? Like some function in android.telephony.smsmanager?

I'm not sure if android API provides us with such functionality :(

Alright. Are we supposed to refresh it then everytime? Or if the count of messages decreases - a workaround maybe?

In T10650#240171, @cubix wrote:

Alright. Are we supposed to refresh it then everytime? Or if the count of messages decreases - a workaround maybe?

Have you tried looking in the MessageContentObserver class above? Did that not get called when deleting a message?

We do not have all of the answers. Sometimes you can find an answer of StackOverflow for how to do things with SMS on Android but for the most part we're the only independent group going it. And there is essentially no documentation. A large amount of experimentation is going to be required!

Okay, I'll debug and check if it gets called!