Add NSIS Script for KDE Connect
AcceptedPublic

Authored by brute4s99 on Wed, Jun 5, 2:00 PM.

Details

Summary

added script for NSIS.
This can be a model blueprint for any other apps trying out the new KNotifications for Windows.

Test Plan

checkout this branch of knotifications in craft : https://phabricator.kde.org/source/knotifications/history/brute4s99%252Fsnore-ftw/

[CraftRoot\etc\blueprints\locations\craft-blueprints-kde]
apply this diff and : https://phabricator.kde.org/D21588

[CraftRoot\craft]
apply this diff to craft : https://phabricator.kde.org/D21615

do craft --package kdeconnect-kde

EXPECTED : The setup created will-

  • install shortcut in Start Menu via SnoreToast,
  • create shortcut on Desktop for launching KDE Connect.

Diff Detail

Repository
R877 Craft Blueprints for KDE
Branch
arcpatch-D21602
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 12534
Build 12552: arc lint + arc unit
brute4s99 requested review of this revision.Wed, Jun 5, 2:00 PM
brute4s99 created this revision.

The only thing I immediately see as a problem is the uninstaller doesn't have the proper branding (generic icons), and it didn't uninstall the desktop shortcut

we don't provide an option for custome uninstall icons and using the app icon would be confusing.

maybe we should introduce un_sections to remove the shortcuts?

extragear/kdeconnect-kde/kdeconnect-kde.py
33

no need to set, default is display name

34

just leave it to the default

brute4s99 edited the test plan for this revision. (Show Details)Wed, Jun 5, 7:46 PM
brute4s99 edited the test plan for this revision. (Show Details)Wed, Jun 5, 10:05 PM
brute4s99 updated this revision to Diff 59235.Wed, Jun 5, 10:14 PM

the new diff has correct shortcut installations and removals upon un-installation. be sure to update craft by

craft craft

before testing :)

brute4s99 updated this revision to Diff 59239.Wed, Jun 5, 10:56 PM
vonreth added inline comments.Thu, Jun 6, 10:21 AM
extragear/kdeconnect-kde/kdeconnect-kde.py
61

This one is wrong, see the condition above, I guess we need to update the snorensis script to use the correct context instead

vonreth added inline comments.Thu, Jun 6, 10:24 AM
extragear/kdeconnect-kde/kdeconnect-kde.py
61

Wrong, snoretoast needs to allow absolute paths to install, so that the shortcut is installed correctly for all users

brute4s99 updated this revision to Diff 59272.Thu, Jun 6, 5:13 PM

SnoreToast supports absolute path now!

brute4s99 updated this revision to Diff 59353.Fri, Jun 7, 5:54 PM
brute4s99 edited the summary of this revision. (Show Details)

removed context-based shortcut handing

vonreth accepted this revision.Fri, Jun 7, 6:33 PM
This revision is now accepted and ready to land.Fri, Jun 7, 6:33 PM
sredman accepted this revision.Sat, Jun 8, 2:59 AM