This task is just mainly so I don't completely forget about this

Thanks for checking. Closing it here.

It looks like this has landed, so closing. Please speak up if you disagree.

this is already on gitlab: https://invent.kde.org/education/marble/-/merge_requests/48/diffs

Unfortunately this did not land.
Could someone please put this on Gitlab for another review and then close it here?

Moved to https://invent.kde.org/education/kalzium/-/merge_requests/10

A few MR moving in this direction:

Looks great!

Accepted to close it, not applied

For consistency, as we already always limit the number of boys/girls to place according to the numbers in the instructions, it would be logical to do the same for the number of candies.
So, unless others disagree, I think we don't really want this behavior, and it can be changed.

I checked the code and now I can say it is intended because of line 305 in Share.qml

total: background.easyMode ? items.totalCandies : 8 * items.totalChildren + 1

In D29850#675738, @shubhammishra wrote:

Hi,

The "showCount" in datasets and "show counter" option in config behaves differently. When we disable counter from config, "totalCandies" becomes invalid and it is possible to drag unlimited candies that also means candies never become unavailable. I thought it was intended not a bug so didn't raise this before.

The "showCount" in datasets and "show counter" option in config behaves differently. When we disable counter from config, "totalCandies" becomes invalid and it is possible to drag unlimited candies that also means candies never become unavailable. I thought it was intended not a bug so didn't raise this before.

I confirm my first idea from previous comment: better keep the "show counter" as an Option, and not part of the datasets.

No problem, that's the goal of a review :).

@Supermanu Hi, Please update your diff and add the reviewers.

In D29850#675489, @jjazeix wrote:

We have 2 conflicting options for the "show counter"... If we set it on the configuration, I would expect to always have it but on some level, we have an attribute: "showCount" which overrides the configuration option. @timotheegiet, @echarruau I think it was already previously the case but it may be better to find a better wording of the option if we want to keep this behaviour?

waiting for @timotheegiet to validate the diff so we can close it. Once done, @shubhammishra please close the diff and the related tasks.

We have 2 conflicting options for the "show counter"... If we set it on the configuration, I would expect to always have it but on some level, we have an attribute: "showCount" which overrides the configuration option. @timotheegiet, @echarruau I think it was already previously the case but it may be better to find a better wording of the option if we want to keep this behaviour?

• share, added missing full stop in instructions

Played it extensively. Could not break and I find the new dataset messages much clearer.
Good for me.

Good for me. Please double check all the missing dots at the end of the sentences

• share, made dataset description shorter

Patch merged in commit 42142a0ce8b441916987f6be8463e73244ecdb93 ,
and then improved upon it in next commit 7433227a9f89d6c47ad94e515197e4d95dacaaed

@timotheegiet I have updated the difficulty levels.

updated difficulty levels

In D29853#675400, @timotheegiet wrote:

As explained in the task comments: change the number of stars for the datasets.

As explained in the task comments: change the number of stars for the datasets.

For the datasets descriptions, I think it would be more efficient to make it shorter and to the point, something like:
"Maximum n candies and n kids, no rest.", "Maximum n candies and n kids, possible rest.".... (replacing n with the actual values of course)

• updated dataset objectives

.

test

• share, fixed instructions, remove boys from first sublevel of each level

Hi, Sorry I think our same names lead to this confusion.

I do not know why i was subscribed.

"Paul wants to equally share 2 pieces of candy between 2 of his friends: one girl and one boy." -> is there any addition of knowing there is a boy and a girl?

More globally, do we need to specify how many children are girls or boys?
"Paul wants to equally share 2 pieces of candy between 2 of his friends: one girl and one boy." -> is there any addition of knowing there is a boy and a girl?

Merged, thank you!

• share, made no. of candies in instruction uniform for randomised and non randomised levels

• share, Increased left widget width bit because of double digit numbers

@echarruau I have completed the sheet. Please review it :)

In D29849#675029, @echarruau wrote:

I made some changes to your new table
https://lite.framacalc.org/9h54-memory-games-testing
Once again you just answer by yes/no that does not help me at all. So I modified the columns titles in a way that forces you to tell what you are doing.
Please complete it.

I made some changes to your new table
https://lite.framacalc.org/9h54-memory-games-testing
Once again you just answer by yes/no that does not help me at all. So I modified the columns titles in a way that forces you to tell what you are doing.
Please complete it.

Sure, works fine for me, just a thought I had :)

As Timothée just said I would also prefer to keep them separated in datasets provided by default.
Symbols are more aimed at children or beginners as number is more for advanced users.
The actual code is now perfectly generic and numbers are in fact symbols.

In D29839#675004, @AkshayCHD wrote:

Ran through all the datasets, looks good to go, just one thing can we add a third level in dataset 3, which contains both symbols and numbers. Currently all levels either contain symbols or numbers, which may lead to someone thinking that he can use only one of them at a time in a sublevel, which is not the case actually.

Ran through all the datasets, looks good to go, just one thing can we add a third level in dataset 3, which contains both symbols and numbers. Currently all levels either contain symbols or numbers, which may lead to someone thinking that he can use only one of them at a time in a sublevel, which is not the case actually.

@jjazeix I have fixed that regressions and pushed it to my branch gsoc_deepak_memory_games. Please check it once if it's all good now.
Link to the commit: https://invent.kde.org/education/gcompris/-/commit/5f8ea8ff0ffece3261b900df167e698e1cbb5f56

All tested, looks good to merge.

Hi,
Maybe because you use a diff that you commit? No idea on my side but
could you ask Timothée or Johnny to kbao why? What is sure is that I
don't see it.

@johnny: I tested it by using it, nothing has been broken, working fine on my side.

@jjazeix : I'll test tomorrow.

If you don't have more changes to do on this activity, this is good for me.
@AkshayCHD, @echarruau, @timotheegiet : do you plan on testing? If yes, I'll wait before merging else I'll merge it when I have time (next week)

In D29482#674938, @joscott wrote:

What's the full path of OpenBabel3Config.cmake and its second line ("get_filename_component") on Debian?

I was so focused on the linker errors I overlooked that. It's installed at /usr/lib/x86_64-linux-gnu/cmake/openbabel3/OpenBabel3Config.cmake. Here is its full content (on the second/third lines that's actually a hard line break, not a wrap).

What's the full path of OpenBabel3Config.cmake and its second line ("get_filename_component") on Debian?

In D29482#674935, @joscott wrote:

I tried using this patch to build Kalzium on Debian but got some errors:

I tried using this patch to build Kalzium on Debian but got some errors:

In D29840#674920, @echarruau wrote:

Changes are ok.
I would still need to see the process test table where you will document how you do the tests to be sure that you are not breaking any of the other memory activity.

Code looks good to me, I will need to test it more later.
Thank you

Changes are ok.
I would still need to see the process test table where you will document how you do the tests to be sure that you are not breaking any of the other memory activity.

Working like a charm.
Once you will have made it tested by your "test group" as stated in the timeline it will certainly be ready.
Nice and clean job!

• sudoku, removed 'extention' attribute from symbols