Details
- Reviewers
timotheegiet - Group Reviewers
GCompris: Improvements - Maniphest Tasks
- T8494: Simple paint activity, implement keyboard controls
Diff Detail
- Lint
Lint Skipped - Unit
Unit Tests Skipped
Thank you for the PR, I did some comments
src/activities/simplepaint/PaintCursor.qml | ||
---|---|---|
1 ↗ | (On Diff #46494) | update the filename |
src/activities/simplepaint/Simplepaint.qml | ||
44 ↗ | (On Diff #46494) | the coding rules incites to add a space before the { |
48 ↗ | (On Diff #46494) | can you add spaces before and after '='? |
99 ↗ | (On Diff #46494) | isColorTab = !isColorTab |
146 ↗ | (On Diff #46494) | use an "int" if you already know the type. var is slower |
349 ↗ | (On Diff #46494) | I think you can directly put the background.refreshCursor() in the initLevel(). |
src/activities/simplepaint/Simplepaint.qml | ||
---|---|---|
163 ↗ | (On Diff #46494) | can you clean up the log, it's not needed when we release |
Good for me. Please push it and I'll update the icon with a new one more appropriate.
Patch merged in commit 42142a0ce8b441916987f6be8463e73244ecdb93 ,
and then improved upon it in next commit 7433227a9f89d6c47ad94e515197e4d95dacaaed