Avoid the need to set Qt::WA_DeleteOnClose on widgets using Marble
ClosedPublic

Authored by jhasse on Nov 27 2020, 2:25 PM.

Details

Reviewers
rahn
Summary

I've noticed that when using MarbleWidget in my app, closing the top level widget will no longer quit the QApplication. This is because the PopupLayer is still alive and has Qt::WA_QuitOnClose set, but is never closed.

When unsetting it, MarbleWidget can be used in a window without having to set Qt::WA_DeleteOnClose. This allows the window to be created on the stack - also how it's done in Qt's examples: https://doc.qt.io/qt-5/qtwidgets-mainwindows-application-example.html

Diff Detail

Repository
R34 Marble
Lint
Lint Skipped
Unit
Unit Tests Skipped
jhasse created this revision.Nov 27 2020, 2:25 PM
Restricted Application added projects: Marble, KDE Edu. · View Herald TranscriptNov 27 2020, 2:25 PM
Restricted Application added subscribers: kde-edu, marble-devel. · View Herald Transcript
jhasse requested review of this revision.Nov 27 2020, 2:25 PM
rahn accepted this revision.Nov 28 2020, 2:32 PM
rahn added a subscriber: rahn.

Looks great!

This revision is now accepted and ready to land.Nov 28 2020, 2:32 PM

Unfortunately this did not land.
Could someone please put this on Gitlab for another review and then close it here?

Thanks.

this is already on gitlab: https://invent.kde.org/education/marble/-/merge_requests/48/diffs

As it was accepted here, I'm accepting it on gitlab too

schwarzer closed this revision.May 22 2021, 12:12 PM

Thanks for checking. Closing it here.