Code ready for review.
Details
Details
Diff Detail
Diff Detail
- Repository
- R2 GCompris
- Lint
Lint Skipped - Unit
Unit Tests Skipped
| src/activities/drawing/ActivityInfo.qml | ||
|---|---|---|
| 3 | add your name here | |
| 26 | you need to complete the whole file here | |
| src/activities/drawing/ColorDialogue.qml | ||
| 1 | should be named ColorDialog.qml | |
| 44 | color, you can use the full name for the variable instead of abbrevations | |
| src/activities/drawing/Drawing.qml | ||
| 112 | you can probably find a way to have only one SaveToFilePrompt used | |
| 155 | string? | |
| 392 | real? | |
| 877 | "enabled ? 1 : 0"? | |
| 894 | "enabled ? 1 : 0"? | |
| src/activities/drawing/FoldablePanels.qml | ||
| 107 | qsTr() | |
| 117 | can you factorise it on a separate file? All the tabs should have more or less the same behaviour? | |
| 148 | qsTr() | |
| 413 | go to the line | |
| src/activities/drawing/LoadDrawings.qml | ||
| 29 | indentation | |
| 44 | go to the line | |
| src/activities/drawing/TextInputTool.qml | ||
| 1 | TextInputTool.qml | |
| 24 | not sure you need all the import on all files | |
| src/activities/drawing/drawing.js | ||
| 45 | not a good variable name | |