schwarzer (Frederik Schwarzer)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Monday

  • Clear sailing ahead.

User Details

User Since
Mar 15 2016, 5:18 PM (96 w, 3 d)
Availability
Available

Recent Activity

Wed, Jan 17

schwarzer committed R883:1508914: Translation fix: remove extra colon.
Translation fix: remove extra colon
Wed, Jan 17, 7:44 PM
schwarzer committed R883:1508913: Translation fix: remove extra colon.
Translation fix: remove extra colon
Wed, Jan 17, 7:43 PM

Sun, Jan 14

schwarzer committed R412:a319eca9f2bf: Show error message to the user (authored by schwarzer).
Show error message to the user
Sun, Jan 14, 10:40 PM
schwarzer closed D9805: Show error message to the user.
Sun, Jan 14, 10:40 PM · KDE Games

Thu, Jan 11

schwarzer updated the diff for D9805: Show error message to the user.
Thu, Jan 11, 6:51 PM · KDE Games
schwarzer updated the diff for D9805: Show error message to the user.
Thu, Jan 11, 6:49 PM · KDE Games

Wed, Jan 10

schwarzer added a comment to D9805: Show error message to the user.
In D9805#189154, @aacid wrote:

I just realzied this is not how you use QMEsasgebox critical.

Since it's static you just do QMessageBox::critical(...)

Wed, Jan 10, 11:35 PM · KDE Games
schwarzer updated the diff for D9805: Show error message to the user.

fix diff ... hopefully

Wed, Jan 10, 10:10 PM · KDE Games
schwarzer added a comment to D9805: Show error message to the user.
In D9805#189130, @aacid wrote:

Is phabricator being silly or are your patches missing some stuff?

Like it says
...\nPlease install the
and ends there

Wed, Jan 10, 10:09 PM · KDE Games
schwarzer added a comment to D9790: Fix slowdown issue.

Do you mean switching the interval/substeps/speed? Or switching from a change in timer interval to the substeps?

I'll try to explain:

  1. Why change the interval? The basic loop is: Move ball -> Check for collisions -> Change direction, perform actions, according to collisions, etc. -> Move ball -> ... The speed determines how far the ball is moved during the "Move ball". If the ball is moved too far, the collision detection might be inaccurate (E.g. the extreme case is the ball moving through a brick with no detected collision). To avoid such bugs, we move the ball only half the distance, but twice as often.
  2. Why use substeps now? In the original code, this was done by cutting the gameTimer interval in half. However, this broke during the port to QML, because QML timer have a minimum interval of 16ms. Cutting it in half to 8ms does not have any effect. The alternative approach is to keep the gameTimer interval, but perform the basic loop twice.
Wed, Jan 10, 9:39 PM · KDE Games
schwarzer committed R412:7843cfcd0e7c: Be more correct in error messages (authored by schwarzer).
Be more correct in error messages
Wed, Jan 10, 9:01 PM
schwarzer committed R412:efe66b9b3751: Only return true if loading suceeded (authored by schwarzer).
Only return true if loading suceeded
Wed, Jan 10, 9:01 PM
schwarzer added a comment to D9790: Fix slowdown issue.

OK, tested it and it works as in the ball does not slow down anymore.
I cannot really argue about the implementation because I did not understand why this switching is needed in the first place. :D

Wed, Jan 10, 5:52 PM · KDE Games
schwarzer added a comment to D9790: Fix slowdown issue.

Thanks for picking up the topic with a patch. :)
I might be able to test this tonight but not sure.
Anyway, here are just some things I saw while scrolling over the patch.

Wed, Jan 10, 12:58 PM · KDE Games

Sat, Jan 6

schwarzer added inline comments to D9702: Aktualisierung der Doku-Übersetzung für KBackup.
Sat, Jan 6, 9:18 PM
schwarzer added a comment to D9694: Korrektur des GUI-Katalogs für kbackup.

Nur ein paar Sachen, die mir beim Drüberfliegen aufgefallen sind.
Ein paar sind schlicht Geschmacksfragen, also im Zweifel ignorieren. ;)

Sat, Jan 6, 12:51 PM

Wed, Jan 3

schwarzer added a comment to D9570: Make XMLUI file validate agaist XSD.
In D9570#184689, @aacid wrote:

This is not really needed, i.e. the xsd is not really accurate of what the code expects since this gets merged with the default rc file we will already have a menubar.

If you feel strongly about having the file validate, sure commit it, otherwise it's not really worth it in my opinion.

Wed, Jan 3, 7:29 PM

Tue, Jan 2

schwarzer added inline comments to D9358: latte-dock update.
Tue, Jan 2, 4:20 PM

Sat, Dec 30

schwarzer updated the test plan for D9570: Make XMLUI file validate agaist XSD.
Sat, Dec 30, 8:25 PM

Thu, Dec 28

schwarzer added a comment to D9525: Update action state properly after undo/redo.

Looks good to me.

Thu, Dec 28, 12:37 AM

Nov 6 2017

schwarzer moved T7126: Establish KDE Technologies (Plasma, Applications, Frameworks) as the top choice for Smart Homes from ready for voting to ready for discussion on the Goal settings 2017 board.
Nov 6 2017, 4:52 PM · Goal settings 2017
schwarzer moved T6838: Modern and Global Text Input For Every User (Input Methods, Emoji, Touch, ...) from ready for voting to ready for discussion on the Goal settings 2017 board.
Nov 6 2017, 4:52 PM · Goal settings 2017
schwarzer moved T7116: Streamlined onboarding of new contributors from ready for voting to ready for discussion on the Goal settings 2017 board.
Nov 6 2017, 4:52 PM · Goal settings 2017
schwarzer moved T7050: Privacy Software from ready for voting to ready for discussion on the Goal settings 2017 board.
Nov 6 2017, 4:52 PM · Goal settings 2017
schwarzer moved T6895: Making KDE software the #1 choice for research and academia from ready for voting to ready for discussion on the Goal settings 2017 board.
Nov 6 2017, 4:52 PM · Goal settings 2017
schwarzer moved T6878: Improve the Plasma Mobile platform for end-user needs from ready for voting to ready for discussion on the Goal settings 2017 board.
Nov 6 2017, 4:52 PM · Goal settings 2017
schwarzer moved T7126: Establish KDE Technologies (Plasma, Applications, Frameworks) as the top choice for Smart Homes from ready for discussion to ready for voting on the Goal settings 2017 board.
Nov 6 2017, 4:49 PM · Goal settings 2017
schwarzer moved T7116: Streamlined onboarding of new contributors from ready for discussion to ready for voting on the Goal settings 2017 board.
Nov 6 2017, 4:47 PM · Goal settings 2017
schwarzer moved T6878: Improve the Plasma Mobile platform for end-user needs from ready for discussion to ready for voting on the Goal settings 2017 board.
Nov 6 2017, 4:47 PM · Goal settings 2017
schwarzer moved T6838: Modern and Global Text Input For Every User (Input Methods, Emoji, Touch, ...) from ready for discussion to ready for voting on the Goal settings 2017 board.
Nov 6 2017, 4:47 PM · Goal settings 2017
schwarzer moved T7050: Privacy Software from ready for discussion to ready for voting on the Goal settings 2017 board.
Nov 6 2017, 4:47 PM · Goal settings 2017
schwarzer moved T6895: Making KDE software the #1 choice for research and academia from ready for discussion to ready for voting on the Goal settings 2017 board.
Nov 6 2017, 4:47 PM · Goal settings 2017

Oct 29 2017

schwarzer committed R883:1501967: Fix typo.
Fix typo
Oct 29 2017, 12:45 AM

Sep 22 2017

schwarzer updated the task description for T7050: Privacy Software.
Sep 22 2017, 1:22 PM · Goal settings 2017

Aug 8 2017

schwarzer committed R32:e929ed6900a9: Sync wording to related messages. (authored by schwarzer).
Sync wording to related messages.
Aug 8 2017, 4:57 PM
schwarzer committed R32:1c68314910d2: Fix typo. (authored by schwarzer).
Fix typo.
Aug 8 2017, 4:12 PM
schwarzer committed R32:c1335b3cb80b: Fix missing colon (authored by schwarzer).
Fix missing colon
Aug 8 2017, 4:10 PM
schwarzer committed R32:07a14bb6d5d0: fix markup that breaks translations (authored by schwarzer).
fix markup that breaks translations
Aug 8 2017, 4:04 PM
schwarzer committed R32:2a12ef8deb64: fix markup that breaks translations (authored by schwarzer).
fix markup that breaks translations
Aug 8 2017, 4:04 PM
schwarzer committed R32:1d3c5dbb37b9: fix non-breaking space surrounded by usual spaces (authored by schwarzer).
fix non-breaking space surrounded by usual spaces
Aug 8 2017, 4:04 PM
schwarzer committed R32:c9198b8fe2b6: fixuifiles (authored by schwarzer).
fixuifiles
Aug 8 2017, 3:59 PM
schwarzer committed R32:817e7c6d7f39: change layout of the Project configure dialog page (authored by schwarzer).
change layout of the Project configure dialog page
Aug 8 2017, 3:59 PM
schwarzer committed R32:89aad43e7b58: missing colon (authored by schwarzer).
missing colon
Aug 8 2017, 3:59 PM
schwarzer committed R32:e73bb6f011b1: typo (authored by schwarzer).
typo
Aug 8 2017, 3:27 PM
schwarzer committed R32:2803378a09ae: warnings-- (authored by schwarzer).
warnings--
Aug 8 2017, 3:26 PM
schwarzer committed R32:193e8936b439: fix former placeholder commit *coughs* (authored by schwarzer).
fix former placeholder commit *coughs*
Aug 8 2017, 3:26 PM
schwarzer committed R32:f0fcc03d2eda: typos and grammar fixes (authored by schwarzer).
typos and grammar fixes
Aug 8 2017, 3:26 PM
schwarzer committed R32:5c4c77cf36c0: mark placeholders so they are not extracted for translation (authored by schwarzer).
mark placeholders so they are not extracted for translation
Aug 8 2017, 3:26 PM
schwarzer committed R32:5304786bd40b: dashed git commands are deprecated (authored by schwarzer).
dashed git commands are deprecated
Aug 8 2017, 3:26 PM
schwarzer committed R32:4cd94906bfe4: global typo fix (authored by schwarzer).
global typo fix
Aug 8 2017, 3:23 PM
schwarzer committed R32:3d4070051b29: typo: ist -> is (authored by schwarzer).
typo: ist -> is
Aug 8 2017, 3:22 PM
schwarzer committed R32:92efec169e3c: typo: "information" has no plural (authored by schwarzer).
typo: "information" has no plural
Aug 8 2017, 3:22 PM
schwarzer committed R32:82e94be88944: hide placeholder strings from translators (authored by schwarzer).
hide placeholder strings from translators
Aug 8 2017, 3:19 PM
schwarzer committed R32:c6e8248c9693: remove placeholder texts from ui files (authored by schwarzer).
remove placeholder texts from ui files
Aug 8 2017, 3:19 PM
schwarzer committed R32:92af347ebcd8: typos (authored by schwarzer).
typos
Aug 8 2017, 3:14 PM
schwarzer committed R32:43cf5552e031: global typo (authored by schwarzer).
global typo
Aug 8 2017, 3:14 PM
schwarzer committed R32:1744c018cf95: typo singal -> signal (authored by schwarzer).
typo singal -> signal
Aug 8 2017, 3:13 PM
schwarzer committed R32:fdc853e12987: let me introduce: typo of the year "the the" (authored by schwarzer).
let me introduce: typo of the year "the the"
Aug 8 2017, 3:13 PM

Jun 23 2017

schwarzer accepted D5668: Fix the position of the initial popup message.

Sorry, forgot about this one. Thanks for taking action here. :)

Jun 23 2017, 6:19 AM

May 3 2017

schwarzer requested changes to D5668: Fix the position of the initial popup message.

As discussed on IRC, there will be some changes in a future revision...

May 3 2017, 4:39 PM
schwarzer added a comment to D5668: Fix the position of the initial popup message.

After reading https://medium.com/genymobile/how-c-lambda-expressions-can-improve-your-qt-code-8cd524f4ed9f I get the impression that capturing this is common practice.

May 3 2017, 3:57 PM
schwarzer added a comment to D5668: Fix the position of the initial popup message.

OK. :D
I am not very familiar with labdas either and was just wondering. It works well here with =, & and this but I do not know the best practices in this case.

May 3 2017, 3:20 PM
schwarzer added a comment to D5668: Fix the position of the initial popup message.

Just out of curiosity. Why do you pass by value?

May 3 2017, 3:11 PM
schwarzer accepted D5668: Fix the position of the initial popup message.

Although I do not like those "just delay it a bit and it will work" solutions that much, I also think it's a valid workaround here. :)

May 3 2017, 3:01 PM

Apr 25 2017

schwarzer added a comment to D5571: Port statusbar to QStatusBar.

I don't know of any advantage/disadvantage... I can convert it to pointers if you want. Just an example I had was with objects and the code is one line shorter...

Apr 25 2017, 1:27 PM

Apr 24 2017

schwarzer added a comment to D5571: Port statusbar to QStatusBar.

Thanks, looks good to me.
Just curious. Is there (dis)advantages of using the QLabel as pointer vs. value here? I see is used as pointer in other games and used it like that as well.

Apr 24 2017, 5:54 PM
schwarzer added inline comments to D5571: Port statusbar to QStatusBar.
Apr 24 2017, 5:39 PM

Apr 19 2017

schwarzer committed R397:e24d189776cb: Use midRef() for efficiency reasons (authored by schwarzer).
Use midRef() for efficiency reasons
Apr 19 2017, 1:23 PM

Sep 10 2016

schwarzer committed R172:a0ba92a130d6: fix translation hint (authored by schwarzer).
fix translation hint
Sep 10 2016, 6:39 AM
schwarzer committed R173:a0ba92a130d6: fix translation hint (authored by schwarzer).
fix translation hint
Sep 10 2016, 6:33 AM
schwarzer committed R172:70eeef7c6e39: global typo fix (authored by schwarzer).
global typo fix
Sep 10 2016, 6:18 AM
schwarzer committed R172:a6bfe3cfd541: typo (authored by schwarzer).
typo
Sep 10 2016, 6:17 AM
schwarzer committed R172:2abb4ef6eba4: typo: "information" has no plural (authored by schwarzer).
typo: "information" has no plural
Sep 10 2016, 6:17 AM
schwarzer committed R172:fe722290c90c: hide placeholder strings from translators (authored by schwarzer).
hide placeholder strings from translators
Sep 10 2016, 6:16 AM
schwarzer committed R172:54042374716c: remove placeholder texts from ui files (authored by schwarzer).
remove placeholder texts from ui files
Sep 10 2016, 6:16 AM
schwarzer committed R172:1bb70f0a3d57: typo (missing full stop) (authored by schwarzer).
typo (missing full stop)
Sep 10 2016, 6:15 AM
schwarzer committed R172:c99b5b4fc460: typo (authored by schwarzer).
typo
Sep 10 2016, 6:15 AM
schwarzer committed R172:a92aed78d0fa: global typo (authored by schwarzer).
global typo
Sep 10 2016, 6:14 AM
schwarzer committed R172:1b2fd8f672cc: typos (authored by schwarzer).
typos
Sep 10 2016, 6:14 AM
schwarzer committed R172:fd12bb09ec7a: let me introduce: typo of the year "the the" (authored by schwarzer).
let me introduce: typo of the year "the the"
Sep 10 2016, 6:14 AM
schwarzer committed R108:6f33411bf447: String casing fixes. (authored by schwarzer).
String casing fixes.
Sep 10 2016, 6:14 AM
schwarzer committed R108:974d5cf98c61: Replace exclamation marks. (authored by schwarzer).
Replace exclamation marks.
Sep 10 2016, 6:11 AM
schwarzer committed R172:553b4cdb5e45: typo (authored by schwarzer).
typo
Sep 10 2016, 6:10 AM
schwarzer committed R173:70eeef7c6e39: global typo fix (authored by schwarzer).
global typo fix
Sep 10 2016, 6:08 AM
schwarzer committed R173:a6bfe3cfd541: typo (authored by schwarzer).
typo
Sep 10 2016, 6:07 AM
schwarzer committed R173:2abb4ef6eba4: typo: "information" has no plural (authored by schwarzer).
typo: "information" has no plural
Sep 10 2016, 6:07 AM
schwarzer committed R173:fe722290c90c: hide placeholder strings from translators (authored by schwarzer).
hide placeholder strings from translators
Sep 10 2016, 6:06 AM
schwarzer committed R173:54042374716c: remove placeholder texts from ui files (authored by schwarzer).
remove placeholder texts from ui files
Sep 10 2016, 6:06 AM
schwarzer committed R173:1bb70f0a3d57: typo (missing full stop) (authored by schwarzer).
typo (missing full stop)
Sep 10 2016, 6:05 AM
schwarzer committed R173:c99b5b4fc460: typo (authored by schwarzer).
typo
Sep 10 2016, 6:05 AM
schwarzer committed R173:1b2fd8f672cc: typos (authored by schwarzer).
typos
Sep 10 2016, 6:04 AM
schwarzer committed R173:a92aed78d0fa: global typo (authored by schwarzer).
global typo
Sep 10 2016, 6:04 AM
schwarzer committed R173:fd12bb09ec7a: let me introduce: typo of the year "the the" (authored by schwarzer).
let me introduce: typo of the year "the the"
Sep 10 2016, 6:04 AM
schwarzer committed R108:7f243a75c4dc: remove full stop: non of the other kcm comments has one (authored by schwarzer).
remove full stop: non of the other kcm comments has one
Sep 10 2016, 6:00 AM
schwarzer committed R173:553b4cdb5e45: typo (authored by schwarzer).
typo
Sep 10 2016, 6:00 AM
schwarzer committed R108:e69826ab5383: global typo fix (authored by schwarzer).
global typo fix
Sep 10 2016, 5:47 AM
schwarzer committed R108:206bb6f55b3f: Merge branch 'typos' (authored by schwarzer).
Merge branch 'typos'
Sep 10 2016, 5:44 AM
schwarzer committed R106:f661d893fda5: typos (authored by schwarzer).
typos
Sep 10 2016, 3:23 AM

Jun 9 2016

schwarzer committed R81:8da9e0e3977a: Typo. (authored by schwarzer).
Typo.
Jun 9 2016, 9:40 PM
schwarzer committed R7:ea3acd522d15: Fix typo. (authored by schwarzer).
Fix typo.
Jun 9 2016, 8:51 PM