gnumch activities, init level after bonus fades out
ClosedPublic

Authored by Supermanu on Sun, Jun 21, 10:54 AM.

Details

Reviewers
jjazeix
Group Reviewers
GCompris
Summary

Reorder how a level ends (bonus, monsters and next level initialization).

Before this revision, directly after eating the last operation, the next level was generated while the bonus was showing up.
Now, the monsters are stopped and the bonus is shown simultaneously. And only after the bonus is fading away, the next level is generated.

Diff Detail

Repository
R2 GCompris
Lint
Lint Skipped
Unit
Unit Tests Skipped
Supermanu created this revision.Sun, Jun 21, 10:54 AM
Restricted Application added a project: KDE Edu. · View Herald TranscriptSun, Jun 21, 10:54 AM
Restricted Application added a subscriber: kde-edu. · View Herald Transcript
Supermanu requested review of this revision.Sun, Jun 21, 10:54 AM
dekumar added a subscriber: dekumar.EditedSun, Jun 21, 11:25 AM

@Supermanu Hi, Please update your diff and add the reviewers.

Thanks!
Deepak

jjazeix added inline comments.
src/activities/gnumch-equality/Gnumch.qml
85

shouldn't it be timerActivateWarn.stop(); ?
If yes, I'm updating it, no need to update the diff

Supermanu added inline comments.Sun, Jun 21, 1:17 PM
src/activities/gnumch-equality/Gnumch.qml
85

Yes, it is. Sorry for this silly mistake.

jjazeix accepted this revision.Sun, Jun 21, 1:18 PM
This revision is now accepted and ready to land.Sun, Jun 21, 1:18 PM