- User Since
- Dec 30 2014, 5:43 PM (250 w, 6 d)
Tue, Oct 15
Can you add a unit test for the ApplicationSettings changes?
I did one new comment in https://phabricator.kde.org/R2:d3224edb5edc6f21dab3880351e11683f9e60a99
At some places, can you take a look if you can use algorithms instead of while/for loops (using filter for example if it works to do the difference between filtered music and all music)?
@dekumar I can't test but it seems there is also a package qml-module-qtsensors, can you check if installing it solves your issue?
Wed, Oct 9
Tue, Oct 8
Sun, Oct 6
Hi, thanks for the update. The design needs to be improved: we should not use a button to display the actual music (except if you plan to use it to select the playable pieces of music (point 3)). We'll also need to clean up the filenames so we have something understandable displayed.
Fri, Sep 27
Sep 17 2019
Sep 9 2019
Sep 6 2019
I just tested and the file was not saved, but it should already be present: https://cgit.kde.org/gcompris.git/tree/android/AndroidManifest.xml.cmake#n36
Sep 5 2019
Sep 4 2019
Sep 1 2019
Commited in https://commits.kde.org/gcompris/57985fcaf8191860eca3648f34d1919b8b450d42, thank you!
Aug 31 2019
I have this warning when starting alphabet-sequence: qrc:/gcompris/src/activities/planegame/planegame.js:81: TypeError: Cannot read property 'bar' of undefined
Except this, it is good for me
I did two really small comments.
It misses the configuration in activity to be able to change the dataset directly.
Except this, it's good and ready to be merged when done, thank you!
Aug 30 2019
Aug 29 2019
Aug 25 2019
Aug 20 2019
It's pushed on master and works fine: https://build.kde.org/job/Applications/job/kajongg/
Should I cherry-pick it to stable branch?
I can't close the revision too (maybe missing an approval?)
Aug 19 2019
Cool :), j'ai juste fait quelques remarques de typo, je ne suis pas à même d'installer et tester :). Bon courage !
Replace spaces by underscores
Use relative filename instead of just filename to avoid duplicates target name rules
Aug 17 2019
This one should also fix https://bugs.kde.org/show_bug.cgi?id=376303
No need to have a full path one the rule name, it's not used elsewhere.
Aug 14 2019
Aug 13 2019
Aug 10 2019
Aug 9 2019
Aug 8 2019
pushed in https://commits.kde.org/gcompris/160543e4075a7765609c1f819c3a25c60f58745a
For me, there is no pedagogic usefulness to finding words in the good order in alphabetical_order: the child does not see all the words at start so it's just going on all the words expecting it's the first one to find (especially when showNext is false).
I think we should think on how to improve the pedagogic side of these activities instead of adding dataset (but not on the scope of this gsoc)...
Aug 7 2019
last MR to be pushed: https://gitlab.com/fdroid/fdroiddata/merge_requests/5129 but GCompris is already in the store now
Aug 3 2019
Thank you, it's merged in commits https://cgit.kde.org/gcompris.git/commit/?h=multiple_dataset&id=199814b94aa2f637dbe74172d480f8c406184e6c and https://cgit.kde.org/gcompris.git/commit/?h=multiple_dataset&id=d48f35b2b149ffb4a69ab3c301173d4fca0a7187
Jul 31 2019
Jul 29 2019
Jul 28 2019
Jul 17 2019
Jul 14 2019
Jul 7 2019
@AkshayCHD I was trying to merge it on the multiple_dataset branch but I see wordsgame activity does not have the configuration, can you update it? It is a derivate of gletters
Jul 2 2019
Jun 30 2019
According to https://forum.qt.io/topic/66783/textfield-and-keyboard-on-android, it seems the android keyboard pops up if we call forceActiveFocus.
I don't have a physical keyboard for android but can they test if this patch:
and disabling the virtual keyboard in configuration is enough?
I can try to provide an apk once I have a decent internet connection...
@echarruau can you please check the difficulty of the datasets and set the corresponding levels in "stars"?
For example, for money_back, at last level, Tux has 100€ and needs to buy 4 elements (21€, 59€, 50€ and 68€) and I'm not sure that it is not too complicated (at least for a 3 stars dataset).
Same for money_cents and money_cents_back where there are also cents (so 49.06€, 164.09€, 25.02€ and 545.08€ for example) which seems quite difficult without calculator
The diff is not complete (missing datasets for example). Just one point to fix, on last dataset of minus-hat, it's up to 10000 not 1000.
@echarruau , for higher levels, would it make sense to have an hint on the numbers ? When the coefficients are displayed, and the stars are displayed, it maybe difficult for children to count exactly?
Jun 27 2019
Jun 26 2019
Jun 24 2019
Jun 23 2019
Jun 16 2019
Jun 15 2019
@echarruau can you test this when you have some time to see if it is good on the pedagogic level? Instead of applying the diff, checkout the branch gsoc_akshaychd_multiple_datasets where the work is done
Good job for the activities.
There is an issue when running gletters or wordsgame:
qrc:/gcompris/src/activities/gletters/Gletters.qml:89: TypeError: Type error
https://commits.kde.org/websites/gcompris-net/5f862f4d1f2e986d2d6784d7ee9136fe0b581b08 removed the dependency for the language list