- User Since
- Dec 30 2014, 5:43 PM (168 w, 3 d)
can you just fix no. to number and then it's good, you can commit.
Can you check that if you instantiate a ApplicationSettingsMock object, then use ApplicationSettings::getInstance(), it returns the mock instead of creating a new ApplicationSettings object?
As we use it this way on other classes (like ApplicationInfo), it would be better that, for tests, the getInstance() returns the mock instead of the real one (else we'll have the same issue as we had here, writing on the real configuration).
Wed, Mar 21
For me, there is no plus value for the child to see how many time he clicked the hint. For server mode, we can even think of not having the hint button at all or a hidden counter as you say, but we can add it later, no need to add code that may not be used
I'm not sure of the interest of the hint counter, for me, it's not needed
Tue, Mar 20
Sun, Mar 18
Sat, Mar 17
I pushed an equivalent of it in https://commits.kde.org/gcompris/4043239e98e32177085449e2757b8dc6462cb621
Now unit tests are optional so you need to pass -DBUILD_TESTING to build the library and unit tests.
I didn't added KDEInstallDirs and KDECMakeSettings as it was not needed
Fri, Mar 16
Thu, Mar 15
simplified and commited in https://cgit.kde.org/gcompris.git/commit/?id=af732f03cb44fc4710cf7545b626993b250f985b
Wed, Mar 14
it's the number on the dominoes, not the speed
This seems good to me (not yet tested). Maybe you can check if this can be used in photo_hunter activity (as it also uses sliders), but as the Style is different for it, it may not be useful.
we can also add the different version of Qt imports (QtQuick should be 2.6...)
Tue, Mar 13
Not sure if you saw but the related task (T8184) was claimed by ganesh more than 1 hour before your diff. Once you start working on a task, please assign it to yourself to avoid such situations.
Then, if there a task, you need to attach it to the diff (edit related objects -> edit task).
Finally, put the good group on reviewers, not only one person.
Mon, Mar 12
Sun, Mar 11
Sat, Mar 10
Other feature to add: lower the default background music sound (we need to be able to hear the introduction voices distinctly without having the background music blocking the child to listen)
Committed in https://commits.kde.org/gcompris/7c769594a5372e560904511404e2d1e156904050
don't hesitate to check if it works fine,
bargame updated and used for bargame_2players.
penalty removed in https://commits.kde.org/gcompris-data/d2d9b28c24b
clockgame: not updated, good enough
redraw: updated to remove the fact to reproduce the symmetrical figure
guessnumber: updated to remove the thumb to validate the answer
Sorry for delay, there is still an issue with mixed case
Fri, Mar 9
can you commit it on master please?
Thu, Mar 8
Globally, this activity is fine, only a bit of cleanup is to be done and be sure that it is still working fine once the other musical activities are completed (if common elements are modified).
For the sounds, there might be issues with the wav files but most should be working
Wed, Mar 7
Last time I checked, Qt didn't supported the js with classes which is the case for Maxwell, I don't know if there can be a workaround for it. We don't really care if the code behind is difficult or not, what is important is the library interface, to know if it is easy to interact with it.
@rohitdas: started in playpiano branch
Tue, Mar 6
Mon, Mar 5
Sun, Mar 4
It would be better to resize the content to not have to hide the bar.
Hiding the bar by default can perturb the user and should not be done when possible.