- User Since
- Dec 30 2014, 5:43 PM (206 w, 13 h)
Video link to the current feature: https://drive.google.com/open?id=1tvJRkIz9GiBIzPX0oWetqt1FuOj36EkY
Thank you for the patch.
When you change level, the taken pieces are not resetted.
@amankumargupta hi, we can't close a diff if at least one participant put a "changes needed". If it is good with you, can you please accept the revision and close it when you have some time?
I commited the fix in https://commits.kde.org/gcompris/80dd236c8c5da0b2ac1ac711e88d730e3b516544.
seems good now :)
Mon, Dec 10
Thank you for the unit test.
It may be easier to read if you have the data() then the corresponding test() function instead of having all the data() and at the end the test() functions (when you read one test, you'll just have to scroll above to know which data is tested)
Sun, Dec 9
Thank you for the tests.
Note that you can also use data driven tests to avoid duplicating the calls on each test: https://doc.qt.io/qt-5.11/qttestlib-tutorial2-example.html
Commited in https://commits.kde.org/gcompris/561753ee00aa35cbdcacbf1467d048a8a95f6e8d.
Sat, Dec 8
everything seems to be done :)
Thank you, the bugs are fixed.
There is still one: if you play a game with Tux (the icons have a 2 between the cards), there is the error: "qrc:/gcompris/src/activities/memory/memory.js:157: Error: Insufficient arguments" after I play (so when it's the computer turn)
Committed in https://cgit.kde.org/gcompris.git/commit/?id=d7a7e4e0fc30581604755f2b05441a3af32f1b70
Hi, thank you for the patch.
I see 2 issues:
- there should be more spaces between the cards (and the last ones should not override with the menu bar)
- when I select 2 cards with the mouse, I have the following error: qrc:/gcompris/src/activities/memory/memory.js:157: Error: Insufficient arguments
And I can't select cards anymore
Fri, Dec 7
Thu, Dec 6
Wed, Dec 5
Tue, Dec 4
Thank you, it's commited: https://cgit.kde.org/gcompris.git/commit/?id=dced7993b5a20ce98ba2071664a0595e27bf876e