jjazeix (Johnny Jazeix)
User

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Dec 30 2014, 5:43 PM (264 w, 5 d)
Availability
Available

Recent Activity

Today

jjazeix added a comment to D26712: Multiple Dataset for enumerate.

@jjazeix @echarruau enabling green color in input when child click ok, doesn't giving any visual feedback because at the same time (or just after this) nextSubLevel() function gets call. now either i can remove it completely or make some delay in calling nextSublevel. can you suggest anything better?

Sun, Jan 26, 4:41 PM · KDE Edu
jjazeix updated the summary of D26926: Fix Windows build (Qt5.14 deprecation).
Sun, Jan 26, 12:59 PM · Plasma
jjazeix requested review of D26926: Fix Windows build (Qt5.14 deprecation).
Sun, Jan 26, 12:59 PM · Plasma

Yesterday

jjazeix added inline comments to D26196: Add multiple dataset in guessnumber activity.
Sat, Jan 25, 3:06 PM · KDE Edu, GCompris: Improvements
jjazeix added a comment to D26196: Add multiple dataset in guessnumber activity.

After discussion with @echarruau :

  • can you do a first diff with only the dataset (just remove the numerical suite, keep the other features) that we can integrate directly. Having the separator on high numbers is a great addition.
  • for the numerical suite, in a second time, instead of having it on one line, having the numbers on 2 lines (so 0 to 9 and 10 to 19) should be better. Centering it on the background should be enough to have all the numbers displayed. It is still not clear if we only have the numerical suite for the first level or if we will need adaptation for higher levels...
Sat, Jan 25, 2:59 PM · KDE Edu, GCompris: Improvements
jjazeix added a comment to T12329: Adding level selection to balancing the scales with kgs.

@echarruau @jjazeix Instead of having message to teach about kgs and grams. What do you think of having a tutorial section for this purpose?

Sat, Jan 25, 2:31 PM · GCompris: Improvements
jjazeix added a comment to D26712: Multiple Dataset for enumerate.

the grid shouldn't be draggable.
there is still the tick and color changed to green when we put a good answer.
you should directly use the enabled property of the ok button instead of using a timer to disable clicks (in initSubLevel when everything is initialized).

Sat, Jan 25, 2:21 PM · KDE Edu
jjazeix added a comment to D26637: balance scales multiple dataset.

Please fix these:

git apply balancescale.diff 
balancescale.diff:294: new blank line at EOF.
+
balancescale.diff:375: new blank line at EOF.
+
balancescale.diff:469: new blank line at EOF.
+
balancescale.diff:563: new blank line at EOF.
+
balancescale.diff:677: new blank line at EOF.
+
warning: squelched 2 whitespace errors
warning: 7 lines add whitespace errors.
Sat, Jan 25, 2:04 PM · KDE Edu
jjazeix abandoned D10403: Porting of 3D-maze activity(ref: T1518).
Sat, Jan 25, 1:45 PM · KDE Edu, GCompris: Activities
jjazeix commandeered D10403: Porting of 3D-maze activity(ref: T1518).
Sat, Jan 25, 1:45 PM · KDE Edu, GCompris: Activities

Thu, Jan 23

jjazeix created T12576: Allow users with old openssl loaded to download the data.
Thu, Jan 23, 7:30 AM · GCompris: Bugs

Wed, Jan 22

jjazeix added inline comments to D26637: balance scales multiple dataset.
Wed, Jan 22, 7:34 AM · KDE Edu
jjazeix added a comment to D26712: Multiple Dataset for enumerate.

Almost ok for me :).
We shouldn't be able to click multiple times on "ok" quickly to validate 2 levels at same time.
When a fruit is under the instructions, we can't move it. I think it would be better to have clicks on fruits move them (always), and if click is on the window, show/hide the instruction. Instructions should always be displayed above the fruits.

Wed, Jan 22, 7:33 AM · KDE Edu

Tue, Jan 21

jjazeix added a comment to D26637: balance scales multiple dataset.

Except a small fix, it seems good to me on code side, but I haven't tested it yet

Tue, Jan 21, 7:28 AM · KDE Edu

Sun, Jan 19

jjazeix updated the task description for T12428: Add multiple levels to GCompris (progress list).
Sun, Jan 19, 8:12 PM · GCompris: Improvements
jjazeix abandoned D26107: Improved activity smallnumbers dataset.

Changes have been applied in https://phabricator.kde.org/D26539

Sun, Jan 19, 5:07 PM · KDE Edu, GCompris: Activities
jjazeix commandeered D26107: Improved activity smallnumbers dataset.
Sun, Jan 19, 5:06 PM · KDE Edu, GCompris: Activities
jjazeix closed T12390: Improve multipledataset in smallnumber, a subtask of T12428: Add multiple levels to GCompris (progress list), as Resolved.
Sun, Jan 19, 5:06 PM · GCompris: Improvements
jjazeix closed T12390: Improve multipledataset in smallnumber as Resolved.
Sun, Jan 19, 5:06 PM · GCompris: Improvements
jjazeix closed T12454: Improve multipledataset in smallnumber2, a subtask of T12428: Add multiple levels to GCompris (progress list), as Resolved.
Sun, Jan 19, 5:05 PM · GCompris: Improvements
jjazeix closed T12454: Improve multipledataset in smallnumber2 as Resolved.
Sun, Jan 19, 5:05 PM · GCompris: Improvements
jjazeix closed T12454: Improve multipledataset in smallnumber2, a subtask of T12510: SOK 2020 Plan (Shubham), as Resolved.
Sun, Jan 19, 5:05 PM · GCompris: Improvements
jjazeix closed D26539: added datasets in smallnumbers2.
Sun, Jan 19, 5:05 PM · KDE Edu, GCompris: Improvements
jjazeix accepted D26539: added datasets in smallnumbers2.

Commited in https://commits.kde.org/gcompris/cf4427fd3773239ae077bc89c53f4e2cb63e72a0

Sun, Jan 19, 5:05 PM · KDE Edu, GCompris: Improvements
jjazeix committed R2:cf4427fd3773: smallnumbers, smallnumbers2, add multiple dataset (authored by shubhammishra).
smallnumbers, smallnumbers2, add multiple dataset
Sun, Jan 19, 5:04 PM
jjazeix committed R2:e62bcb81e799: core, fix width size difficulty icon (authored by jjazeix).
core, fix width size difficulty icon
Sun, Jan 19, 3:02 PM
jjazeix committed R2:2f2fa97cab5e: core, fix binding loop error (authored by jjazeix).
core, fix binding loop error
Sun, Jan 19, 2:15 PM
jjazeix committed R2:8e767e2ccc15: gletters, add ActivityConfig.qml (authored by jjazeix).
gletters, add ActivityConfig.qml
Sun, Jan 19, 2:02 PM
jjazeix committed R2:3e225bfef717: Merge branch 'master' into multiple_dataset (authored by jjazeix).
Merge branch 'master' into multiple_dataset
Sun, Jan 19, 1:45 PM

Thu, Jan 16

jjazeix added inline comments to D26712: Multiple Dataset for enumerate.
Thu, Jan 16, 5:31 PM · KDE Edu

Tue, Jan 14

jjazeix added inline comments to D26539: added datasets in smallnumbers2.
Tue, Jan 14, 7:49 PM · KDE Edu, GCompris: Improvements
jjazeix committed R2:3d06e9eaec1e: core, fix warning on undefined element (authored by jjazeix).
core, fix warning on undefined element
Tue, Jan 14, 7:38 PM
jjazeix committed R2:20344d4c55f9: core, BUG: 415102 fix audio not playing in missing-letter (authored by jjazeix).
core, BUG: 415102 fix audio not playing in missing-letter
Tue, Jan 14, 6:19 PM
jjazeix added inline comments to D26539: added datasets in smallnumbers2.
Tue, Jan 14, 5:51 PM · KDE Edu, GCompris: Improvements

Mon, Jan 13

jjazeix added inline comments to D26539: added datasets in smallnumbers2.
Mon, Jan 13, 7:47 PM · KDE Edu, GCompris: Improvements
jjazeix updated the task description for T12428: Add multiple levels to GCompris (progress list).
Mon, Jan 13, 3:06 PM · GCompris: Improvements
jjazeix added a parent task for T12328: Improve multipledataset in clockgame: T12428: Add multiple levels to GCompris (progress list).
Mon, Jan 13, 3:06 PM · GCompris: Improvements
jjazeix added a subtask for T12428: Add multiple levels to GCompris (progress list): T12328: Improve multipledataset in clockgame.
Mon, Jan 13, 3:06 PM · GCompris: Improvements
jjazeix updated the task description for T12328: Improve multipledataset in clockgame.
Mon, Jan 13, 3:05 PM · GCompris: Improvements
jjazeix committed R2:730ff4e546ed: clockgame, add multiple dataset (authored by dekumar).
clockgame, add multiple dataset
Mon, Jan 13, 7:37 AM
jjazeix closed D26549: clockgame multiple dataset.

Thank you, pushed in https://commits.kde.org/gcompris/730ff4e546edb0227ff5f376ebc1feb77869c91e (I did the change @echarruau mentioned on difficulties)

Mon, Jan 13, 7:36 AM · GCompris, KDE Edu

Sun, Jan 12

jjazeix committed R2:f59ed88aa3c7: core, sort multiple dataset per name (authored by jjazeix).
core, sort multiple dataset per name
Sun, Jan 12, 7:16 PM
jjazeix accepted D26549: clockgame multiple dataset.
Sun, Jan 12, 5:32 PM · GCompris, KDE Edu
jjazeix added inline comments to D26549: clockgame multiple dataset.
Sun, Jan 12, 5:26 PM · GCompris, KDE Edu
jjazeix added a comment to D26549: clockgame multiple dataset.

For the 24 hours, I would revert the change from this diff.
Multiple things need to be taken in account:

  • Should the hint go to 24h (from 0h to 24h)?
  • Should we display AM/PM for locale that use them instead of 13h->24h? ...

I think for 24 hrs format there is no AM/PM. As 20hr is equal to 8 pm using this format.
Let me know if you want me to remove 24hrs format from the diff for now.

Sun, Jan 12, 2:33 PM · GCompris, KDE Edu
jjazeix added a comment to D26549: clockgame multiple dataset.

For the 24 hours, I would revert the change from this diff.
Multiple things need to be taken in account:

  • Should the hint go to 24h (from 0h to 24h)?
  • Should we display AM/PM for locale that use them instead of 13h->24h?

...

Sun, Jan 12, 2:22 PM · GCompris, KDE Edu
jjazeix added inline comments to D26549: clockgame multiple dataset.
Sun, Jan 12, 2:11 PM · GCompris, KDE Edu
jjazeix abandoned D26601: fix android compilation.

ok, thanks for the info. I just pushed in it.
Build is now ok: https://build.kde.org/view/Failing/job/Applications/job/elisa/job/kf5-qt5%20AndroidQt5.13/19/console

Sun, Jan 12, 1:35 PM · Elisa
jjazeix committed R255:6291be1d9644: Fix android compilation (authored by jjazeix).
Fix android compilation
Sun, Jan 12, 1:33 PM
jjazeix added a comment to D26601: fix android compilation.

Not sure why I can't push directly this change:

Sun, Jan 12, 9:32 AM · Elisa
jjazeix requested review of D26601: fix android compilation.
Sun, Jan 12, 9:29 AM · Elisa

Sat, Jan 11

jjazeix added a comment to T12328: Improve multipledataset in clockgame.

Hi Deepak,
We will need an supplementary option there not sure how to handle it.
https://en.wikipedia.org/wiki/Date_and_time_representation_by_country
Most countries use 24 hours clock even thought on the clock we only see 0 to 12 on the display.
But english speaking region are using AM PM, we will need to support both.
We could use an option button like we have in gletters to choose between 24 and 12 hours option, or offer for each dataset both format:

  • full hours (24 hours format)
  • full hours (12 hours format)
Sat, Jan 11, 9:45 AM · GCompris: Improvements

Fri, Jan 10

jjazeix added a reviewer for D26539: added datasets in smallnumbers2: GCompris: Improvements.
Fri, Jan 10, 7:25 AM · KDE Edu, GCompris: Improvements

Thu, Jan 9

jjazeix added a reviewer for D26549: clockgame multiple dataset: GCompris: Improvements.
Thu, Jan 9, 5:12 PM · GCompris, KDE Edu

Wed, Jan 8

jjazeix added a comment to T12328: Improve multipledataset in clockgame.

@dekumar yes, go with it. Check what can also be put as option of the dataset (like for now, the display of the hands and if it can increase the difficulty on some levels).

Wed, Jan 8, 7:37 PM · GCompris: Improvements
jjazeix added a project to T12328: Improve multipledataset in clockgame: GCompris: Improvements.
Wed, Jan 8, 6:35 PM · GCompris: Improvements

Tue, Jan 7

jjazeix added a comment to T5477: Practice Activity.

@dekumar please focus on sok for now.
Regarding this activity, I don't remember at all the state, I would need to take a closer look :/

Tue, Jan 7, 7:35 PM · GCompris: Activities
jjazeix added a comment to D26473: drawletters-cursive activity.

There is no need to create a diff because you create a new activity.
In this case, it may be better to add a configuration in drawletters to directly choose cursive (or lowercase if we do it someday).
Or even a dataset would be better (so it will allow to add different locales too)

Tue, Jan 7, 6:47 PM · KDE Edu

Mon, Jan 6

jjazeix committed R2:212bb02d9725: build, compilation of box2d uses make/nmake for Ninja generator as qmake does… (authored by jjazeix).
build, compilation of box2d uses make/nmake for Ninja generator as qmake does…
Mon, Jan 6, 10:01 PM
jjazeix committed R2:adc807115b1a: core, fix warning (authored by jjazeix).
core, fix warning
Mon, Jan 6, 9:22 PM
jjazeix committed R883:1559643: Add space at end of sentence.
Add space at end of sentence
Mon, Jan 6, 8:54 PM
jjazeix committed R2:5c00356176ca: core, fix conversion warning (authored by jjazeix).
core, fix conversion warning
Mon, Jan 6, 7:35 PM
jjazeix committed R2:b6e2ed3b10b7: quality, remove modernize-use-trailing-return-type check (authored by jjazeix).
quality, remove modernize-use-trailing-return-type check
Mon, Jan 6, 7:21 PM

Sat, Jan 4

jjazeix abandoned D21893: magic-hat, add multiple datasets.
Sat, Jan 4, 8:38 PM · KDE Edu, GCompris: Improvements
jjazeix commandeered D21893: magic-hat, add multiple datasets.
Sat, Jan 4, 8:38 PM · KDE Edu, GCompris: Improvements
jjazeix committed R2:a325e60c6a5a: guesscount, fix warning when starting the activity (authored by jjazeix).
guesscount, fix warning when starting the activity
Sat, Jan 4, 8:35 PM
jjazeix added inline comments to D26196: Add multiple dataset in guessnumber activity.
Sat, Jan 4, 8:28 PM · KDE Edu, GCompris: Improvements
jjazeix abandoned D26278: Error Occurs due the DialogChooseLevel.
Sat, Jan 4, 6:05 PM · KDE Edu
jjazeix commandeered D26278: Error Occurs due the DialogChooseLevel.
Sat, Jan 4, 6:05 PM · KDE Edu
jjazeix committed R2:3acff780f35a: core, remove useless imports (authored by jjazeix).
core, remove useless imports
Sat, Jan 4, 6:02 PM
jjazeix committed R883:1559478: fix fuzzy tag.
fix fuzzy tag
Sat, Jan 4, 1:53 PM
jjazeix committed R883:1559477: fix fuzzy tag.
fix fuzzy tag
Sat, Jan 4, 1:52 PM
jjazeix committed R883:1559476: fix fuzzy tag.
fix fuzzy tag
Sat, Jan 4, 1:51 PM
jjazeix committed R883:1559475: fix fuzzy tag.
fix fuzzy tag
Sat, Jan 4, 1:50 PM
jjazeix committed R883:1559474: fix fuzzy tag.
fix fuzzy tag
Sat, Jan 4, 1:49 PM
jjazeix committed R883:1559473: fix fuzzy tag.
fix fuzzy tag
Sat, Jan 4, 1:48 PM
jjazeix committed R883:1559472: fix fuzzy tag.
fix fuzzy tag
Sat, Jan 4, 1:46 PM
jjazeix closed T12438: Drawletters: correct incorrect letter drawings as Resolved.
Sat, Jan 4, 1:40 PM · GCompris: Bugs
jjazeix added a comment to T12438: Drawletters: correct incorrect letter drawings.

G is also wrong (the second bar is drawn for right to left in GCompris).
T and X are already fine? I think.

Sat, Jan 4, 1:40 PM · GCompris: Bugs
jjazeix closed D26260: drawletters mistakes corrected.
Sat, Jan 4, 1:39 PM · KDE Edu
jjazeix accepted D26260: drawletters mistakes corrected.

Thank you.
I also fixed the G that was missing and added back a point in the O you forgot.
Commited in https://commits.kde.org/gcompris/b0f79bdc62a337793a76d41237ca1ac71ee0ca03

Sat, Jan 4, 1:39 PM · KDE Edu
jjazeix committed R2:b0f79bdc62a3: drawletters, fix letters: A, G, M, N, O, Q and Y (authored by dekumar).
drawletters, fix letters: A, G, M, N, O, Q and Y
Sat, Jan 4, 1:39 PM

Fri, Jan 3

jjazeix added a comment to D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined.

@jjazeix please apply it to stable branch also

Done: https://commits.kde.org/latte-dock/e740bd38032441d5c03ba5321a76dad0ba5af9b9
Build ok: https://build.kde.org/job/Extragear/job/latte-dock/job/stable-kf5-qt5%20FreeBSDQt5.13/102/

Fri, Jan 3, 7:38 PM · Plasma, Latte Dock
jjazeix committed R878:e740bd380324: add KDECompilerSettings for CI compilation (authored by jjazeix).
add KDECompilerSettings for CI compilation
Fri, Jan 3, 7:36 PM
jjazeix closed D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined.

No prob... Did I understood correctly that this was fixable on your side without any need to touch Latte code? (dont worry about commiting and reverting)

Fri, Jan 3, 7:32 PM · Plasma, Latte Dock
jjazeix added a comment to D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined.

Unfortunate, it definitely looked like QMLLint was the cause of the issues.

Given that Latte Dock is the only application impacted by this, does it do anything else special with regards to linking the application (such as not making use of ECM).

Fri, Jan 3, 6:46 PM · Plasma, Latte Dock
jjazeix committed R878:d2170f13c04e: revert previous commit, add KDECompilerSettings back (authored by jjazeix).
revert previous commit, add KDECompilerSettings back
Fri, Jan 3, 6:41 PM
jjazeix added a comment to D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined.

Commited in https://commits.kde.org/latte-dock/e705eed41556649661f959b714a016938c19817c
Build still not ok in https://build.kde.org/job/Extragear/job/latte-dock/job/kf5-qt5%20FreeBSDQt5.13/118/console
The issue is due to the link error, probably not qmllint

Fri, Jan 3, 5:50 PM · Plasma, Latte Dock
jjazeix committed R878:e705eed41556: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined (authored by jjazeix).
Don't run qmllint if ECM_ENABLE_SANITIZERS is defined
Fri, Jan 3, 5:46 PM
jjazeix updated the diff for D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined.
Fri, Jan 3, 5:08 PM · Plasma, Latte Dock
jjazeix requested review of D26399: Don't run qmllint if ECM_ENABLE_SANITIZERS is defined.
Fri, Jan 3, 5:03 PM · Plasma, Latte Dock

Thu, Jan 2

jjazeix committed R924:2a457d10a7e7: code cleanup (authored by jjazeix).
code cleanup
Thu, Jan 2, 9:42 PM
jjazeix added a parent task for T12329: Adding level selection to balancing the scales with kgs: T12428: Add multiple levels to GCompris (progress list).
Thu, Jan 2, 11:52 AM · GCompris: Improvements
jjazeix added a subtask for T12428: Add multiple levels to GCompris (progress list): T12329: Adding level selection to balancing the scales with kgs.
Thu, Jan 2, 11:52 AM · GCompris: Improvements
jjazeix added a parent task for T12330: Adding level selection to balancing the scales: T12428: Add multiple levels to GCompris (progress list).
Thu, Jan 2, 11:52 AM · GCompris: Improvements
jjazeix added a subtask for T12428: Add multiple levels to GCompris (progress list): T12330: Adding level selection to balancing the scales.
Thu, Jan 2, 11:52 AM · GCompris: Improvements
jjazeix added a subtask for T12428: Add multiple levels to GCompris (progress list): T12331: Adding level selection to Find the Date.
Thu, Jan 2, 11:52 AM · GCompris: Improvements
jjazeix added a parent task for T12331: Adding level selection to Find the Date: T12428: Add multiple levels to GCompris (progress list).
Thu, Jan 2, 11:52 AM · GCompris: Improvements
jjazeix added a parent task for T12332: Adding level selection to Memory-enumerate: T12428: Add multiple levels to GCompris (progress list).
Thu, Jan 2, 11:51 AM · GCompris: Improvements
jjazeix added a subtask for T12428: Add multiple levels to GCompris (progress list): T12332: Adding level selection to Memory-enumerate.
Thu, Jan 2, 11:51 AM · GCompris: Improvements