- User Since
- Dec 30 2014, 5:43 PM (264 w, 5 d)
After discussion with @echarruau :
- can you do a first diff with only the dataset (just remove the numerical suite, keep the other features) that we can integrate directly. Having the separator on high numbers is a great addition.
- for the numerical suite, in a second time, instead of having it on one line, having the numbers on 2 lines (so 0 to 9 and 10 to 19) should be better. Centering it on the background should be enough to have all the numbers displayed. It is still not clear if we only have the numerical suite for the first level or if we will need adaptation for higher levels...
the grid shouldn't be draggable.
there is still the tick and color changed to green when we put a good answer.
you should directly use the enabled property of the ok button instead of using a timer to disable clicks (in initSubLevel when everything is initialized).
Please fix these:
git apply balancescale.diff balancescale.diff:294: new blank line at EOF. + balancescale.diff:375: new blank line at EOF. + balancescale.diff:469: new blank line at EOF. + balancescale.diff:563: new blank line at EOF. + balancescale.diff:677: new blank line at EOF. + warning: squelched 2 whitespace errors warning: 7 lines add whitespace errors.
Thu, Jan 23
Wed, Jan 22
Almost ok for me :).
We shouldn't be able to click multiple times on "ok" quickly to validate 2 levels at same time.
When a fruit is under the instructions, we can't move it. I think it would be better to have clicks on fruits move them (always), and if click is on the window, show/hide the instruction. Instructions should always be displayed above the fruits.
Tue, Jan 21
Except a small fix, it seems good to me on code side, but I haven't tested it yet
Sun, Jan 19
Changes have been applied in https://phabricator.kde.org/D26539
Thu, Jan 16
Tue, Jan 14
Mon, Jan 13
Thank you, pushed in https://commits.kde.org/gcompris/730ff4e546edb0227ff5f376ebc1feb77869c91e (I did the change @echarruau mentioned on difficulties)
Sun, Jan 12
For the 24 hours, I would revert the change from this diff.
Multiple things need to be taken in account:
- Should the hint go to 24h (from 0h to 24h)?
- Should we display AM/PM for locale that use them instead of 13h->24h?
ok, thanks for the info. I just pushed in it.
Build is now ok: https://build.kde.org/view/Failing/job/Applications/job/elisa/job/kf5-qt5%20AndroidQt5.13/19/console
Not sure why I can't push directly this change:
Sat, Jan 11
Fri, Jan 10
Thu, Jan 9
Wed, Jan 8
@dekumar yes, go with it. Check what can also be put as option of the dataset (like for now, the display of the hands and if it can increase the difficulty on some levels).
Tue, Jan 7
@dekumar please focus on sok for now.
Regarding this activity, I don't remember at all the state, I would need to take a closer look :/
There is no need to create a diff because you create a new activity.
In this case, it may be better to add a configuration in drawletters to directly choose cursive (or lowercase if we do it someday).
Or even a dataset would be better (so it will allow to add different locales too)
Mon, Jan 6
Sat, Jan 4
G is also wrong (the second bar is drawn for right to left in GCompris).
T and X are already fine? I think.
I also fixed the G that was missing and added back a point in the O you forgot.
Commited in https://commits.kde.org/gcompris/b0f79bdc62a337793a76d41237ca1ac71ee0ca03
Fri, Jan 3
@jjazeix please apply it to stable branch also
No prob... Did I understood correctly that this was fixable on your side without any need to touch Latte code? (dont worry about commiting and reverting)
Commited in https://commits.kde.org/latte-dock/e705eed41556649661f959b714a016938c19817c
Build still not ok in https://build.kde.org/job/Extragear/job/latte-dock/job/kf5-qt5%20FreeBSDQt5.13/118/console
The issue is due to the link error, probably not qmllint