Feed Advanced Search

Mon, Dec 9

thomasfischer updated the diff for D24641: Collect more information from version control systems.

I tried to address the most recent comments:

Mon, Dec 9, 10:49 PM · Build System, Frameworks

Sun, Dec 8

asturmlechner added a reviewer for D25812: ECMFindQMLModule.cmake.in: Add ECM_DISABLE_QMLPLUGINDUMP to avoid sandbox violations: Frameworks.
Sun, Dec 8, 3:32 PM · Build System, Frameworks
asturmlechner requested review of D25812: ECMFindQMLModule.cmake.in: Add ECM_DISABLE_QMLPLUGINDUMP to avoid sandbox violations.
Sun, Dec 8, 3:29 PM · Build System, Frameworks

Fri, Dec 6

jhayes added a comment to D25753: EBN extra-cmake-modules transport cleanup.

The two links I know of are:
http://0pointer.de/lennart/projects/libcanberra (works as is in file but
wont work as https)
http://www.x86-64.org/documentation/abi.pdf (http://www.x86-64.org is dead)

Fri, Dec 6, 2:23 PM · Build System, Frameworks
cgiboudeaux added a comment to D25753: EBN extra-cmake-modules transport cleanup.

please send me a list of urls that don't have https: and I'll add them to the whitelist

Fri, Dec 6, 12:17 PM · Build System, Frameworks

Thu, Dec 5

winterz added a comment to D25753: EBN extra-cmake-modules transport cleanup.

please send me a list of urls that don't have https: and I'll add them to the whitelist

Thu, Dec 5, 9:26 PM · Build System, Frameworks
cgiboudeaux closed D25753: EBN extra-cmake-modules transport cleanup.
Thu, Dec 5, 9:14 PM · Build System, Frameworks
cgiboudeaux accepted D25753: EBN extra-cmake-modules transport cleanup.
Thu, Dec 5, 9:12 PM · Build System, Frameworks
jhayes updated the diff for D25753: EBN extra-cmake-modules transport cleanup.
  • Corrected URL as review comments

Corrected url to http://www.sphinx-doc.org

Thu, Dec 5, 6:15 PM · Build System, Frameworks
cgiboudeaux added a comment to D25753: EBN extra-cmake-modules transport cleanup.

The sphinx doc URL is https://www.sphinx-doc.org (it just doesn't work without www)

Thu, Dec 5, 5:22 PM · Build System, Frameworks
jhayes updated the diff for D25753: EBN extra-cmake-modules transport cleanup.
  • Corrections made per review comments.

Reverted some non-working URL's back to http and updated one URL to the correct address

Thu, Dec 5, 2:50 PM · Build System, Frameworks
cgiboudeaux closed D25752: EBN extra-cmake-modules comments spelling cleanup.
Thu, Dec 5, 9:37 AM · Build System, Frameworks
cgiboudeaux added inline comments to D25753: EBN extra-cmake-modules transport cleanup.
Thu, Dec 5, 9:28 AM · Build System, Frameworks
cgiboudeaux requested changes to D25753: EBN extra-cmake-modules transport cleanup.
Thu, Dec 5, 9:27 AM · Build System, Frameworks
apol accepted D25753: EBN extra-cmake-modules transport cleanup.
Thu, Dec 5, 12:15 AM · Build System, Frameworks
apol accepted D25752: EBN extra-cmake-modules comments spelling cleanup.
Thu, Dec 5, 12:14 AM · Build System, Frameworks

Wed, Dec 4

jhayes requested review of D25753: EBN extra-cmake-modules transport cleanup.
Wed, Dec 4, 10:21 PM · Build System, Frameworks
jhayes requested review of D25752: EBN extra-cmake-modules comments spelling cleanup.
Wed, Dec 4, 9:59 PM · Build System, Frameworks

Sun, Dec 1

kossebau closed D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag.
Sun, Dec 1, 11:04 PM · Build System, Frameworks
kossebau added a comment to D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag.

My head hurts a bit but I think I understand this now ;)

Sun, Dec 1, 11:04 PM · Build System, Frameworks
dfaure accepted D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag.

My head hurts a bit but I think I understand this now ;)

Sun, Dec 1, 7:27 PM · Build System, Frameworks

Sat, Nov 30

davidre closed D25626: Fix EcmGenerateExportHeader tests on Windows.
Sat, Nov 30, 2:08 PM · Build System, Frameworks
davidre added a comment to D25626: Fix EcmGenerateExportHeader tests on Windows.

Yay, thanks for fixing this. Not sure if if(MSVC) is the proper condition, due to not being into the windows side of things, so that part better has someone check who enters the dark side now and then. :)
Otherwise +1 for this.

I used it because it is the same condition inside ECMGenerateExportHeader.cmake which enables __declspec(deprecated(text)).

Sat, Nov 30, 12:26 PM · Build System, Frameworks
kossebau accepted D25626: Fix EcmGenerateExportHeader tests on Windows.

Yay, thanks for fixing this. Not sure if if(MSVC) is the proper condition, due to not being into the windows side of things, so that part better has someone check who enters the dark side now and then. :)
Otherwise +1 for this.

Sat, Nov 30, 12:22 PM · Build System, Frameworks
davidre retitled D25626: Fix EcmGenerateExportHeader tests on Windows from Fix EcmGenerateExportHeader tests on windows to Fix EcmGenerateExportHeader tests on Windows.
Sat, Nov 30, 12:22 PM · Build System, Frameworks
davidre added reviewers for D25626: Fix EcmGenerateExportHeader tests on Windows: kossebau, Windows, Frameworks.
Sat, Nov 30, 12:19 PM · Build System, Frameworks
davidre requested review of D25626: Fix EcmGenerateExportHeader tests on Windows.
Sat, Nov 30, 12:18 PM · Build System, Frameworks

Thu, Nov 28

kossebau added a comment to D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.

Hm, only noticed now that this actually has an unwanted sideeffects: it triggers deprecation warnings for all deprecated warning also inside each library itself. Which is not what one wants.

Thu, Nov 28, 1:02 PM · Build System, Frameworks
kossebau requested review of D25589: ECMGenerateExportHeader: add NO_BUILD_SET_DEPRECATED_WARNINGS_SINCE flag.
Thu, Nov 28, 12:49 PM · Build System, Frameworks

Tue, Nov 26

davidedmundson closed D25107: Add install dir for systemd units.
Tue, Nov 26, 11:54 AM · Build System, Frameworks

Mon, Nov 25

fvogt accepted D25107: Add install dir for systemd units.
Mon, Nov 25, 6:06 PM · Build System, Frameworks
davidedmundson updated the diff for D25107: Add install dir for systemd units.

Fabian fixes

Mon, Nov 25, 5:10 PM · Build System, Frameworks
cgiboudeaux added inline comments to D25107: Add install dir for systemd units.
Mon, Nov 25, 1:51 PM · Build System, Frameworks
davidedmundson added a comment to D25107: Add install dir for systemd units.

Wow, this part of systemd is shitty :/

Mon, Nov 25, 1:48 PM · Build System, Frameworks
fvogt requested changes to D25107: Add install dir for systemd units.
Mon, Nov 25, 1:40 PM · Build System, Frameworks
fvogt reopened D25107: Add install dir for systemd units.

AFAICT this breaks if LIBDIR != "lib". systemd only looks in /usr/lib AFAICT, so hardcoding to $prefix/lib/systemd might be better.

Mon, Nov 25, 1:39 PM · Build System, Frameworks

Sun, Nov 24

tcberner abandoned D17863: Add ecm_check_linker_flags function.
Sun, Nov 24, 8:03 AM · Build System, Frameworks

Tue, Nov 19

kossebau added a comment to D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.

So we need to set FOO_DISABLE_DEPRECATED_BEFORE_AND_AT to N-1 while building FOO itself, right? Either magically here, or manually in every module...

Tue, Nov 19, 1:47 PM · Build System, Frameworks
dfaure added a comment to D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.

So we need to set FOO_DISABLE_DEPRECATED_BEFORE_AND_AT to N-1 while building FOO itself, right? Either magically here, or manually in every module...

Tue, Nov 19, 1:40 PM · Build System, Frameworks
kossebau added a comment to D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.

Hm, only noticed now that this actually has an unwanted sideeffects: it triggers deprecation warnings for all deprecated warning also inside each library itself. Which is not what one wants.

Tue, Nov 19, 1:39 PM · Build System, Frameworks

Sun, Nov 17

cullmann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

Btw., I just tried e.g.

Sun, Nov 17, 12:19 PM · Build System, Frameworks
cullmann added reviewers for D24568: Provide clang-format target with a KDE Frameworks style file: broulik, davidedmundson.

For the lambda issue, I think we can add:

Sun, Nov 17, 12:05 PM · Build System, Frameworks
cullmann reopened D24568: Provide clang-format target with a KDE Frameworks style file.

Let's just reopen this and work on improving it.

Sun, Nov 17, 11:57 AM · Build System, Frameworks
cullmann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

As an update on this from the Plasma POV.

I added the macro to every repo and told every dev to do a final test before we commit the formatted results.

I had some feedback and the result was that we can't proceed with in the current state [1].

What's noteworthy is we were generally ok with the results from the first file we prepared in T11214, so potentially we just need some settings tweaked.
I'll try and break that down into future diffs.

1.https://mail.kde.org/pipermail/plasma-devel/2019-November/106186.html

Sun, Nov 17, 11:48 AM · Build System, Frameworks

Sat, Nov 16

dhaumann added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

You can force the current clang format to keep the multi-line if as follows:

Sat, Nov 16, 8:03 AM · Build System, Frameworks

Fri, Nov 15

davidedmundson added a comment to D24568: Provide clang-format target with a KDE Frameworks style file.

As an update on this from the Plasma POV.

Fri, Nov 15, 6:31 PM · Build System, Frameworks
sitter added a comment to D24641: Collect more information from version control systems.

This is starting to look really good. All functions will need documenting in the header of that file so they show up on api.kde.org, see other modules for examples.

Fri, Nov 15, 12:26 PM · Build System, Frameworks

Thu, Nov 14

cgiboudeaux abandoned D25304: Fix the OpenEXR >= 2.4 detection.

I applied the patch to our openexr package instead.

Thu, Nov 14, 7:57 PM · Build System, Frameworks
arojas added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

The pkgconfig file disagrees:
it contains libsuffix=-2_4 and later Libs: -L${libdir} -lIlmImf${libsuffix}
For me, that library name is correct

Thu, Nov 14, 5:30 PM · Build System, Frameworks
cgiboudeaux added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

I don't see how that commit is related.
openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so

This is expected afaics.

No, it's not. That line in openexr is supposed to link libXXX-2_4.so (${verlibname}) to libXXX.so (${baselibname}) but it does so in the wrong dir

Thu, Nov 14, 5:26 PM · Build System, Frameworks
arojas added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

I don't see how that commit is related.
openEXR 2.3 installs libXXX.so and 2.4 installs libXXX-2_4.so

This is expected afaics.

Thu, Nov 14, 5:23 PM · Build System, Frameworks
cgiboudeaux added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

This is a bug in openexr. It does actually try to install the unsuffixed symlinks, but it doesn't take DESTDIR into account, so it tries to install them to the root filesystem instead of doing so inside DESTDIR as it should. It is fixed in https://github.com/openexr/openexr/commit/4e54bde78f65c0fef8a9f794aaacea07813fba09

Thu, Nov 14, 5:19 PM · Build System, Frameworks
arojas added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

This is a bug in openexr. It does actually try to install the unprefixed symlinks, but it doesn't take DESTDIR into account, so it tries to install them to the root filesystem instead of doing so inside DESTDIR as it should. It is fixed in https://github.com/openexr/openexr/commit/4e54bde78f65c0fef8a9f794aaacea07813fba09

Thu, Nov 14, 4:53 PM · Build System, Frameworks
cgiboudeaux added a comment to D25304: Fix the OpenEXR >= 2.4 detection.

Note: openEXR >= 2.4 provides CMake configuration modules (OpenEXRConfig.cmake and IlmBaseConfig.cmake). We could also look for those and use the current code as a fallback if the modules can't be found

Thu, Nov 14, 1:53 PM · Build System, Frameworks
cgiboudeaux requested review of D25304: Fix the OpenEXR >= 2.4 detection.
Thu, Nov 14, 1:42 PM · Build System, Frameworks

Nov 8 2019

winterz added a comment to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

FYI: Today I added a Krazy checker to do this. Should see results on the EBN in a day or 2.

Nov 8 2019, 10:33 PM · Build System, Frameworks

Nov 3 2019

davidedmundson closed D25107: Add install dir for systemd units.
Nov 3 2019, 10:04 PM · Build System, Frameworks
kossebau closed D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.
Nov 3 2019, 8:48 PM · Build System, Frameworks
kossebau added a comment to D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.

Merci, will land later tonight. Bonnes vacances :)

Nov 3 2019, 8:18 PM · Build System, Frameworks
dfaure accepted D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.

Done (in the process of being pushed), you can push this.

Nov 3 2019, 8:11 PM · Build System, Frameworks
kossebau updated subscribers of D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.

@dfaure Hi. Any chance you you can sneak in before you are away (enjoy :) ) to remove the "-DQT_DEPRECATED_WARNINGS_SINCE=0x060000" from all the KF modules in the next days? Otherwise would land this here with just the -DKF_DEPRECATED_WARNINGS_SINCE=0x060000 for now, otherwise people do not see warnings in KF modules when they should.

Nov 3 2019, 7:58 PM · Build System, Frameworks
thomasfischer updated the diff for D24641: Collect more information from version control systems.

I updated the diff. I was quite surprised about the time it takes to compute the number of commits (26 seconds), thus I removed this functionality completely. As of now, only 'revision' and 'branch' are queried for.
There are three functions now:

Nov 3 2019, 6:16 PM · Build System, Frameworks
thomasfischer updated the test plan for D24641: Collect more information from version control systems.
Nov 3 2019, 6:08 PM · Build System, Frameworks
apol accepted D25107: Add install dir for systemd units.
Nov 3 2019, 2:26 AM · Build System, Frameworks

Nov 1 2019

davidedmundson requested review of D25107: Add install dir for systemd units.
Nov 1 2019, 5:05 PM · Build System, Frameworks

Oct 28 2019

apol accepted D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.
Oct 28 2019, 11:54 AM · Build System, Frameworks

Oct 27 2019

kossebau requested review of D24990: KDEFrameworkCompilerSettings: enable all Qt % KF deprecation warnings.
Oct 27 2019, 7:41 PM · Build System, Frameworks

Oct 24 2019

sitter added a comment to D24641: Collect more information from version control systems.

Hm, how about separate functions though? With a single stat any given build still needs N process forks even when they only want 1 value.

Oct 24 2019, 10:22 AM · Build System, Frameworks

Oct 23 2019

kossebau added a comment to D24841: Use modern way to set the C/CXX standard.

Where are those tests running? I'm only aware of https://build.kde.org/job/Frameworks/job/extra-cmake-modules/

Oct 23 2019, 5:22 PM · Build System, Frameworks
vonreth added a comment to D24841: Use modern way to set the C/CXX standard.

Another issue caused by the new CMake 3.5 dependency, some tests fail:

59 - ecm_setup_version-old_simple (Failed)
60 - ecm_setup_version-old_soversion (Failed)
61 - ecm_setup_version-old_version_file (Failed)
62 - ecm_setup_version-old_version_file_abspath (Failed)
63 - ecm_setup_version-old_version_file_anynewer (Failed)
64 - ecm_setup_version-old_version_file_exact (Failed)
65 - ecm_setup_version-old_version_file_samemajor (Failed)
66 - ecm_setup_version-old_header (Failed)
67 - ecm_setup_version-old_header_abspath (Failed)

(+2 others not related to the recent changes)
I didn't look yet at the details. My guess is the CMake policy changes between 2.8.12 and 3.5

Oct 23 2019, 5:18 PM · Build System, Frameworks
cgiboudeaux added a comment to D24841: Use modern way to set the C/CXX standard.

Another issue caused by the new CMake 3.5 dependency, some tests fail:

Oct 23 2019, 11:01 AM · Build System, Frameworks
dfaure closed D24882: Don't set C/C++ standards if already set.
Oct 23 2019, 10:15 AM · Build System, Frameworks
cgiboudeaux accepted D24882: Don't set C/C++ standards if already set.

Thanks! tested successfully

Oct 23 2019, 9:43 AM · Build System, Frameworks
dfaure added a comment to D24841: Use modern way to set the C/CXX standard.

Does https://phabricator.kde.org/D24882 help? (Not tested)

Oct 23 2019, 9:34 AM · Build System, Frameworks
dfaure requested review of D24882: Don't set C/C++ standards if already set.
Oct 23 2019, 9:34 AM · Build System, Frameworks
cgiboudeaux added a comment to D24841: Use modern way to set the C/CXX standard.

Where did -std=gnu++14 come from? The old code above certainly didn't set it.

Maybe some projects were doing set(CMAKE_CXX_STANDARD 14) before including KDECompilerSettings? We could test the var here to avoid overwriting it...

Oct 23 2019, 9:17 AM · Build System, Frameworks
dfaure added a comment to D24841: Use modern way to set the C/CXX standard.

Where did -std=gnu++14 come from? The old code above certainly didn't set it.

Oct 23 2019, 9:08 AM · Build System, Frameworks
cgiboudeaux added a comment to D24841: Use modern way to set the C/CXX standard.

I'm seeing build failures in several repositories seemingly caused by 6e3c794 (eg akonadi, kasync)

Oct 23 2019, 9:01 AM · Build System, Frameworks

Oct 22 2019

vonreth closed D24841: Use modern way to set the C/CXX standard.
Oct 22 2019, 4:54 PM · Build System, Frameworks
cgiboudeaux updated the summary of D24841: Use modern way to set the C/CXX standard.
Oct 22 2019, 2:53 PM · Build System, Frameworks
dfaure accepted D24841: Use modern way to set the C/CXX standard.
Oct 22 2019, 7:00 AM · Build System, Frameworks

Oct 21 2019

vonreth updated the diff for D24841: Use modern way to set the C/CXX standard.
  • Raise CMake requirements to 3.5
Oct 21 2019, 9:38 PM · Build System, Frameworks
dfaure added a comment to D24841: Use modern way to set the C/CXX standard.

Dunno, it's harder to justify in a standalone review :)
"Increase dependency, just because" ;)

Oct 21 2019, 9:04 PM · Build System, Frameworks
vonreth added a comment to D24841: Use modern way to set the C/CXX standard.

I guess we should do that in a separate review?

Oct 21 2019, 8:45 PM · Build System, Frameworks
vonreth updated the diff for D24841: Use modern way to set the C/CXX standard.

Fix

Oct 21 2019, 8:41 PM · Build System, Frameworks
dfaure added a comment to D24841: Use modern way to set the C/CXX standard.

Works for me.

Oct 21 2019, 8:40 PM · Build System, Frameworks
aacid added a comment to D24841: Use modern way to set the C/CXX standard.

If you want to increase cmake dependency, we should at least increase it to 3.5

Oct 21 2019, 8:26 PM · Build System, Frameworks
dfaure requested changes to D24841: Use modern way to set the C/CXX standard.
Oct 21 2019, 8:19 PM · Build System, Frameworks
vonreth updated the diff for D24841: Use modern way to set the C/CXX standard.

CMAKE_CXX_STANDARD_REQUIRED

Oct 21 2019, 7:08 PM · Build System, Frameworks
vonreth updated the summary of D24841: Use modern way to set the C/CXX standard.
Oct 21 2019, 7:07 PM · Build System, Frameworks
vonreth added a comment to D24841: Use modern way to set the C/CXX standard.

I would also use CMAKE_CXX_STANDARD_REQUIRED to make sure the compiler actually *can* c++11, otherwise the flag is only added when the compiler supports it. Should not make much difference nowadays but since it's in ECM...

Oct 21 2019, 7:07 PM · Build System, Frameworks
chehrlic added a comment to D24841: Use modern way to set the C/CXX standard.

I would also use CMAKE_CXX_STANDARD_REQUIRED to make sure the compiler actually *can* c++11, otherwise the flag is only added when the compiler supports it. Should not make much difference nowadays but since it's in ECM...

Oct 21 2019, 7:05 PM · Build System, Frameworks
vonreth updated the diff for D24841: Use modern way to set the C/CXX standard.

Change message

Oct 21 2019, 7:04 PM · Build System, Frameworks
vonreth added reviewers for D24841: Use modern way to set the C/CXX standard: dfaure, cullmann.
Oct 21 2019, 7:03 PM · Build System, Frameworks
vonreth requested review of D24841: Use modern way to set the C/CXX standard.
Oct 21 2019, 7:02 PM · Build System, Frameworks
cullmann added a comment to D24826: Enforce 100 chars line width.

See the other task: columnlimit 0 leads to endless long lines and is a unusable default.

Oct 21 2019, 1:04 PM · Build System, Frameworks
winterz added a comment to D24826: Enforce 100 chars line width.

I am a long-time advocate of columnLimits; however, in our modern world of programming I think 100 is too short.

Oct 21 2019, 1:03 PM · Build System, Frameworks
zzag added a comment to D24826: Enforce 100 chars line width.

I suggest to set ColumnLimit to 0 by default and allow projects to override it.

Oct 21 2019, 12:55 PM · Build System, Frameworks
cullmann added a comment to D24826: Enforce 100 chars line width.

Perhaps easiest way to see what happens: apply it to one of your things and vary the value.

Oct 21 2019, 12:49 PM · Build System, Frameworks
cullmann added a comment to D24826: Enforce 100 chars line width.

It is unfortunately very brutal and in-deed, it can create very long lines if you have matching bad constructs.

Oct 21 2019, 12:46 PM · Build System, Frameworks