Feed Advanced Search

Tue, Aug 20

sitter added a comment to D23262: disable autouic again - it breaks builds.

https://gitlab.kitware.com/cmake/cmake/issues/19615

Tue, Aug 20, 9:01 AM · Build System, Frameworks

Mon, Aug 19

sitter closed D23262: disable autouic again - it breaks builds.
Mon, Aug 19, 2:30 PM · Build System, Frameworks
apol accepted D23262: disable autouic again - it breaks builds.

Thanks!

Mon, Aug 19, 2:29 PM · Build System, Frameworks
sitter abandoned D22805: set autorcc and autouic by default.

D23262

Mon, Aug 19, 2:02 PM · Build System, Frameworks
sitter requested review of D23262: disable autouic again - it breaks builds.
Mon, Aug 19, 2:01 PM · Build System, Frameworks
cullmann added a comment to D22805: set autorcc and autouic by default.

Yep, KTextEditor is broken for me, too.

Mon, Aug 19, 1:52 PM · Build System, Frameworks
nicolasfella requested changes to D22805: set autorcc and autouic by default.
Mon, Aug 19, 1:26 PM · Build System, Frameworks
nicolasfella reopened D22805: set autorcc and autouic by default.

This seems to cause the build of sonnet to fail: https://invent.kde.org/snippets/394

Mon, Aug 19, 1:26 PM · Build System, Frameworks
sitter closed D22805: set autorcc and autouic by default.
Mon, Aug 19, 1:04 PM · Build System, Frameworks
apol accepted D22805: set autorcc and autouic by default.

LGTM

Mon, Aug 19, 12:35 PM · Build System, Frameworks
sitter updated the diff for D22805: set autorcc and autouic by default.

typo--

Mon, Aug 19, 12:35 PM · Build System, Frameworks
sitter updated the diff for D22805: set autorcc and autouic by default.

bump version again

Mon, Aug 19, 12:23 PM · Build System, Frameworks

Thu, Aug 15

vkrause closed D23131: Define install location for JAR/AAR files for Android.
Thu, Aug 15, 4:24 PM · Build System, Frameworks

Wed, Aug 14

apol accepted D23131: Define install location for JAR/AAR files for Android.

Thanks!

Wed, Aug 14, 10:54 PM · Build System, Frameworks
kossebau added a comment to D22805: set autorcc and autouic by default.

Patch as is fine with me.
But no expert on both flags itself, no idea if there could be sideeffects of having those two now injected as ON to all projects. Possibly best to do global rebuilds of all projects on CI once this lands.

Wed, Aug 14, 3:04 PM · Build System, Frameworks
vkrause added a comment to D22805: set autorcc and autouic by default.

I'm happy with this, +2 from my side.

Wed, Aug 14, 2:02 PM · Build System, Frameworks
cgiboudeaux added a comment to D22805: set autorcc and autouic by default.

@kossebau @vkrause @apol something else to change?

Wed, Aug 14, 1:57 PM · Build System, Frameworks
cgiboudeaux set the repository for D22699: Support passing target to ecm_qt_declare_logging_category to R240 Extra CMake Modules.
Wed, Aug 14, 1:42 PM · Build System, Frameworks
cgiboudeaux added a comment to D22709: Support passing target to ecm_add_app_icon..

This shall be compliant with the minimum ECM version set in the project.

Wed, Aug 14, 1:40 PM · Frameworks, Build System

Tue, Aug 13

vkrause added reviewers for D23131: Define install location for JAR/AAR files for Android: Build System, Android.
Tue, Aug 13, 6:10 PM · Build System, Frameworks
vkrause requested review of D23131: Define install location for JAR/AAR files for Android.
Tue, Aug 13, 6:09 PM · Build System, Frameworks

Tue, Aug 6

hein abandoned D22958: Add initial Android support to ecm_add_app_icon.

Marco explained privately he doesn't want this so I'll move it to my codebase for now until the alternative better thing appears.

Tue, Aug 6, 9:10 AM · Build System, Frameworks
hein added a comment to D22958: Add initial Android support to ecm_add_app_icon.

Why do you restrict it to SVGs? Wouldn't you be able to use PNGs as well?

Tue, Aug 6, 8:59 AM · Build System, Frameworks
nicolasfella added a comment to D22958: Add initial Android support to ecm_add_app_icon.

Why do you restrict it to SVGs? Wouldn't you be able to use PNGs as well?

Tue, Aug 6, 7:51 AM · Build System, Frameworks
mart requested changes to D22958: Add initial Android support to ecm_add_app_icon.
Tue, Aug 6, 7:34 AM · Build System, Frameworks
hein added inline comments to D22958: Add initial Android support to ecm_add_app_icon.
Tue, Aug 6, 12:40 AM · Build System, Frameworks

Mon, Aug 5

apol added a comment to D22958: Add initial Android support to ecm_add_app_icon.

The patch makes sense. +1

Mon, Aug 5, 11:43 PM · Build System, Frameworks
hein added a comment to D22958: Add initial Android support to ecm_add_app_icon.

This is the culmination of a patch series that makes About dialogs in Kirigami work reasonably across platforms:

Mon, Aug 5, 9:42 PM · Build System, Frameworks
hein added a comment to D22958: Add initial Android support to ecm_add_app_icon.

The code is mostly copy-and-pasted together from ECMAddAppIcon.cmake and ECMInstallIcons.cmake.

Mon, Aug 5, 9:27 PM · Build System, Frameworks
hein requested review of D22958: Add initial Android support to ecm_add_app_icon.
Mon, Aug 5, 9:26 PM · Build System, Frameworks
daandemeyer added a comment to D22709: Support passing target to ecm_add_app_icon..

Ping

Mon, Aug 5, 6:01 PM · Frameworks, Build System
daandemeyer added a comment to D22699: Support passing target to ecm_qt_declare_logging_category.

Ping

Mon, Aug 5, 5:59 PM · Build System, Frameworks
kossebau closed D22724: Add ECMAddQtDesignerPlugin.
Mon, Aug 5, 5:17 PM · Build System, Frameworks

Thu, Aug 1

kossebau added a comment to D22724: Add ECMAddQtDesignerPlugin.

Seems people so far are fine with this, any comments were rather positive. No changes requested.

Thu, Aug 1, 2:58 PM · Build System, Frameworks

Wed, Jul 31

sitter updated the summary of D22805: set autorcc and autouic by default.
Wed, Jul 31, 10:31 AM · Build System, Frameworks
sitter updated the diff for D22805: set autorcc and autouic by default.

document behavior and when it was introduced, also enable autouic

Wed, Jul 31, 10:30 AM · Build System, Frameworks
sitter added a comment to D22805: set autorcc and autouic by default.

Indeed, both good points.

Wed, Jul 31, 9:22 AM · Build System, Frameworks

Mon, Jul 29

vkrause added a comment to D22805: set autorcc and autouic by default.

+1, same for AUTOUIC probably?

Mon, Jul 29, 2:47 PM · Build System, Frameworks
kossebau added inline comments to D22805: set autorcc and autouic by default.
Mon, Jul 29, 12:28 PM · Build System, Frameworks
sitter added inline comments to D22805: set autorcc and autouic by default.
Mon, Jul 29, 12:13 PM · Build System, Frameworks
kossebau added a comment to D22805: set autorcc and autouic by default.

Just a small principal comment with "supporting-old-versions" hat on.
Cannot give feedback on autorcc itself, never used, so no idea how useful/reliable it is.

Mon, Jul 29, 12:07 PM · Build System, Frameworks
sitter updated the summary of D22805: set autorcc and autouic by default.
Mon, Jul 29, 11:48 AM · Build System, Frameworks
apol added a comment to D22805: set autorcc and autouic by default.

+1 I've been using it in several project, it works good. I don't see how this could be misused.

Mon, Jul 29, 11:47 AM · Build System, Frameworks
sitter requested review of D22805: set autorcc and autouic by default.
Mon, Jul 29, 11:45 AM · Build System, Frameworks

Sun, Jul 28

apol added a comment to D22724: Add ECMAddQtDesignerPlugin.

+1 LGTM

Sun, Jul 28, 10:29 PM · Build System, Frameworks
kossebau added reviewers for D22724: Add ECMAddQtDesignerPlugin: Build System, Frameworks.
Sun, Jul 28, 7:53 PM · Build System, Frameworks
kossebau updated the diff for D22724: Add ECMAddQtDesignerPlugin.
  • escape strings to be used as strings in C++ code
  • use Qt5Core version to decide whether checking only for QtUiPlugin is enough
Sun, Jul 28, 12:00 PM · Build System, Frameworks
kossebau added a dependent revision for D22724: Add ECMAddQtDesignerPlugin: D22785: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON.
Sun, Jul 28, 11:55 AM · Build System, Frameworks
kossebau added a dependent revision for D22724: Add ECMAddQtDesignerPlugin: D22784: Deprecate kgendesignerplugin, drop bundle plugim for all KF5 widgets.
Sun, Jul 28, 11:00 AM · Build System, Frameworks

Sat, Jul 27

kossebau updated the diff for D22724: Add ECMAddQtDesignerPlugin.

add more options: DEFAULT_HEADER_CASE, DEFAULT_HEADER_EXTENSION, DEFAULT_ICON_DIR

Sat, Jul 27, 4:35 PM · Build System, Frameworks
kossebau added a dependent revision for D22724: Add ECMAddQtDesignerPlugin: D22778: Restore option to create a Qt Designer plugin.
Sat, Jul 27, 1:53 PM · Build System, Frameworks
daandemeyer updated the diff for D22699: Support passing target to ecm_qt_declare_logging_category.

Accidentally uploaded the wrong diff.

Sat, Jul 27, 12:54 PM · Build System, Frameworks
kossebau added a dependent revision for D22724: Add ECMAddQtDesignerPlugin: D22776: [WIP] Use ECMAddQtDesignerPlugin instead of KF5DesignerPlugin.
Sat, Jul 27, 12:37 PM · Build System, Frameworks
kossebau added a dependent revision for D22724: Add ECMAddQtDesignerPlugin: D22777: Use ECMAddQtDesignerPlugin instead of private copy.
Sat, Jul 27, 12:36 PM · Build System, Frameworks
kossebau updated the diff for D22724: Add ECMAddQtDesignerPlugin.
  • more code comments
  • fix icon file existance check
Sat, Jul 27, 12:26 PM · Build System, Frameworks

Fri, Jul 26

kossebau updated the diff for D22724: Add ECMAddQtDesignerPlugin.
  • API DOX: explain arguments
  • add argument to make it work for Okteta's extra code
  • avoid rebuilding if generated file did not change
  • place generated files in subdir for namespacing
Fri, Jul 26, 4:48 PM · Build System, Frameworks

Thu, Jul 25

apol closed D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Thu, Jul 25, 12:28 PM · Build System, Frameworks

Wed, Jul 24

daandemeyer updated the diff for D22699: Support passing target to ecm_qt_declare_logging_category.

Update CMake minimum required version to 3.1 (for target_sources).

Wed, Jul 24, 6:20 PM · Build System, Frameworks
kossebau added a dependent revision for D22724: Add ECMAddQtDesignerPlugin: D22725: Add option to build Qt Designer plugin (BUILD_DESIGNERPLUGIN, default ON.
Wed, Jul 24, 6:08 PM · Build System, Frameworks
kossebau updated the summary of D22724: Add ECMAddQtDesignerPlugin.
Wed, Jul 24, 6:07 PM · Build System, Frameworks
kossebau requested review of D22724: Add ECMAddQtDesignerPlugin.
Wed, Jul 24, 6:06 PM · Build System, Frameworks
daandemeyer added a comment to D22699: Support passing target to ecm_qt_declare_logging_category.

I

Wed, Jul 24, 12:21 PM · Build System, Frameworks
cgiboudeaux added inline comments to D22699: Support passing target to ecm_qt_declare_logging_category.
Wed, Jul 24, 11:35 AM · Build System, Frameworks
daandemeyer added inline comments to D22699: Support passing target to ecm_qt_declare_logging_category.
Wed, Jul 24, 11:18 AM · Build System, Frameworks
cgiboudeaux added inline comments to D22699: Support passing target to ecm_qt_declare_logging_category.
Wed, Jul 24, 7:45 AM · Build System, Frameworks
cgiboudeaux added inline comments to D22699: Support passing target to ecm_qt_declare_logging_category.
Wed, Jul 24, 7:44 AM · Build System, Frameworks
daandemeyer requested review of D22709: Support passing target to ecm_add_app_icon..
Wed, Jul 24, 7:30 AM · Frameworks, Build System

Tue, Jul 23

daandemeyer added a comment to D22699: Support passing target to ecm_qt_declare_logging_category.

I'm not sure if its beneficial to use cmake_parse_arguments here. It seems like it would make the macro harder to understand compared to the current change. I'm also not entirely sure how it would work? I haven't worked with cmake_parse_arguments before.

Tue, Jul 23, 9:51 PM · Build System, Frameworks
apol added a comment to D22699: Support passing target to ecm_qt_declare_logging_category.

How about pass it as a TARGET argument using CMakeParseArguments.
You can see documentation about it here: https://cmake.org/cmake/help/latest/command/cmake_parse_arguments.html

Tue, Jul 23, 9:31 PM · Build System, Frameworks
daandemeyer requested review of D22699: Support passing target to ecm_qt_declare_logging_category.
Tue, Jul 23, 8:27 PM · Build System, Frameworks
apol closed D22676: Provide a more sensible CMAKE_INSTALL_PREFIX default.
Tue, Jul 23, 1:55 PM · Build System, Frameworks
cgiboudeaux accepted D22676: Provide a more sensible CMAKE_INSTALL_PREFIX default.

LGTM

Tue, Jul 23, 1:50 PM · Build System, Frameworks
apol updated the diff for D22676: Provide a more sensible CMAKE_INSTALL_PREFIX default.

address cgiboudeaux's comments

Tue, Jul 23, 1:49 PM · Build System, Frameworks
apol added a comment to D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.

KDE_INSTALL_USE_QT_SYS_PATHS has no effect on XDG_CONFIG_DIRS and XDG_DATA_DIRS or even the binary installation dir.

Running prefix.sh is useful even if KDE_INSTALL_USE_QT_SYS_PATHS is true.

Tue, Jul 23, 11:02 AM · Build System, Frameworks
dfaure closed D22667: Make the default build type "Debug" when compiling a git checkout..
Tue, Jul 23, 10:46 AM · Build System, Frameworks
cgiboudeaux accepted D22667: Make the default build type "Debug" when compiling a git checkout..

Good idea

Tue, Jul 23, 10:39 AM · Build System, Frameworks
cgiboudeaux added inline comments to D22676: Provide a more sensible CMAKE_INSTALL_PREFIX default.
Tue, Jul 23, 9:52 AM · Build System, Frameworks
apol requested review of D22676: Provide a more sensible CMAKE_INSTALL_PREFIX default.
Tue, Jul 23, 9:16 AM · Build System, Frameworks

Jul 22 2019

apol added a comment to D22667: Make the default build type "Debug" when compiling a git checkout..

+1 Makes a lot of sense to me. In KDevelop we are already setting Debug by default.

Jul 22 2019, 10:24 PM · Build System, Frameworks
dfaure requested review of D22667: Make the default build type "Debug" when compiling a git checkout..
Jul 22 2019, 10:21 PM · Build System, Frameworks

Jul 21 2019

aacid closed D19005: android: don't default to gcc anymore.

Talked with Aleix, we're deciding to drop this for the moment

Jul 21 2019, 5:37 PM · Build System, Frameworks
cgiboudeaux added a comment to D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.

KDE_INSTALL_USE_QT_SYS_PATHS has no effect on XDG_CONFIG_DIRS and XDG_DATA_DIRS or even the binary installation dir.

Jul 21 2019, 9:28 AM · Build System, Frameworks
cgiboudeaux accepted D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Jul 21 2019, 9:12 AM · Build System, Frameworks
apol updated the diff for D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.

Support older cmakes

Jul 21 2019, 9:04 AM · Build System, Frameworks

Jul 20 2019

cgiboudeaux added inline comments to D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Jul 20 2019, 3:26 PM · Build System, Frameworks
albertvaka accepted D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Jul 20 2019, 12:53 PM · Build System, Frameworks
apol updated the diff for D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.

Improve wording

Jul 20 2019, 12:49 PM · Build System, Frameworks
albertvaka added inline comments to D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Jul 20 2019, 12:47 PM · Build System, Frameworks
apol requested review of D22580: Notify users when not using KDE_INSTALL_USE_QT_SYS_PATHS about prefix.sh.
Jul 20 2019, 12:14 PM · Build System, Frameworks

Jul 9 2019

apol added a comment to D22317: Fix type names casing.

Just out of curiosity, why don't you use the cmake toolchain from Android NDK ? is located in ndk-bundle/build/cmake/android.toolchain.cmake

Jul 9 2019, 3:07 PM · Build System, Frameworks
vatra added a comment to D22317: Fix type names casing.

Just out of curiosity, why don't you use the cmake toolchain from Android NDK ? is located in ndk-bundle/build/cmake/android.toolchain.cmake

Jul 9 2019, 5:48 AM · Build System, Frameworks

Jul 8 2019

apol closed D22317: Fix type names casing.
Jul 8 2019, 11:50 AM · Build System, Frameworks
vkrause accepted D22317: Fix type names casing.
Jul 8 2019, 6:50 AM · Build System, Frameworks
apol requested review of D22317: Fix type names casing.
Jul 8 2019, 12:28 AM · Build System, Frameworks

Jun 29 2019

zzag abandoned D22156: RFC: Add wayland-protocols find module.

how many users are there?

Jun 29 2019, 6:46 PM · Build System, Frameworks
cgiboudeaux added a comment to D22156: RFC: Add wayland-protocols find module.

how many users are there?

Jun 29 2019, 6:34 PM · Build System, Frameworks
apol added a comment to D22156: RFC: Add wayland-protocols find module.

LGTM +1

Jun 29 2019, 5:36 PM · Build System, Frameworks
zzag retitled D22156: RFC: Add wayland-protocols find module from Add wayland-protocols find module to RFC: Add wayland-protocols find module.
Jun 29 2019, 2:09 PM · Build System, Frameworks
zzag requested review of D22156: RFC: Add wayland-protocols find module.
Jun 29 2019, 2:06 PM · Build System, Frameworks

Jun 17 2019

vkrause added a comment to D19996: WIP Add a global test for insecure http: URLs used in code or documentation.

Any chance this could not be done by abusing KDECMakeSettings.cmake as injection vector?

Jun 17 2019, 6:07 PM · Build System, Frameworks