xuetianweng (Xuetian Weng)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Saturday

  • Clear sailing ahead.

User Details

User Since
Feb 27 2016, 6:35 PM (226 w, 4 d)
Availability
Available

Recent Activity

Fri, Jun 26

xuetianweng closed T13320: Port kimpanel away from dataengines, a subtask of T13319: Port system tray away from SNI dataengine, as Resolved.
Fri, Jun 26, 7:25 PM · Plasma 6
xuetianweng closed T13320: Port kimpanel away from dataengines as Resolved.
Fri, Jun 26, 7:25 PM · Plasma 6
xuetianweng claimed T13320: Port kimpanel away from dataengines.
Fri, Jun 26, 7:20 PM · Plasma 6

May 27 2020

xuetianweng committed R119:67d89ffca489: kimpanel: use spread operator to do substring based on ucs4 char. (authored by xuetianweng).
kimpanel: use spread operator to do substring based on ucs4 char.
May 27 2020, 5:18 AM

May 26 2020

xuetianweng added a comment to D29668: Do not reject icon theme dir with invalid context/type..

You can try to install one from your distro to check the actual content. index.theme is generated during the "configure & make".

May 26 2020, 3:33 PM · Frameworks
xuetianweng added a comment to D29668: Do not reject icon theme dir with invalid context/type..

What are the values of Context and Type?

"Legacy" and "UI" ?

I can't see anything in index.theme https://ftp.gnome.org/pub/GNOME/sources/adwaita-icon-theme/3.36/

May 26 2020, 3:31 PM · Frameworks

May 23 2020

xuetianweng committed R119:3b6df91d7f59: Merge remote-tracking branch 'origin/Plasma/5.19' (authored by xuetianweng).
Merge remote-tracking branch 'origin/Plasma/5.19'
May 23 2020, 2:41 PM
xuetianweng committed R119:cc89c2e09984: [kimpanel] Make candidate index more visible. (authored by xuetianweng).
[kimpanel] Make candidate index more visible.
May 23 2020, 2:41 PM

May 17 2020

xuetianweng added a comment to D29789: Make text always align with font base line.

I like this patch. In fact, I observed over the past years again and again that sometimes, especially if chinese or similar letters are included, the baseline is wrong in Kate, leading to much more overpainting that needed.
If this patch fixes this, then I'm all for it. Or let's put it like this: The current implementation is wrong, this patch looks less wrong than the current state :-)

+1

May 17 2020, 5:28 PM · Frameworks, Kate

May 15 2020

xuetianweng added a comment to D29789: Make text always align with font base line.

This is my another try as an alternative solution to D25339. Actually this works surprisingly good IMHO, at least for CJK users for most cases.

May 15 2020, 11:42 PM · Frameworks, Kate
xuetianweng updated the summary of D29789: Make text always align with font base line.
May 15 2020, 11:41 PM · Frameworks, Kate
xuetianweng requested review of D29789: Make text always align with font base line.
May 15 2020, 11:38 PM · Frameworks, Kate
xuetianweng added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

Actually I was trying to use this approach in the patch because I was afraid that variable line height may need to estimate the whole document height to make scroll work correctly.

May 15 2020, 11:01 PM · Frameworks, Kate

May 11 2020

xuetianweng updated the test plan for D29668: Do not reject icon theme dir with invalid context/type..
May 11 2020, 8:52 PM · Frameworks
xuetianweng added reviewers for D29668: Do not reject icon theme dir with invalid context/type.: dfaure, apol.
May 11 2020, 8:52 PM · Frameworks
xuetianweng updated the test plan for D29668: Do not reject icon theme dir with invalid context/type..
May 11 2020, 8:51 PM · Frameworks
xuetianweng requested review of D29668: Do not reject icon theme dir with invalid context/type..
May 11 2020, 8:50 PM · Frameworks

May 7 2020

xuetianweng added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

With "we've ever seen" you do mean that lineheight only changes when a line that requires it scrolls into view?

Though line height won't shrink during the edit phase, it will back to the actual value upon save.

Have you tried to reset the max. lineheight on each redraw (I presume the scrollbars could give you a signal that a view scroll/jump was initiated, if need be).
Something tells me that it'd be nicer if lineheight always is as small as possible. Imagine you're using a smallish window to edit a document that just has some of these "offending", much higher characters at the bottom. If it gets into view only once, lineheight increases and it's as if you lose a lot of screen estate until you save the document. Now I mustn't be the only one who often doesn't save for a while, esp. when doing things like moving blocks of text around, and it's exactly in that kind of scenario where having to save to get a more space-efficient rendering back can be very annoying.

As long as you can determine the max. lineheight required for the view that's about to be drawn before the view is actually drawn there should be no glitches. You'd just see a jump in lineheight and there would probably be an interesting problem to tackle with edge cases where the higher glyphs fall outside the view area because of the increased lineheight, but that's something your current implementation cannot avoid completely either. As to the changing lineheight: I think users will understand why it happens and get used to it. It's comparable to what you see in graphics programmes that show cursor co-ordinates next to the cursor; that indicator has to jump when it would get "pushed out" of the view, and that doesn't even feel weird.

I presume your new approach would work not just for CJK characters, but also for anything else that changes the lineheight. That's and advantage but could also lead to regressions for some (who never use CJK characters or who, like me, wouldn't care how they display because they can't read them anyway). Emoticons come to mind; here too I don't really care if they get cut off. Scrap that, I *really* don't care if they are...

May 7 2020, 5:48 PM · Frameworks, Kate
xuetianweng updated the test plan for D25339: update lineHeight if boundingRect indicates a larger value..
May 7 2020, 5:37 AM · Frameworks, Kate
xuetianweng added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

I'm not sure if this is the right way to do it or it might cause any glitch, but here we go. Upon line rendering, update the maximum height we've ever seen.

May 7 2020, 5:36 AM · Frameworks, Kate
xuetianweng updated the diff for D25339: update lineHeight if boundingRect indicates a larger value..

Use actual line height instead of representitive character.

May 7 2020, 5:33 AM · Frameworks, Kate
xuetianweng added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

I second the as-an-option proposal. Hey, why not automatically increase the line height when CJK characters are detected?

May 7 2020, 4:32 AM · Frameworks, Kate

May 4 2020

xuetianweng committed R240:8d181637a033: Suppress find_package_handle_standard_args package name mismatch warning. (authored by xuetianweng).
Suppress find_package_handle_standard_args package name mismatch warning.
May 4 2020, 3:35 PM
xuetianweng closed D29396: Suppress find_package_handle_standard_args package name mismatch warning..
May 4 2020, 3:35 PM · Build System, Frameworks
xuetianweng requested review of D29396: Suppress find_package_handle_standard_args package name mismatch warning..
May 4 2020, 1:27 AM · Build System, Frameworks

Apr 20 2020

xuetianweng committed R169:f9d31febf87e: Update the visiblity check for ActionToolbar by checking width with less… (authored by xuetianweng).
Update the visiblity check for ActionToolbar by checking width with less…
Apr 20 2020, 8:55 PM
xuetianweng closed D29022: Update the visiblity check for ActionToolbar by checking width with less-"equal"..
Apr 20 2020, 8:55 PM · Kirigami
xuetianweng retitled D29022: Update the visiblity check for ActionToolbar by checking width with less-"equal". from Update the check for ActionToolbar by checking with less-"equal". to Update the visiblity check for ActionToolbar by checking width with less-"equal"..
Apr 20 2020, 7:45 PM · Kirigami
xuetianweng requested review of D29022: Update the visiblity check for ActionToolbar by checking width with less-"equal"..
Apr 20 2020, 7:43 PM · Kirigami
xuetianweng committed R858:aa57b34f75f0: Detect QQC2 version at build time with actual detection. (authored by xuetianweng).
Detect QQC2 version at build time with actual detection.
Apr 20 2020, 1:59 PM
xuetianweng closed D28859: Detect QQC2 version at build time with actual detection..
Apr 20 2020, 1:59 PM · Plasma
xuetianweng added a comment to D28859: Detect QQC2 version at build time with actual detection..

So the problem we're solving is that we want to go

Qt5.12 - QQC2.5
Qt5.13 - QQC2.6
Qt5.14 - QQC2.7
Qt5.15 - QQC2.15

correct?

We now know all Qt5 versions, and we know that Qt6 won't have versions.

I don't see why need this complicated thing instead of an "if" statement on Qt5QuickControls2_VERSION_MINOR

Just to correct it, the change is since 5.12.
5.11 -> 5.4
5.12 -> 5.12

Apr 20 2020, 1:33 PM · Plasma
xuetianweng updated the diff for D28859: Detect QQC2 version at build time with actual detection..

Just fix the version by if-else check.

Apr 20 2020, 1:30 PM · Plasma
xuetianweng updated the diff for D25339: update lineHeight if boundingRect indicates a larger value..

Fix the blank text issue by alway setLineWidth.

Apr 20 2020, 1:28 AM · Frameworks, Kate
xuetianweng updated the diff for D25339: update lineHeight if boundingRect indicates a larger value..

Clean up the code a little bit and adding comments. Also fix a small bug if m_fontHeight has
big difference with m_fontMetrics's height.

Apr 20 2020, 12:45 AM · Frameworks, Kate

Apr 19 2020

xuetianweng added a comment to D28859: Detect QQC2 version at build time with actual detection..

ping? :)

Apr 19 2020, 11:56 PM · Plasma
xuetianweng added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

Hmm, after applying this patch, for me, no text is visible at all.
By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of ktexteditor toplevel dir).

Apr 19 2020, 6:37 PM · Frameworks, Kate
xuetianweng added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

Hmm, after applying this patch, for me, no text is visible at all.
By selecting a bit stuff, one at least sees an outline (CMakeLists.txt of ktexteditor toplevel dir).

Apr 19 2020, 5:44 PM · Frameworks, Kate

Apr 18 2020

xuetianweng added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

Add a screenshot to demostrate the change.

Apr 18 2020, 5:23 AM · Frameworks, Kate
xuetianweng updated the diff for D25339: update lineHeight if boundingRect indicates a larger value..

Fix the handling when layout formats has background.

Apr 18 2020, 5:22 AM · Frameworks, Kate
xuetianweng added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

Actually, I could live with:

  1. All lines are a bit higher, for me that makes reading even easier. But the rendering shall have no glitches.
  2. Some lines have different heights. But I assume this is hard to implement at the moment.
Apr 18 2020, 12:35 AM · Frameworks, Kate
xuetianweng updated the diff for D25339: update lineHeight if boundingRect indicates a larger value..

handle the range with multiple lines.

Apr 18 2020, 12:34 AM · Frameworks, Kate

Apr 17 2020

xuetianweng updated the diff for D25339: update lineHeight if boundingRect indicates a larger value..

Try to fill the gap if we increase the line height with representitive char.

Apr 17 2020, 10:57 PM · Frameworks, Kate

Apr 15 2020

xuetianweng added a comment to D28859: Detect QQC2 version at build time with actual detection..

I don't understand.

We're still running this at compile time, so what's the practical difference?

Apr 15 2020, 9:02 PM · Plasma
xuetianweng updated the diff for D28859: Detect QQC2 version at build time with actual detection..

fix header

Apr 15 2020, 7:36 PM · Plasma
xuetianweng requested review of D28859: Detect QQC2 version at build time with actual detection..
Apr 15 2020, 7:35 PM · Plasma

Nov 25 2019

xuetianweng closed T12260: Change nameservers of kde-china.org as Resolved.

Done.

Nov 25 2019, 7:26 PM · Sysadmin

Nov 17 2019

xuetianweng added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

Any idea about how konsole derive the value?.. I'm not so sure if they did a better job (probably not because IIRC I have seen similar issue in konsole).

Nov 17 2019, 8:42 PM · Frameworks, Kate

Nov 16 2019

xuetianweng added reviewers for D25339: update lineHeight if boundingRect indicates a larger value.: cullmann, dhaumann.
Nov 16 2019, 5:32 PM · Frameworks, Kate
xuetianweng added a comment to D25339: update lineHeight if boundingRect indicates a larger value..

Add screenshot to demonstrate the problem.

Nov 16 2019, 5:30 PM · Frameworks, Kate
xuetianweng updated the diff for D25339: update lineHeight if boundingRect indicates a larger value..

Add comment about the actual characters.

Nov 16 2019, 5:21 PM · Frameworks, Kate
xuetianweng requested review of D25339: update lineHeight if boundingRect indicates a larger value..
Nov 16 2019, 5:19 PM · Frameworks, Kate

Nov 7 2019

xuetianweng committed R257:d2d0d1ae87b6: Bump fcitx-qt5 version to support new flatpak. (authored by xuetianweng).
Bump fcitx-qt5 version to support new flatpak.
Nov 7 2019, 3:57 PM
xuetianweng committed R257:1a542740b144: Bump fcitx-qt5 version to support new flatpak. (authored by xuetianweng).
Bump fcitx-qt5 version to support new flatpak.
Nov 7 2019, 3:28 PM
xuetianweng closed D25188: Bump fcitx-qt5 version to support new flatpak..
Nov 7 2019, 3:28 PM
xuetianweng requested review of D25188: Bump fcitx-qt5 version to support new flatpak..
Nov 7 2019, 9:25 AM

Aug 11 2019

xuetianweng requested changes to D22535: Make kimpanel a system tray applet.

This change doesn't serve any real functionality of kimpanel. It doesn't show the current input method in tray, doesn't hide or show up. And kimpanel usually consist multiple icons. While it's doubt whether we need that much for certain input method (currently user can blacklist some by hand), but being able to show some important ones should not be removed. (on windows, there're two icon for chinese case).

Aug 11 2019, 4:23 PM · Plasma

Aug 5 2019

xuetianweng committed R487:e8bc877aa863: Merge branch 'Plasma/5.12' (authored by xuetianweng).
Merge branch 'Plasma/5.12'
Aug 5 2019, 12:12 PM

Jan 3 2019

xuetianweng committed R119:3862d8530377: kimpanel: check engine_desc before use (authored by xuetianweng).
kimpanel: check engine_desc before use
Jan 3 2019, 8:15 PM

Jul 22 2018

xuetianweng committed R498:a2545337315c: update path for kde-cn (authored by xuetianweng).
update path for kde-cn
Jul 22 2018, 7:38 PM

Jun 6 2018

xuetianweng abandoned D3829: [touchpad] Use a separate X11 Display to monitor the XInput event..
Jun 6 2018, 12:15 AM · Plasma

Mar 13 2018

xuetianweng committed R119:d5d937818ab8: Merge branch 'Plasma/5.12' (authored by xuetianweng).
Merge branch 'Plasma/5.12'
Mar 13 2018, 6:05 AM
xuetianweng committed R119:7d3ffa0400ed: kimpanel: Fix the window positioning when plasma uses native-qt scaling. (authored by xuetianweng).
kimpanel: Fix the window positioning when plasma uses native-qt scaling.
Mar 13 2018, 6:05 AM

Mar 7 2018

xuetianweng added a comment to D11061: Migration request from IBusConfig to GSettings .

Not so sure why phabricator didn't set you as the commit author... sorry about that.

Mar 7 2018, 5:37 PM · Plasma
xuetianweng committed R119:e2a29f8ea072: Migration request from IBusConfig to GSettings (authored by xuetianweng).
Migration request from IBusConfig to GSettings
Mar 7 2018, 5:36 PM
xuetianweng closed D11061: Migration request from IBusConfig to GSettings .
Mar 7 2018, 5:36 PM · Plasma
xuetianweng accepted D11061: Migration request from IBusConfig to GSettings .
Mar 7 2018, 5:25 PM · Plasma
xuetianweng added inline comments to D11061: Migration request from IBusConfig to GSettings .
Mar 7 2018, 9:25 AM · Plasma

Mar 6 2018

xuetianweng requested changes to D11061: Migration request from IBusConfig to GSettings .
Mar 6 2018, 12:50 PM · Plasma
xuetianweng added a comment to D11061: Migration request from IBusConfig to GSettings .

FWIW, there's a lovely Qt-GConf wrapper in plasma-pa/gconfitem

Mar 6 2018, 12:42 PM · Plasma
xuetianweng requested changes to D11061: Migration request from IBusConfig to GSettings .
Mar 6 2018, 3:43 AM · Plasma
xuetianweng added inline comments to D11061: Migration request from IBusConfig to GSettings .
Mar 6 2018, 3:43 AM · Plasma
xuetianweng added a comment to D11061: Migration request from IBusConfig to GSettings .

May I ask when this gsettings is introduced? Is it required after certain ibus version? Is there any case that this will not work?

Mar 6 2018, 3:18 AM · Plasma

Feb 14 2018

xuetianweng accepted D10498: Workaround the touchpad toggle button not working.

I sent the comment before you corrected the diff branch. LGTM.

Feb 14 2018, 12:20 AM · Plasma
xuetianweng accepted D10498: Workaround the touchpad toggle button not working.

Oh, ok.. now the diff looks normal.

Feb 14 2018, 12:17 AM · Plasma
xuetianweng added a comment to D10498: Workaround the touchpad toggle button not working.

Emm, mind to get rid of the .desktop part for this review?

Feb 14 2018, 12:15 AM · Plasma

Jan 6 2018

xuetianweng committed R119:60bc30083fe4: Plasma change icons should exit after its work finished. (authored by xuetianweng).
Plasma change icons should exit after its work finished.
Jan 6 2018, 5:54 PM
xuetianweng closed D8529: Plasma change icons should exit after its work finished..
Jan 6 2018, 5:54 PM · Plasma

Jan 5 2018

xuetianweng added a comment to D8529: Plasma change icons should exit after its work finished..

Good to go, no?

Jan 5 2018, 12:38 AM · Plasma

Dec 4 2017

xuetianweng committed R119:ec352304d357: Add xf86-input-libinput support for X11 mouse backend. (authored by xuetianweng).
Add xf86-input-libinput support for X11 mouse backend.
Dec 4 2017, 10:23 PM
xuetianweng closed D8798: Add xf86-input-libinput support for X11 mouse backend..
Dec 4 2017, 10:23 PM · Plasma
xuetianweng added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..
In D8798#175698, @subdiff wrote:

Sorry for the long delay on a review.

Can you give a short overview on how the switching works between Xlib and libinput backend on X? So what's the runtime detection if libinput is available or not? Somebody above said mouse kcm is not available without libinput anymore with this patch. But this should not happen of course.

Naming the config option Pointer Acceleration is problematic, because libinput names another property "pointer acceleration". I think we should not change the name. Unneeded deviation from upstream. Maybe better add a tooltip with a description if people complain.

In the touchpad kcm the backends for libinput and xlib are in different files (in the same backend/x11 subfolder). Is this possible here as well?

Dec 4 2017, 10:22 PM · Plasma
xuetianweng added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..
In D8798#175698, @subdiff wrote:

Sorry for the long delay on a review.

Can you give a short overview on how the switching works between Xlib and libinput backend on X? So what's the runtime detection if libinput is available or not? Somebody above said mouse kcm is not available without libinput anymore with this patch. But this should not happen of course.

Naming the config option Pointer Acceleration is problematic, because libinput names another property "pointer acceleration". I think we should not change the name. Unneeded deviation from upstream. Maybe better add a tooltip with a description if people complain.

In the touchpad kcm the backends for libinput and xlib are in different files (in the same backend/x11 subfolder). Is this possible here as well?

Dec 4 2017, 10:13 PM · Plasma

Nov 27 2017

xuetianweng added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..

@jriddell ping?

Nov 27 2017, 4:09 AM · Plasma

Nov 22 2017

xuetianweng committed R257:73f8cc2c1694: Include fcitx's platform input context in runtime. (authored by xuetianweng).
Include fcitx's platform input context in runtime.
Nov 22 2017, 10:32 PM
xuetianweng closed D8739: Include fcitx's platform input context in runtime..
Nov 22 2017, 10:32 PM
xuetianweng added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..

This disables the input kcm if libinput x11 plugin is not found. I expect this is fine, it is for ubuntu distros at least, but it might be worth asking distros if it causes them a problem.

Nov 22 2017, 7:04 PM · Plasma
xuetianweng updated the diff for D8798: Add xf86-input-libinput support for X11 mouse backend..

revert the accidentally changed currentIndex in ui file when save in designer.

Nov 22 2017, 6:59 PM · Plasma
xuetianweng added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..

Whether it shows up reallys depends on your system. Especially when there's multiple mouse driver available and you may using evdev.

Nov 22 2017, 6:57 PM · Plasma
xuetianweng added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..

@apol got a chance to test it?

Nov 22 2017, 2:41 AM · Plasma

Nov 21 2017

xuetianweng added a comment to D8739: Include fcitx's platform input context in runtime..

Also just FYI, My PR of fcitx's gtk im module recently got merged to freedesktop runtime. https://github.com/flatpak/freedesktop-sdk-images/pull/58

Nov 21 2017, 11:04 PM

Nov 17 2017

xuetianweng added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..
In D8798#169156, @apol wrote:
$ kcmshell5 touchpad
kcm_touchpad: Using X11 backend

The file on disk is at /usr/lib/x86_64-linux-gnu/qt5/plugins/kded_touchpad.so (on KDE Neon and other Ubuntu-based distros)

Are you sure? because this is modifying files in kcms/input that creates a kcm_input.so... Is it a kcm that extends kcm_touchpad.so?

Nov 17 2017, 9:37 PM · Plasma
xuetianweng updated the diff for D8798: Add xf86-input-libinput support for X11 mouse backend..

Fix based on comment

Nov 17 2017, 7:28 PM · Plasma

Nov 16 2017

xuetianweng committed R119:44d8a7500e36: Resolve the input method issue by always force focus in search field. (authored by xuetianweng).
Resolve the input method issue by always force focus in search field.
Nov 16 2017, 11:28 PM
xuetianweng closed D8770: Resolve the input method issue by always force focus in search field..
Nov 16 2017, 11:28 PM · Plasma

Nov 13 2017

xuetianweng committed R120:55a8d72e9786: Use heuristic weighted length algorithm to calculate the query term length. (authored by xuetianweng).
Use heuristic weighted length algorithm to calculate the query term length.
Nov 13 2017, 7:42 PM
xuetianweng closed D8771: Use heuristic weighted length algorithm to calculate the query term length..
Nov 13 2017, 7:42 PM · Plasma
xuetianweng updated the diff for D8771: Use heuristic weighted length algorithm to calculate the query term length..

Use the new kcoreaddons function to cal the length.

Nov 13 2017, 7:32 PM · Plasma
xuetianweng committed R244:6758d45cb596: Add a new function to measure the length by text. (authored by xuetianweng).
Add a new function to measure the length by text.
Nov 13 2017, 7:21 PM
xuetianweng closed D8800: Add a new function to measure the length by text..
Nov 13 2017, 7:21 PM · Frameworks