xuetianweng (Xuetian Weng)
User

Projects

User does not belong to any projects.

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Feb 27 2016, 6:35 PM (172 w, 5 h)
Availability
Available

Recent Activity

Jan 3 2019

xuetianweng committed R119:3862d8530377: kimpanel: check engine_desc before use (authored by xuetianweng).
kimpanel: check engine_desc before use
Jan 3 2019, 8:15 PM

Jul 22 2018

xuetianweng committed R498:a2545337315c: update path for kde-cn (authored by xuetianweng).
update path for kde-cn
Jul 22 2018, 7:38 PM

Jun 6 2018

xuetianweng abandoned D3829: [touchpad] Use a separate X11 Display to monitor the XInput event..
Jun 6 2018, 12:15 AM · Plasma

Mar 13 2018

xuetianweng committed R119:d5d937818ab8: Merge branch 'Plasma/5.12' (authored by xuetianweng).
Merge branch 'Plasma/5.12'
Mar 13 2018, 6:05 AM
xuetianweng committed R119:7d3ffa0400ed: kimpanel: Fix the window positioning when plasma uses native-qt scaling. (authored by xuetianweng).
kimpanel: Fix the window positioning when plasma uses native-qt scaling.
Mar 13 2018, 6:05 AM

Mar 7 2018

xuetianweng added a comment to D11061: Migration request from IBusConfig to GSettings .

Not so sure why phabricator didn't set you as the commit author... sorry about that.

Mar 7 2018, 5:37 PM · Plasma
xuetianweng committed R119:e2a29f8ea072: Migration request from IBusConfig to GSettings (authored by xuetianweng).
Migration request from IBusConfig to GSettings
Mar 7 2018, 5:36 PM
xuetianweng closed D11061: Migration request from IBusConfig to GSettings .
Mar 7 2018, 5:36 PM · Plasma
xuetianweng accepted D11061: Migration request from IBusConfig to GSettings .
Mar 7 2018, 5:25 PM · Plasma
xuetianweng added inline comments to D11061: Migration request from IBusConfig to GSettings .
Mar 7 2018, 9:25 AM · Plasma

Mar 6 2018

xuetianweng requested changes to D11061: Migration request from IBusConfig to GSettings .
Mar 6 2018, 12:50 PM · Plasma
xuetianweng added a comment to D11061: Migration request from IBusConfig to GSettings .

FWIW, there's a lovely Qt-GConf wrapper in plasma-pa/gconfitem

Mar 6 2018, 12:42 PM · Plasma
xuetianweng requested changes to D11061: Migration request from IBusConfig to GSettings .
Mar 6 2018, 3:43 AM · Plasma
xuetianweng added inline comments to D11061: Migration request from IBusConfig to GSettings .
Mar 6 2018, 3:43 AM · Plasma
xuetianweng added a comment to D11061: Migration request from IBusConfig to GSettings .

May I ask when this gsettings is introduced? Is it required after certain ibus version? Is there any case that this will not work?

Mar 6 2018, 3:18 AM · Plasma

Feb 14 2018

xuetianweng accepted D10498: Workaround the touchpad toggle button not working.

I sent the comment before you corrected the diff branch. LGTM.

Feb 14 2018, 12:20 AM · Plasma
xuetianweng accepted D10498: Workaround the touchpad toggle button not working.

Oh, ok.. now the diff looks normal.

Feb 14 2018, 12:17 AM · Plasma
xuetianweng added a comment to D10498: Workaround the touchpad toggle button not working.

Emm, mind to get rid of the .desktop part for this review?

Feb 14 2018, 12:15 AM · Plasma

Jan 6 2018

xuetianweng committed R119:60bc30083fe4: Plasma change icons should exit after its work finished. (authored by xuetianweng).
Plasma change icons should exit after its work finished.
Jan 6 2018, 5:54 PM
xuetianweng closed D8529: Plasma change icons should exit after its work finished..
Jan 6 2018, 5:54 PM · Plasma

Jan 5 2018

xuetianweng added a comment to D8529: Plasma change icons should exit after its work finished..

Good to go, no?

Jan 5 2018, 12:38 AM · Plasma

Dec 4 2017

xuetianweng committed R119:ec352304d357: Add xf86-input-libinput support for X11 mouse backend. (authored by xuetianweng).
Add xf86-input-libinput support for X11 mouse backend.
Dec 4 2017, 10:23 PM
xuetianweng closed D8798: Add xf86-input-libinput support for X11 mouse backend..
Dec 4 2017, 10:23 PM · Plasma
xuetianweng added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..
In D8798#175698, @subdiff wrote:

Sorry for the long delay on a review.

Can you give a short overview on how the switching works between Xlib and libinput backend on X? So what's the runtime detection if libinput is available or not? Somebody above said mouse kcm is not available without libinput anymore with this patch. But this should not happen of course.

Naming the config option Pointer Acceleration is problematic, because libinput names another property "pointer acceleration". I think we should not change the name. Unneeded deviation from upstream. Maybe better add a tooltip with a description if people complain.

In the touchpad kcm the backends for libinput and xlib are in different files (in the same backend/x11 subfolder). Is this possible here as well?

Dec 4 2017, 10:22 PM · Plasma
xuetianweng added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..
In D8798#175698, @subdiff wrote:

Sorry for the long delay on a review.

Can you give a short overview on how the switching works between Xlib and libinput backend on X? So what's the runtime detection if libinput is available or not? Somebody above said mouse kcm is not available without libinput anymore with this patch. But this should not happen of course.

Naming the config option Pointer Acceleration is problematic, because libinput names another property "pointer acceleration". I think we should not change the name. Unneeded deviation from upstream. Maybe better add a tooltip with a description if people complain.

In the touchpad kcm the backends for libinput and xlib are in different files (in the same backend/x11 subfolder). Is this possible here as well?

Dec 4 2017, 10:13 PM · Plasma

Nov 27 2017

xuetianweng added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..

@jriddell ping?

Nov 27 2017, 4:09 AM · Plasma

Nov 22 2017

xuetianweng committed R257:73f8cc2c1694: Include fcitx's platform input context in runtime. (authored by xuetianweng).
Include fcitx's platform input context in runtime.
Nov 22 2017, 10:32 PM
xuetianweng closed D8739: Include fcitx's platform input context in runtime..
Nov 22 2017, 10:32 PM
xuetianweng added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..

This disables the input kcm if libinput x11 plugin is not found. I expect this is fine, it is for ubuntu distros at least, but it might be worth asking distros if it causes them a problem.

Nov 22 2017, 7:04 PM · Plasma
xuetianweng updated the diff for D8798: Add xf86-input-libinput support for X11 mouse backend..

revert the accidentally changed currentIndex in ui file when save in designer.

Nov 22 2017, 6:59 PM · Plasma
xuetianweng added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..

Whether it shows up reallys depends on your system. Especially when there's multiple mouse driver available and you may using evdev.

Nov 22 2017, 6:57 PM · Plasma
xuetianweng added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..

@apol got a chance to test it?

Nov 22 2017, 2:41 AM · Plasma

Nov 21 2017

xuetianweng added a comment to D8739: Include fcitx's platform input context in runtime..

Also just FYI, My PR of fcitx's gtk im module recently got merged to freedesktop runtime. https://github.com/flatpak/freedesktop-sdk-images/pull/58

Nov 21 2017, 11:04 PM

Nov 17 2017

xuetianweng added a comment to D8798: Add xf86-input-libinput support for X11 mouse backend..
In D8798#169156, @apol wrote:
$ kcmshell5 touchpad
kcm_touchpad: Using X11 backend

The file on disk is at /usr/lib/x86_64-linux-gnu/qt5/plugins/kded_touchpad.so (on KDE Neon and other Ubuntu-based distros)

Are you sure? because this is modifying files in kcms/input that creates a kcm_input.so... Is it a kcm that extends kcm_touchpad.so?

Nov 17 2017, 9:37 PM · Plasma
xuetianweng updated the diff for D8798: Add xf86-input-libinput support for X11 mouse backend..

Fix based on comment

Nov 17 2017, 7:28 PM · Plasma

Nov 16 2017

xuetianweng committed R119:44d8a7500e36: Resolve the input method issue by always force focus in search field. (authored by xuetianweng).
Resolve the input method issue by always force focus in search field.
Nov 16 2017, 11:28 PM
xuetianweng closed D8770: Resolve the input method issue by always force focus in search field..
Nov 16 2017, 11:28 PM · Plasma

Nov 13 2017

xuetianweng committed R120:55a8d72e9786: Use heuristic weighted length algorithm to calculate the query term length. (authored by xuetianweng).
Use heuristic weighted length algorithm to calculate the query term length.
Nov 13 2017, 7:42 PM
xuetianweng closed D8771: Use heuristic weighted length algorithm to calculate the query term length..
Nov 13 2017, 7:42 PM · Plasma
xuetianweng updated the diff for D8771: Use heuristic weighted length algorithm to calculate the query term length..

Use the new kcoreaddons function to cal the length.

Nov 13 2017, 7:32 PM · Plasma
xuetianweng committed R244:6758d45cb596: Add a new function to measure the length by text. (authored by xuetianweng).
Add a new function to measure the length by text.
Nov 13 2017, 7:21 PM
xuetianweng closed D8800: Add a new function to measure the length by text..
Nov 13 2017, 7:21 PM · Frameworks
xuetianweng added a reviewer for D8800: Add a new function to measure the length by text.: Frameworks.
Nov 13 2017, 7:12 PM · Frameworks
xuetianweng created D8800: Add a new function to measure the length by text..
Nov 13 2017, 7:12 PM · Frameworks
xuetianweng added a reviewer for D8798: Add xf86-input-libinput support for X11 mouse backend.: Plasma.
Nov 13 2017, 6:47 PM · Plasma
xuetianweng created D8798: Add xf86-input-libinput support for X11 mouse backend..
Nov 13 2017, 6:45 PM · Plasma

Nov 12 2017

xuetianweng added inline comments to D8771: Use heuristic weighted length algorithm to calculate the query term length..
Nov 12 2017, 5:47 PM · Plasma
xuetianweng updated the diff for D8771: Use heuristic weighted length algorithm to calculate the query term length..

forget to use else..

Nov 12 2017, 5:46 PM · Plasma
xuetianweng updated the diff for D8771: Use heuristic weighted length algorithm to calculate the query term length..

Revert the accident checking length change. Also make weightedLength linkage local.

Nov 12 2017, 11:04 AM · Plasma
xuetianweng created D8771: Use heuristic weighted length algorithm to calculate the query term length..
Nov 12 2017, 11:02 AM · Plasma
xuetianweng updated the diff for D8770: Resolve the input method issue by always force focus in search field..

revert the reordering of code in unrelated part

Nov 12 2017, 10:29 AM · Plasma
xuetianweng created D8770: Resolve the input method issue by always force focus in search field..
Nov 12 2017, 10:26 AM · Plasma

Nov 9 2017

xuetianweng committed R120:be8f58ac1a0b: Merge branch 'Plasma/5.11' (authored by xuetianweng).
Merge branch 'Plasma/5.11'
Nov 9 2017, 6:40 PM
xuetianweng committed R120:46aaa0e76c7b: Preserve the order in dbus menu when doing action reusing. (authored by xuetianweng).
Preserve the order in dbus menu when doing action reusing.
Nov 9 2017, 6:39 PM
xuetianweng closed D8585: Preserve the order in dbus menu when doing action reusing..
Nov 9 2017, 6:39 PM · Plasma
xuetianweng updated the diff for D8739: Include fcitx's platform input context in runtime..

Add a version tag instead of always using master.

Nov 9 2017, 6:21 PM
xuetianweng added a reviewer for D8585: Preserve the order in dbus menu when doing action reusing.: broulik.
Nov 9 2017, 6:14 PM · Plasma
xuetianweng created D8739: Include fcitx's platform input context in runtime..
Nov 9 2017, 6:12 PM
xuetianweng committed R119:40f8edd70f4a: Refactor kcm_input to enable having multiple backends. (authored by xuetianweng).
Refactor kcm_input to enable having multiple backends.
Nov 9 2017, 3:09 AM
xuetianweng closed D8460: Refactor kcm_input to enable having multiple backends..
Nov 9 2017, 3:09 AM · Plasma

Nov 5 2017

xuetianweng accepted D7074: Avoid crashing kded on wayland session.
Nov 5 2017, 2:59 AM
xuetianweng accepted D7338: Use QScreen to monitor screen geometry changes.
Nov 5 2017, 2:58 AM

Nov 4 2017

xuetianweng added inline comments to D7338: Use QScreen to monitor screen geometry changes.
Nov 4 2017, 9:51 PM
xuetianweng added inline comments to D7074: Avoid crashing kded on wayland session.
Nov 4 2017, 9:44 PM

Nov 3 2017

xuetianweng requested changes to D7074: Avoid crashing kded on wayland session.
Nov 3 2017, 5:33 PM
xuetianweng added a comment to D7074: Avoid crashing kded on wayland session.

Since those class are called "X11....", can you avoid using those class in the caller instead of make themselves check the platform?

Nov 3 2017, 5:32 PM
xuetianweng requested changes to D7338: Use QScreen to monitor screen geometry changes.

Sorry for being lazy to review this.
I noticed that there's no devicePixelRatio in your code change so I think there's a problem in hidpi.
AFAIK, QScreen returns size after scaled with hidpi. You need to restore it to make it work on hidpi correctly.

Nov 3 2017, 5:29 PM
xuetianweng abandoned D5805: include directory should contains all directory from pkg-config.

Just noticed that FindPkgConfig has import_module now.. Personally I just port my code to use that.

Nov 3 2017, 5:25 PM · Build System, Frameworks
xuetianweng abandoned D8168: kcm_input: Refactor the code and add support for libinput under X11.

Being split into small patches

Nov 3 2017, 4:05 PM · Plasma
xuetianweng reclaimed D8460: Refactor kcm_input to enable having multiple backends..

.. Sorry click on the wrong one.

Nov 3 2017, 4:05 PM · Plasma
xuetianweng abandoned D8460: Refactor kcm_input to enable having multiple backends..

To be split into small patches.

Nov 3 2017, 4:04 PM · Plasma

Nov 2 2017

xuetianweng added a reviewer for D8460: Refactor kcm_input to enable having multiple backends.: Plasma.
Nov 2 2017, 4:02 AM · Plasma
xuetianweng added a reviewer for D8529: Plasma change icons should exit after its work finished.: Plasma.
Nov 2 2017, 4:01 AM · Plasma

Nov 1 2017

xuetianweng added a comment to D8460: Refactor kcm_input to enable having multiple backends..
In D8460#161613, @subdiff wrote:

Also, I doubt if our X11 backend work on Xwayland. AFAIK Xwayland will only
get a virtual cursor. Thus I just move the condition to check the name of qpa
platform for now.

Can you explain this more? And why is checking the qpa platform name now different to the previous check? But I think you're right that the backend is not used in the Wayland session. The workaround in KWin reads in the X mouse acceleration directly from the config file.

Nov 1 2017, 3:28 AM · Plasma
xuetianweng updated the diff for D8460: Refactor kcm_input to enable having multiple backends..

Remove backend check so xwayland settings may be changed.

Nov 1 2017, 3:27 AM · Plasma
xuetianweng added inline comments to D8460: Refactor kcm_input to enable having multiple backends..
Nov 1 2017, 3:07 AM · Plasma
xuetianweng updated the diff for D8460: Refactor kcm_input to enable having multiple backends..

update based on comments.

Nov 1 2017, 3:06 AM · Plasma

Oct 31 2017

xuetianweng created D8585: Preserve the order in dbus menu when doing action reusing..
Oct 31 2017, 11:40 PM · Plasma
xuetianweng committed R112:965ffbd40074: Merge branch 'Plasma/5.11' (authored by xuetianweng).
Merge branch 'Plasma/5.11'
Oct 31 2017, 4:43 AM
xuetianweng committed R112:3bb29aca376e: Fix i18ncd -> i18ndc. (authored by xuetianweng).
Fix i18ncd -> i18ndc.
Oct 31 2017, 4:43 AM

Oct 30 2017

xuetianweng added a comment to D8529: Plasma change icons should exit after its work finished..

@mart I understand what you want to say, but for this specific case:

Oct 30 2017, 2:40 PM · Plasma

Oct 27 2017

xuetianweng created D8529: Plasma change icons should exit after its work finished..
Oct 27 2017, 10:51 PM · Plasma
xuetianweng updated the diff for D8460: Refactor kcm_input to enable having multiple backends..

Update accroding to subdiff's comment.

Oct 27 2017, 1:14 AM · Plasma

Oct 25 2017

xuetianweng created D8460: Refactor kcm_input to enable having multiple backends..
Oct 25 2017, 4:16 AM · Plasma
xuetianweng committed R119:987b4dec9264: Port kcm input to UI File. (authored by xuetianweng).
Port kcm input to UI File.
Oct 25 2017, 2:46 AM
xuetianweng closed D8456: Port kcm input to UI File..
Oct 25 2017, 2:45 AM · Plasma
xuetianweng updated the diff for D8456: Port kcm input to UI File..

Merge kmousedlg.ui into kcmmouse.ui.

Oct 25 2017, 1:16 AM · Plasma

Oct 24 2017

xuetianweng created D8456: Port kcm input to UI File..
Oct 24 2017, 10:33 PM · Plasma
xuetianweng added a comment to D8168: kcm_input: Refactor the code and add support for libinput under X11.

ping

Oct 24 2017, 4:15 AM · Plasma

Oct 17 2017

xuetianweng added inline comments to D8346: Remove blocking call in KStatusNotifierItem.
Oct 17 2017, 5:58 PM · Frameworks
xuetianweng added inline comments to D8346: Remove blocking call in KStatusNotifierItem.
Oct 17 2017, 5:49 PM · Frameworks

Oct 16 2017

xuetianweng committed R119:e0735ebd5033: Merge branch 'Plasma/5.11' (authored by xuetianweng).
Merge branch 'Plasma/5.11'
Oct 16 2017, 5:22 AM
xuetianweng committed R119:2f65154995bb: kimpanel: we don't change text color in new implementation. remove used code. (authored by xuetianweng).
kimpanel: we don't change text color in new implementation. remove used code.
Oct 16 2017, 5:20 AM

Oct 7 2017

xuetianweng updated the test plan for D8168: kcm_input: Refactor the code and add support for libinput under X11.
Oct 7 2017, 1:15 PM · Plasma
xuetianweng retitled D8168: kcm_input: Refactor the code and add support for libinput under X11 from kcm_input: Refactor the code to enable support of multiple backends. to kcm_input: Refactor the code and add support for libinput under X11.
Oct 7 2017, 1:14 PM · Plasma
xuetianweng updated the diff for D8168: kcm_input: Refactor the code and add support for libinput under X11.

using a UI file and add libinput support.

Oct 7 2017, 1:13 PM · Plasma
xuetianweng created D8168: kcm_input: Refactor the code and add support for libinput under X11.
Oct 7 2017, 8:56 AM · Plasma

Oct 5 2017

xuetianweng updated the task description for T6838: Modern and Global Text Input For Every User (Input Methods, Emoji, Touch, ...).
Oct 5 2017, 5:38 PM · Goal settings 2017
xuetianweng committed R98:59c62319781b: Add support for gtk3 theme variant feature. (authored by xuetianweng).
Add support for gtk3 theme variant feature.
Oct 5 2017, 4:02 PM
xuetianweng closed D8149: Add support for gtk3 theme variant feature..
Oct 5 2017, 4:02 PM · Plasma