- User Since
- Feb 27 2016, 6:35 PM (150 w, 4 d)
Thu, Jan 3
Jul 22 2018
Jun 6 2018
Mar 13 2018
Mar 7 2018
Not so sure why phabricator didn't set you as the commit author... sorry about that.
Mar 6 2018
May I ask when this gsettings is introduced? Is it required after certain ibus version? Is there any case that this will not work?
Feb 14 2018
I sent the comment before you corrected the diff branch. LGTM.
Oh, ok.. now the diff looks normal.
Emm, mind to get rid of the .desktop part for this review?
Jan 6 2018
Jan 5 2018
Dec 4 2017
Nov 27 2017
Nov 22 2017
revert the accidentally changed currentIndex in ui file when save in designer.
Whether it shows up reallys depends on your system. Especially when there's multiple mouse driver available and you may using evdev.
@apol got a chance to test it?
Nov 21 2017
Also just FYI, My PR of fcitx's gtk im module recently got merged to freedesktop runtime. https://github.com/flatpak/freedesktop-sdk-images/pull/58
Nov 17 2017
Fix based on comment
Nov 16 2017
Nov 13 2017
Use the new kcoreaddons function to cal the length.
Nov 12 2017
forget to use else..
Revert the accident checking length change. Also make weightedLength linkage local.
revert the reordering of code in unrelated part
Nov 9 2017
Add a version tag instead of always using master.
Nov 5 2017
Nov 4 2017
Nov 3 2017
Since those class are called "X11....", can you avoid using those class in the caller instead of make themselves check the platform?
Sorry for being lazy to review this.
I noticed that there's no devicePixelRatio in your code change so I think there's a problem in hidpi.
AFAIK, QScreen returns size after scaled with hidpi. You need to restore it to make it work on hidpi correctly.
Just noticed that FindPkgConfig has import_module now.. Personally I just port my code to use that.
Being split into small patches
.. Sorry click on the wrong one.
To be split into small patches.
Nov 2 2017
Nov 1 2017
Remove backend check so xwayland settings may be changed.
update based on comments.
Oct 31 2017
Oct 30 2017
@mart I understand what you want to say, but for this specific case:
Oct 27 2017
Update accroding to subdiff's comment.
Oct 25 2017
Merge kmousedlg.ui into kcmmouse.ui.
Oct 24 2017
Oct 17 2017
Oct 16 2017
Oct 7 2017
using a UI file and add libinput support.