Differential D28409

ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows
ClosedPublic
Actions

Authored by dfaure on Mar 29 2020, 9:17 PM.

Details

Reviewers
kossebau
apol
krop
Commits
R240:907d46e0d244: ECM: attempt to fix KDEInstallDirsTest.relative_or_absolute on Windows
Summary

Not passing CMAKE_INSTALL_PREFIX is a weird thing to do. The test shows
"Installing in ." and some values like KDE_INSTALL_FULL_EXECROOTDIR
become "/" which is considered relative on Windows.

The test that passes /usr to CMAKE_INSTALL_PREFIX actually passes on
Windows. Pass /tmp to the other test, remove the test without prefix.

Test Plan

Passes on Linux, not tested on Windows, CI will do that

Diff Detail

Repository
R240 Extra CMake Modules
Branch
master
Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 24428
Build 24446: arc lint + arc unit
dfaure created this revision.Mar 29 2020, 9:17 PM
Restricted Application added projects: Frameworks, Build System. · View Herald TranscriptMar 29 2020, 9:17 PM
Restricted Application added subscribers: kde-buildsystem, kde-frameworks-devel. · View Herald Transcript
dfaure requested review of this revision.Mar 29 2020, 9:17 PM
apol added a comment.Apr 5 2020, 2:40 PM

Will /tmp then still work on Windows?

dfaure added inline comments.Apr 5 2020, 3:03 PM
tests/CMakeLists.txt
146

This test uses /usr and passes on Windows.

It's not like those paths have to exist.

apol accepted this revision.Apr 5 2020, 3:04 PM
This revision is now accepted and ready to land.Apr 5 2020, 3:04 PM
dfaure closed this revision.Apr 5 2020, 3:15 PM

Revision Contents
Changeset List

PathPackages
Mtests/CMakeLists.txt (4 lines)

Diff 78810

View Options

tests/CMakeLists.txt

Loading...