Let's go. I have not enough time for a proper review but a big +1

Great, thanks again

In D23206#513301, @astippich wrote:

Thanks a lot!
There is some added space in the all tracks view between the first and the second line, which imho is a little too much. Using elisaTheme.layoutVerticalMargin / 2 for the trackDelegateHeight works for me here, could please try that?

• rebase

• rebase

Thanks a lot!
There is some added space in the all tracks view between the first and the second line, which imho is a little too much. Using elisaTheme.layoutVerticalMargin / 2 for the trackDelegateHeight works for me here, could please try that?

If you would like to start contributing, you may have a look at the Junior Jobs column of the tasks or try to fix some bugs at https://bugs.kde.org/buglist.cgi?component=general&list_id=1655384&product=elisa&resolution=---

Okay thanks. No, I haven't faced these issues.

In T7570#195611, @astippich wrote:

Do you experience any problems yourself? Judging from the bug reports, the bugs have been fixed and this task should have been closed.
@mgallien are all bugs fixed?

Do you experience any problems yourself? Judging from the bug reports, the bugs have been fixed and this task should have been closed.
@mgallien are all bugs fixed?

• rebase

• rebase on master

In D23132#511902, @astippich wrote:

In D23132#511825, @mykolak wrote:

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

Is that a regression? Since I cannot test this, are you able to provide a fix? The issue may be located at
https://phabricator.kde.org/source/elisa/browse/master/src/qml/GridBrowserView.qml$127

Is anyone working on this? If not I'd like to help out with this.

In D23132#511926, @ngraham wrote:

If you're adjusting the DPI using the Force Fonts DPI spinbox, you're doing something unsupported. This patch is for people who are (correctly) using the scaling slider on the KScreen KCM (i.e. the displays page in System Settings).

In D23132#511825, @mykolak wrote:

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

In D23132#511825, @mykolak wrote:

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

On my 144 DPI screen album and artist names text parts (lower part of 'g', 'p', 'y') are outside of selection box. I think the problem is that for 144 DPI scaling is took as 1 but text is larger anyway. Maybe on 192 DPI it'll be fine.

Really nice. Thank you

• fix code style again

• fix code style and unrelated changes
• fix remaining tracks label

I don't want to remove ManageHeaderBar, on the contrary. This is a simplification and cleanup in order to easily extend it in the future after D22771, which is the goal of this whole series.
While working on it, I found that the ManageHeaderBar is needlessly entangled to the MediaPlayList by connecting to all of those signals, but which are mostly ignored. This is just because of the remaining tracks, for which the MediaPlayList is the correct place to retrieve the information.
By only connecting to the currentTrackChanged signal, the rest can be implemented much more easily. D22771 is working towards T7674

Please note that I cannot test this myself due to lack of a high DPI monitor

I forgot to say that the very big reduction in line count is really good. Thanks for that

Could you please add a general overview of what is the goal of this change ?

Thanks. Just wanted to make sure that it does not fall through

In D22772#508609, @astippich wrote:

friendly ping @mgallien for the series

friendly ping @mgallien for the series

• further simplify

Everything works and looks sane enough to me, but I'm not super familiar with all of this so I'm going to leave the review to @mgallien if you don't mind. :)

Very nice! I learned about StateChangeScript, too. Seems handy.

In D12992#503172, @KonqiDragon wrote:

In D12992#269399, @abetts wrote:

I think we are trying hard to accommodate and the elements are not lending themselves to turn them into an E with some musical tones. I reviewed a few music sheets looking for commonalities. I feel also that the icon is busy, it is trying really hard to tell you that this app is about music. I feel we can simplify and provide other ideas.

Here is a proposal. Not final. I welcome feedback. The idea here is to show soundwaves instead.

The colors must match to HIG? I don't understand why KDE Applications have a logos in different styles. We do not have complete unify KDE style.

In D12992#269399, @abetts wrote:

I think we are trying hard to accommodate and the elements are not lending themselves to turn them into an E with some musical tones. I reviewed a few music sheets looking for commonalities. I feel also that the icon is busy, it is trying really hard to tell you that this app is about music. I feel we can simplify and provide other ideas.

Here is a proposal. Not final. I welcome feedback. The idea here is to show soundwaves instead.

The search bar is now working perfectly with the new version of my patch. 🎉

It's amazing how you notice these little things :) thanks!

• force focus upon entering expandend state

This fixes the potential crash issue (yikes) and the need to hit the shortcut multiple times, but now the search field no longer automatically receives focus when that action is triggered and it becomes visible.

Is anybody working on this?

Given that we're already depending on something newer than the 5.9 Qt LTS version, I don't see the harm in this, especially if it allows us to clean some things up.

Great work!

probably arcanist trying to apply the already merged dependent revision, I've rebased

• rebase

• rebase

• rebase

• rebase

Needs a rebase I think.