implement high dpi support, needs proper hardware for testing
Description
Details
- Differential Revisions
- D10460: To make theme size depend on DPI
- Commits
- D23132 / R255:3710916442cb: Use Qt's highDPI scaling
Related Objects
I can test HiDPI support. I'm waiting for this.
You can look at other applications like Okular which fixed it recently.
Thanks for the offer, but we need to do the port to qtquickcontrols 2 first, and that must currently wait until we can require frameworks > 5.40. so it will probably take some time
I've started to hack on elisa yesterday. I've enabled hidpi pixmaps an changed from font.pixelSize to font.pointSize in qml. However the fonts are still not rendered correctly, see:
https://xor.cryptomilk.org/elisa/elisa.png
I tried to find some documentation how to fix that, but after searching for one hour I gave up. I don't really understand what the issue is here.
Patch: https://xor.cryptomilk.org/elisa/elisa-hidpi.patch.txt
I just found that:
Warning: Qt Quick Controls 1.x are not compatible with Qt's automatic high-DPI scaling. There is currently no available solution for high-DPI support in applications wishing to mix Qt Quick Controls and Qt Quick Controls 2.
That might be the issue.
Also doesn't really fix it. Here is a quick hack ...
https://xor.cryptomilk.org/elisa/elisa-qtquickcontrols2.patch.txt
Thanks for your work. There is also the review D10460. Could try to work together on that ? I cannot test but I can review them.
I also have a HiDPI system, I'd be glad to test. Just give me an @ mention and let me know if you need me.
I also have what may be considered a HiDPI system. Has a LED Monitor of 24" operating on a resolution of 2560 x 1440.
To be clear here, we recently implemented HiDPI support with the help of users, so this should be working. If you'd like to test, please give it a go. It's just that some things may be simplified when Elisa is not using controls v1 anymore.
As far as I can say, you have fixed most of the issues. Many thanks for that.
Can we close this task ?
While I think the issues are fixed right now, I left it open for the case when Elisa is a pure controls2 application. I'd like to test then if we can solely rely on Qt's internal scaling