High DPI support
Closed, ResolvedPublic

Description

implement high dpi support, needs proper hardware for testing

asn added a subscriber: asn.Dec 11 2017, 8:13 AM

I can test HiDPI support. I'm waiting for this.

You can look at other applications like Okular which fixed it recently.

gdrift added a subscriber: gdrift.Dec 12 2017, 8:10 AM

Thanks for the offer, but we need to do the port to qtquickcontrols 2 first, and that must currently wait until we can require frameworks > 5.40. so it will probably take some time

asn added a comment.Feb 14 2018, 8:20 AM

I've started to hack on elisa yesterday. I've enabled hidpi pixmaps an changed from font.pixelSize to font.pointSize in qml. However the fonts are still not rendered correctly, see:

https://xor.cryptomilk.org/elisa/elisa.png

I tried to find some documentation how to fix that, but after searching for one hour I gave up. I don't really understand what the issue is here.

Patch: https://xor.cryptomilk.org/elisa/elisa-hidpi.patch.txt

asn added a comment.Feb 14 2018, 8:29 AM

I just found that:

Warning: Qt Quick Controls 1.x are not compatible with Qt's automatic high-DPI scaling. There is currently no available solution for high-DPI support in applications wishing to mix Qt Quick Controls and Qt Quick Controls 2.

That might be the issue.

asn added a comment.Feb 14 2018, 9:41 AM

Also doesn't really fix it. Here is a quick hack ...

https://xor.cryptomilk.org/elisa/elisa-qtquickcontrols2.patch.txt

Thanks for your work. There is also the review D10460. Could try to work together on that ? I cannot test but I can review them.

asn added a comment.Feb 15 2018, 9:32 AM

Some text starts to look better if I remove:

renderType: Text.NativeRendering

I also have a HiDPI system, I'd be glad to test. Just give me an @ mention and let me know if you need me.

asn added a comment.Feb 22 2018, 6:32 AM

We already have this working more or less. Here is a screenshot of the work.

https://xor.cryptomilk.org/elisa/elisa-controls2.png

astippich moved this task from Backlog to In Progress on the Elisa board.Feb 24 2018, 2:08 PM

revisit support when elisa is a pure QtQuickControls2 application

astippich moved this task from In Progress to Backlog on the Elisa board.Mar 9 2018, 6:14 PM
astippich raised the priority of this task from Normal to High.

I also have what may be considered a HiDPI system. Has a LED Monitor of 24" operating on a resolution of 2560 x 1440.

To be clear here, we recently implemented HiDPI support with the help of users, so this should be working. If you'd like to test, please give it a go. It's just that some things may be simplified when Elisa is not using controls v1 anymore.

As far as I can say, you have fixed most of the issues. Many thanks for that.

Can we close this task ?

astippich added a comment.EditedMar 20 2018, 7:41 AM

While I think the issues are fixed right now, I left it open for the case when Elisa is a pure controls2 application. I'd like to test then if we can solely rely on Qt's internal scaling

astippich moved this task from Backlog to In Progress on the Elisa board.Aug 13 2019, 6:57 PM